Skip to content

Commit 9a36ded

Browse files
authored
Changed error message to give more info to user
1 parent 2528449 commit 9a36ded

File tree

2 files changed

+14
-5
lines changed

2 files changed

+14
-5
lines changed

src/main/java/com/mservicetech/openapi/validation/OpenApiValidator.java

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,11 @@ public class OpenApiValidator {
4141
final String VALIDATOR_REQUEST_PARAMETER_MISSING = "ERR11001";
4242

4343

44+
final String VALIDATOR_REQUEST_PARAMETER_PATH_MISSING = "ERR11108";
45+
final String VALIDATOR_REQUEST_PARAMETER_HEADER_MISSING = "ERR11017";
46+
final String VALIDATOR_REQUEST_PARAMETER_QUERY_MISSING = "ERR11000";
47+
48+
4449
public String spec;
4550
public OpenApiHelper openApiHelper;
4651
public SchemaValidator schemaValidator;
@@ -203,7 +208,7 @@ private Status validatePathParameters(final RequestEntity requestEntity, final N
203208
return result.getStatus();
204209
}
205210
if (result.skippedParameters!=null && !result.skippedParameters.isEmpty()) {
206-
return result.skippedParameters.stream().map(p-> new Status (VALIDATOR_REQUEST_PARAMETER_MISSING, p.getName(), openApiOperation.getPathString().original()))
211+
return result.skippedParameters.stream().map(p-> new Status (VALIDATOR_REQUEST_PARAMETER_PATH_MISSING, p.getName(), openApiOperation.getPathString().original()))
207212
.filter(s->s != null).findFirst().get();
208213
}
209214
return null;
@@ -253,7 +258,7 @@ private Status validateQueryParameters(final RequestEntity requestEntity, final
253258
return result.getStatus();
254259
}
255260
if (result.skippedParameters!=null && !result.skippedParameters.isEmpty()) {
256-
return result.skippedParameters.stream().map(p-> new Status (VALIDATOR_REQUEST_PARAMETER_MISSING, p.getName(), openApiOperation.getPathString().original()))
261+
return result.skippedParameters.stream().map(p-> new Status (VALIDATOR_REQUEST_PARAMETER_QUERY_MISSING, p.getName(), openApiOperation.getPathString().original()))
257262
.filter(s->s != null).findFirst().get();
258263
}
259264
return null;
@@ -281,7 +286,7 @@ private Optional<Status> validatePathLevelHeaders(final RequestEntity requestEnt
281286
return Optional.ofNullable(result.getStatus());
282287
}
283288
if (result.skippedParameters!=null && !result.skippedParameters.isEmpty()) {
284-
return result.skippedParameters.stream().map(p-> new Status (VALIDATOR_REQUEST_PARAMETER_MISSING, p.getName(), openApiOperation.getPathString().original()))
289+
return result.skippedParameters.stream().map(p-> new Status (VALIDATOR_REQUEST_PARAMETER_HEADER_MISSING, p.getName(), openApiOperation.getPathString().original()))
285290
.filter(s->s != null).findFirst();
286291
}
287292
return Optional.ofNullable(null);
@@ -296,7 +301,7 @@ private Optional<Status> validateOperationLevelHeaders(final RequestEntity reque
296301
return Optional.ofNullable(result.getStatus());
297302
}
298303
if (result.skippedParameters!=null && !result.skippedParameters.isEmpty()) {
299-
return result.skippedParameters.stream().map(p-> new Status (VALIDATOR_REQUEST_PARAMETER_MISSING, p.getName(), openApiOperation.getPathString().original()))
304+
return result.skippedParameters.stream().map(p-> new Status (VALIDATOR_REQUEST_PARAMETER_HEADER_MISSING, p.getName(), openApiOperation.getPathString().original()))
300305
.filter(s->s != null).findFirst();
301306
}
302307
return Optional.ofNullable(null);

src/main/resources/status.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -566,7 +566,11 @@ ERR11107:
566566
code: ERR11107
567567
message: COMPRESSION_EXCEPTION
568568
description: Exception occurs during compression %s.
569-
569+
ERR11108:
570+
statusCode: 400
571+
code: ERR11108
572+
message: VALIDATOR_REQUEST_PARAMETER_PATH_MISSING
573+
description: Path parameter %s is required on path %s but not found in request.
570574

571575
# 11200 - 11299 light hybrid validation errors
572576
ERR11200:

0 commit comments

Comments
 (0)