Merge branch 'AuthCodeFlowInvalidSecret' into isVisible

Author: mribbons

android/src/main/java/io/fullstack/oauth/OAuthManagerFragmentController.java

@@ -375,6 +375,7 @@ protected OAuth2AccessToken doInBackground(Void... params) {
       } catch (OAuth2AccessTokenErrorResponse ex)
       {
         Log.e(TAG, "Failed to extract access token: " + ex.getMessage());
+        mCtrl.onError(-1, ex.getMessage(), "Failed to extract access token.");        
         return null;
       } catch (IOException ex) {
         Log.e(TAG, "An exception occurred getRequestToken: " + ex.getMessage());

android/src/main/java/io/fullstack/oauth/OAuthManagerModule.java

@@ -120,6 +120,18 @@ public void onRequestTokenError(final Exception ex) {
           Log.e(TAG, "Exception with request token: " + ex.getMessage());
           _credentialsStore.delete(providerName);
           _credentialsStore.commit();
+
+          WritableMap error = Arguments.createMap();
+          error.putString("message", ex.getMessage());
+
+          // In an invalid client situation we will get two errors, first for the invalid client, and second for the null access token
+          // we really want to report the invalid client error because it provides better feedback
+          try {
+            callback.invoke(error);
+          } catch (Exception e2)
+          {
+            Log.e(TAG, "exception with request: callback failed: " + e2.getMessage() );
+          }          
         }
         public void onOAuth1AccessToken(final OAuth1AccessToken accessToken) {
           _credentialsStore.store(providerName, accessToken);