Skip to content

Commit df16dec

Browse files
committed
refactor(NODE-3157): Remove needless assignment
1 parent a6f619e commit df16dec

File tree

1 file changed

+2
-17
lines changed

1 file changed

+2
-17
lines changed

src/operations/find_and_modify.ts

Lines changed: 2 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
11
import { ReadPreference } from '../read_preference';
2-
import {
3-
maxWireVersion,
4-
applyRetryableWrites,
5-
decorateWithCollation,
6-
hasAtomicOperators,
7-
Callback
8-
} from '../utils';
2+
import { maxWireVersion, decorateWithCollation, hasAtomicOperators, Callback } from '../utils';
93
import { MongoError } from '../error';
104
import { CommandOperation, CommandOperationOptions } from './command';
115
import { defineAspects, Aspect } from './operation';
@@ -79,7 +73,6 @@ interface FindAndModifyOptions extends CommandOperationOptions {
7973
hint?: Document;
8074

8175
// NOTE: These types are a misuse of options, can we think of a way to remove them?
82-
update?: boolean;
8376
remove?: boolean;
8477
new?: boolean;
8578
}
@@ -116,7 +109,7 @@ export class FindAndModifyOperation extends CommandOperation<Document> {
116109
const query = this.query;
117110
const sort = formatSort(this.sort);
118111
const doc = this.doc;
119-
let options = { ...this.options, ...this.bsonOptions };
112+
const options = { ...this.options, ...this.bsonOptions };
120113

121114
// Create findAndModify command object
122115
const cmd: Document = {
@@ -148,12 +141,6 @@ export class FindAndModifyOperation extends CommandOperation<Document> {
148141
cmd.maxTimeMS = options.maxTimeMS;
149142
}
150143

151-
// No check on the documents
152-
options.checkKeys = false;
153-
154-
// Final options for retryable writes
155-
options = applyRetryableWrites(options, coll.s.db);
156-
157144
// Decorate the findAndModify command with the write Concern
158145
if (options.writeConcern) {
159146
cmd.writeConcern = options.writeConcern;
@@ -225,7 +212,6 @@ export class FindOneAndReplaceOperation extends FindAndModifyOperation {
225212
) {
226213
// Final options
227214
const finalOptions = Object.assign({}, options);
228-
finalOptions.update = true;
229215
finalOptions.new = options.returnOriginal !== void 0 ? !options.returnOriginal : false;
230216
finalOptions.upsert = options.upsert !== void 0 ? !!options.upsert : false;
231217

@@ -255,7 +241,6 @@ export class FindOneAndUpdateOperation extends FindAndModifyOperation {
255241
) {
256242
// Final options
257243
const finalOptions = Object.assign({}, options);
258-
finalOptions.update = true;
259244
finalOptions.new =
260245
typeof options.returnOriginal === 'boolean' ? !options.returnOriginal : false;
261246
finalOptions.upsert = typeof options.upsert === 'boolean' ? options.upsert : false;

0 commit comments

Comments
 (0)