PR requested changes 3 (remaining changes)

Author: aditi-khare-mongoDB

src/mongo_logger.ts

@@ -421,11 +421,9 @@ export function stringifyWithMaxLen(
     strToTruncate =
       typeof value !== 'function'
         ? EJSON.stringify(value, options)
-        : value.name !== ''
-        ? value.name
-        : 'anonymous function';
+        : 'ReadPreference function';
   } catch (e) {
-    strToTruncate = `... ESJON failed : Error ${e.message}`;
+    strToTruncate = `Extended JSON serialization failed with: ${e.message}`;
   }
 
   return maxDocumentLength !== 0 && strToTruncate.length > maxDocumentLength
@@ -463,7 +461,7 @@ function attachCommandFields(
   log.commandName = commandEvent.commandName;
   log.requestId = commandEvent.requestId;
   log.driverConnectionId = commandEvent.connectionId;
-  const { host, port } = HostAddress.fromString(commandEvent.address ?? '').toHostPort();
+  const { host, port } = HostAddress.fromString(commandEvent.address).toHostPort();
   log.serverHost = host;
   log.serverPort = port;
   if (commandEvent?.serviceId) {
@@ -476,7 +474,7 @@ function attachCommandFields(
 }
 
 function attachConnectionFields(log: Record<string, any>, event: any) {
-  const { host, port } = HostAddress.fromString(event.address ?? '').toHostPort();
+  const { host, port } = HostAddress.fromString(event.address).toHostPort();
   log.serverHost = host;
   log.serverPort = port;
 
@@ -498,7 +496,7 @@ function attachServerHeartbeatFields(
   const { awaited, connectionId } = serverHeartbeatEvent;
   log.awaited = awaited;
   log.driverConnectionId = serverHeartbeatEvent.connectionId;
-  const { host, port } = HostAddress.fromString(connectionId ?? '').toHostPort();
+  const { host, port } = HostAddress.fromString(connectionId).toHostPort();
   log.serverHost = host;
   log.serverPort = port;
   return log;

test/unit/mongo_logger.test.ts

@@ -21,7 +21,6 @@ import {
   CONNECTION_READY,
   createStdioLogger,
   DEFAULT_MAX_DOCUMENT_LENGTH,
-  defaultLogTransform,
   type Log,
   type MongoDBLogWritable,
   MongoLogger,
@@ -57,7 +56,7 @@ describe('meta tests for BufferingStream', function () {
   });
 });
 
-describe('class MongoLogger', async function () {
+describe.only('class MongoLogger', async function () {
   describe('#constructor()', function () {
     it('assigns each property from the options object onto the logging class', function () {
       const componentSeverities: MongoLoggerOptions['componentSeverities'] = {
@@ -1334,15 +1333,6 @@ describe('class MongoLogger', async function () {
     });
   });
 
-  describe('defaultLogTransform', function () {
-    context('when provided a Loggable Event with invalid host-port', function () {
-      // this is an important case to consider, because in the case of an undefined address, the HostAddress.toString() function will throw
-      it('should not throw and output empty host string instead', function () {
-        expect(defaultLogTransform({ name: 'connectionCreated' }).serverHost).to.equal('');
-      });
-    });
-  });
-
   describe('log', async function () {
     const componentSeverities: MongoLoggerOptions['componentSeverities'] = {
       command: 'trace',