Skip to content

Commit ba7800f

Browse files
committed
test: skip correctly
1 parent 1999699 commit ba7800f

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

test/integration/transactions-convenient-api/transactions-convenient-api.spec.test.ts

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,19 +10,25 @@ const SKIPPED_TESTS = [
1010
];
1111

1212
describe('Transactions Convenient API Spec Unified Tests', function () {
13-
this.beforeEach(function () {
13+
beforeEach(function () {
1414
if (this.configuration.topologyType === 'LoadBalanced') {
1515
if (this.currentTest) {
1616
this.currentTest.skipReason =
1717
'TODO(NODE-5931) - Fix socket leaks in load balancer transaction tests.';
1818
}
19+
this.skip();
20+
}
21+
if (this.configuration.topologyType === 'Sharded' && process.env.MONGODB_VERSION === 'latest') {
22+
if (this.currentTest) {
23+
this.currentTest.skipReason = 'TODO(DRIVERS-2816) - Fix migration conflict errors';
24+
}
25+
this.skip();
1926
}
20-
this.skip();
2127
});
2228

2329
runUnifiedSuite(loadSpecTests(path.join('transactions-convenient-api', 'unified')), test => {
2430
return SKIPPED_TESTS.includes(test.description)
25-
? 'TODO(NODE-): Skipping failing transaction tests'
31+
? 'TODO(DRIVERS-5855): Skipping failing transaction tests'
2632
: false;
2733
});
2834
});

test/tools/unified-spec-runner/entities.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -543,8 +543,6 @@ export class EntitiesMap<E = Entity> extends Map<string, E> {
543543
trace('endSessions');
544544
for (const [, session] of this.mapOf('session')) {
545545
await session.endSession({ force: true });
546-
// In case the endSession logic didn't unpin the server.
547-
// session.unpin({ force: true });
548546
}
549547

550548
trace('closeClient');

0 commit comments

Comments
 (0)