Skip to content

Commit b20cae8

Browse files
committed
test(NODE-3713): specifically skip on macos
1 parent 5c30d1c commit b20cae8

File tree

5 files changed

+9
-6
lines changed

5 files changed

+9
-6
lines changed

test/functional/connections_stepdown.test.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,8 @@ function expectPoolWasNotCleared(initialCount) {
2727
}
2828

2929
// TODO: NODE-3819: Unskip flaky MacOS tests.
30-
describe.skip('Connections survive primary step down', function () {
30+
const maybeDescribe = process.platform === 'darwin' ? describe.skip : describe;
31+
maybeDescribe('Connections survive primary step down', function () {
3132
let client;
3233
let checkClient;
3334
let db;

test/functional/cursorstream.test.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,8 @@ describe('Cursor Streams', function () {
208208
});
209209

210210
// TODO: NODE-3819: Unskip flaky MacOS tests.
211-
it.skip('should stream documents across getMore command and count correctly', {
211+
const maybeIt = process.platform === 'darwin' ? it.skip : it;
212+
maybeIt('should stream documents across getMore command and count correctly', {
212213
metadata: {
213214
requires: { topology: ['single', 'replicaset', 'sharded', 'ssl', 'heap', 'wiredtiger'] }
214215
},

test/functional/examples/change_streams.test.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,9 @@
44
const setupDatabase = require('../shared').setupDatabase;
55
const expect = require('chai').expect;
66

7-
// TODO: NODE-3819: Unskip flaky MacOS tests.
8-
describe.skip('examples(change-stream):', function () {
7+
// TODO: NODE-3819: Unskip flaky MacOS/Windows tests.
8+
const maybeDescribe = process.platform !== 'linux' ? describe.skip : describe;
9+
maybeDescribe('examples(change-stream):', function () {
910
let client;
1011
let db;
1112

test/functional/find.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1655,7 +1655,7 @@ describe('Find', function () {
16551655
}
16561656
});
16571657

1658-
// TODO: NODE-3819: Unskip flaky MacOS tests.
1658+
// TODO: NODE-3819: Unskip flaky tests.
16591659
it.skip('shouldCorrectlyIterateOverCollection', {
16601660
metadata: {
16611661
requires: { topology: ['single', 'replicaset', 'sharded', 'ssl', 'heap', 'wiredtiger'] }

test/functional/unit-sdam/monitoring.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ describe('monitoring', function () {
2424
return mock.createServer().then(server => (mockServer = server));
2525
});
2626

27-
// TODO: NODE-3819: Unskip flaky MacOS tests.
27+
// TODO: NODE-3819: Unskip flaky tests.
2828
it.skip('should record roundTripTime', function (done) {
2929
mockServer.setMessageHandler(request => {
3030
const doc = request.document;

0 commit comments

Comments
 (0)