test(NODE-3299): convert txn legacy spec tests

Author: durran

test/integration/transactions/transactions.spec.test.js

@@ -3,83 +3,9 @@
 import { gte } from 'semver';
 
 const path = require('path');
-const { expect } = require('chai');
-const { TestRunnerContext, generateTopologyTests } = require('../../tools/spec-runner');
 const { runUnifiedSuite } = require('../../tools/unified-spec-runner/runner');
 const { loadSpecTests } = require('../../spec');
 
-function ignoreNsNotFoundForListIndexes(err) {
-  if (err.code !== 26) {
-    throw err;
-  }
-
-  return [];
-}
-
-class TransactionsRunnerContext extends TestRunnerContext {
-  assertCollectionExists(options) {
-    const client = this.sharedClient;
-    const db = client.db(options.database);
-    const collectionName = options.collection;
-
-    return db
-      .listCollections()
-      .toArray()
-      .then(collections => expect(collections.some(coll => coll.name === collectionName)).to.be.ok);
-  }
-
-  assertCollectionNotExists(options) {
-    const client = this.sharedClient;
-    const db = client.db(options.database);
-    const collectionName = options.collection;
-
-    return db
-      .listCollections()
-      .toArray()
-      .then(
-        collections => expect(collections.every(coll => coll.name !== collectionName)).to.be.ok
-      );
-  }
-
-  assertIndexExists(options) {
-    const client = this.sharedClient;
-    const collection = client.db(options.database).collection(options.collection);
-    const indexName = options.index;
-
-    return collection
-      .listIndexes()
-      .toArray()
-      .catch(ignoreNsNotFoundForListIndexes)
-      .then(indexes => expect(indexes.some(idx => idx.name === indexName)).to.be.ok);
-  }
-
-  assertIndexNotExists(options) {
-    const client = this.sharedClient;
-    const collection = client.db(options.database).collection(options.collection);
-    const indexName = options.index;
-
-    return collection
-      .listIndexes()
-      .toArray()
-      .catch(ignoreNsNotFoundForListIndexes)
-      .then(indexes => expect(indexes.every(idx => idx.name !== indexName)).to.be.ok);
-  }
-
-  assertSessionPinned(options) {
-    expect(options).to.have.property('session');
-
-    const session = options.session;
-    expect(session.isPinned).to.be.true;
-  }
-
-  assertSessionUnpinned(options) {
-    expect(options).to.have.property('session');
-
-    const session = options.session;
-    expect(session.isPinned).to.be.false;
-  }
-}
-
 const LATEST_UNIFIED_SKIP_TESTS = [
   'unpin after TransientTransactionError error on commit',
   'unpin on successful abort',
@@ -98,40 +24,36 @@ describe('Transactions Spec Unified Tests', function () {
   );
 });
 
-const LEGACY_SKIP_TESTS = [
-  // TODO(NODE-3943): Investigate these commit test failures
-  // OLD COMMENT: commitTransaction retry seems to be swallowed by mongos in these two cases
-  'commitTransaction retry fails on new mongos',
-  'unpin after transient error within a transaction and commit',
-
-  // TODO(NODE-2034): Will be implemented as part of NODE-2034
-  'Client side error in command starting transaction',
-  'Client side error when transaction is in progress'
-];
-
-describe('Transactions Spec Legacy Tests', function () {
-  const testContext = new TransactionsRunnerContext();
-  if (process.env.SERVERLESS) {
-    // TODO(NODE-3550): these tests should pass on serverless but currently fail
-    LEGACY_SKIP_TESTS.push(
-      'abortTransaction only performs a single retry',
-      'abortTransaction does not retry after Interrupted',
-      'abortTransaction does not retry after WriteConcernError Interrupted',
-      'commitTransaction does not retry error without RetryableWriteError label',
-      'commitTransaction is not retried after UnsatisfiableWriteConcern error',
-      'commitTransaction fails after Interrupted'
-    );
-  }
-
-  const testSuites = loadSpecTests(path.join('transactions', 'legacy'));
-  after(() => testContext.teardown());
-  before(function () {
-    return testContext.setup(this.configuration);
-  });
-
-  function testFilter(spec) {
-    return LEGACY_SKIP_TESTS.indexOf(spec.description) === -1;
-  }
-
-  generateTopologyTests(testSuites, testContext, testFilter);
-});
+// const LEGACY_SKIP_TESTS = [
+//   // TODO(NODE-3943): Investigate these commit test failures
+//   // OLD COMMENT: commitTransaction retry seems to be swallowed by mongos in these two cases
+//   'commitTransaction retry fails on new mongos',
+//   'unpin after transient error within a transaction and commit',
+//   // TODO(NODE-2034): Will be implemented as part of NODE-2034
+//   'Client side error in command starting transaction',
+//   'Client side error when transaction is in progress'
+// ];
+
+// describe('Transactions Spec Legacy Tests', function () {
+//   const testContext = new TransactionsRunnerContext();
+//   if (process.env.SERVERLESS) {
+//     // TODO(NODE-3550): these tests should pass on serverless but currently fail
+//     LEGACY_SKIP_TESTS.push(
+//       'abortTransaction only performs a single retry',
+//       'abortTransaction does not retry after Interrupted',
+//       'abortTransaction does not retry after WriteConcernError Interrupted',
+//       'commitTransaction does not retry error without RetryableWriteError label',
+//       'commitTransaction is not retried after UnsatisfiableWriteConcern error',
+//       'commitTransaction fails after Interrupted'
+//     );
+//   }
+//   const testSuites = loadSpecTests(path.join('transactions', 'legacy'));
+//   after(() => testContext.teardown());
+//   before(function () {
+//     return testContext.setup(this.configuration);
+//   });
+//   function testFilter(spec) {
+//     return LEGACY_SKIP_TESTS.indexOf(spec.description) === -1;
+//   }
+//   generateTopologyTests(testSuites, testContext, testFilter);
+// });