Skip to content

Commit 74fa556

Browse files
authored
Merge branch 'main' into NODE-6407/saslContinue-testing
2 parents 659a17e + e2aa15c commit 74fa556

File tree

5 files changed

+26
-33
lines changed

5 files changed

+26
-33
lines changed

.evergreen/config.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3662,7 +3662,7 @@ tasks:
36623662
type: setup
36633663
params:
36643664
updates:
3665-
- {key: NODE_LTS_VERSION, value: latest}
3665+
- {key: NODE_LTS_VERSION, value: '22'}
36663666
- {key: NPM_VERSION, value: '9'}
36673667
- func: install dependencies
36683668
- func: check resource management
@@ -3676,7 +3676,7 @@ tasks:
36763676
updates:
36773677
- {key: VERSION, value: latest}
36783678
- {key: TOPOLOGY, value: replica_set}
3679-
- {key: NODE_LTS_VERSION, value: latest}
3679+
- {key: NODE_LTS_VERSION, value: '22'}
36803680
- func: install dependencies
36813681
- func: bootstrap mongo-orchestration
36823682
- func: check resource management feature integration
@@ -5085,6 +5085,7 @@ buildvariants:
50855085
- test-tls-support-5.0
50865086
- test-tls-support-4.4
50875087
- test-tls-support-4.2
5088+
disable: true
50885089
- name: windows-vsCurrent-large-gallium
50895090
display_name: Windows Node16
50905091
run_on: windows-vsCurrent-large

.evergreen/generate_evergreen_tasks.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -436,12 +436,13 @@ for (const {
436436
display_name: `${osDisplayName} Node Latest`,
437437
run_on,
438438
expansions: { NODE_LTS_VERSION: 'latest' },
439-
tasks: tasks.map(({ name }) => name)
439+
tasks: tasks.map(({ name }) => name),
440+
// TODO(NODE-6641): Unskip the smoke tests
441+
disable: true
440442
};
441443
if (clientEncryption) {
442444
buildVariantData.expansions.CLIENT_ENCRYPTION = true;
443445
}
444-
445446
BUILD_VARIANTS.push(buildVariantData);
446447
}
447448
}
@@ -549,7 +550,7 @@ SINGLETON_TASKS.push(
549550
tags: ['resource-management'],
550551
commands: [
551552
updateExpansions({
552-
NODE_LTS_VERSION: 'latest',
553+
NODE_LTS_VERSION: LATEST_LTS,
553554
NPM_VERSION: 9
554555
}),
555556
{ func: 'install dependencies' },
@@ -563,7 +564,7 @@ SINGLETON_TASKS.push(
563564
updateExpansions({
564565
VERSION: 'latest',
565566
TOPOLOGY: 'replica_set',
566-
NODE_LTS_VERSION: 'latest'
567+
NODE_LTS_VERSION: LATEST_LTS
567568
}),
568569
{ func: 'install dependencies' },
569570
{ func: 'bootstrap mongo-orchestration' },

test/integration/node-specific/resource_clean_up.test.ts

Lines changed: 16 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -37,31 +37,22 @@ describe('Driver Resources', () => {
3737
if (globalThis.AbortController == null || typeof this.configuration.serverApi === 'string') {
3838
return;
3939
}
40-
try {
41-
const res = await runScriptAndReturnHeapInfo(
42-
'no_resource_leak_connect_close',
43-
this.configuration,
44-
async function run({ MongoClient, uri }) {
45-
const mongoClient = new MongoClient(uri, { minPoolSize: 100 });
46-
await mongoClient.connect();
47-
// Any operations will reproduce the issue found in v5.0.0/v4.13.0
48-
// it would seem the MessageStream has to be used?
49-
await mongoClient.db().command({ ping: 1 });
50-
await mongoClient.close();
51-
}
52-
);
53-
startingMemoryUsed = res.startingMemoryUsed;
54-
endingMemoryUsed = res.endingMemoryUsed;
55-
heap = res.heap;
56-
} catch (error) {
57-
// We don't expect the process execution to ever fail,
58-
// leaving helpful debugging if we see this in CI
59-
console.log(`runScript error message: ${error.message}`);
60-
console.log(`runScript error stack: ${error.stack}`);
61-
console.log(`runScript error cause: ${error.cause}`);
62-
// Fail the test
63-
this.test?.error(error);
64-
}
40+
const res = await runScriptAndReturnHeapInfo(
41+
'no_resource_leak_connect_close',
42+
this.configuration,
43+
async function run({ MongoClient, uri }) {
44+
const mongoClient = new MongoClient(uri, { minPoolSize: 100 });
45+
await mongoClient.connect();
46+
// Any operations will reproduce the issue found in v5.0.0/v4.13.0
47+
// it would seem the MessageStream has to be used?
48+
await mongoClient.db().command({ ping: 1 });
49+
await mongoClient.close();
50+
}
51+
);
52+
53+
startingMemoryUsed = res.startingMemoryUsed;
54+
endingMemoryUsed = res.endingMemoryUsed;
55+
heap = res.heap;
6556
});
6657

6758
describe('ending memory usage', () => {

test/integration/node-specific/resource_tracking_script_builder.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export type ProcessResourceTestFunction = (options: {
2828

2929
const HEAP_RESOURCE_SCRIPT_PATH = path.resolve(
3030
__dirname,
31-
'../../tools/fixtures/resource_script.in.js'
31+
'../../tools/fixtures/heap_resource_script.in.js'
3232
);
3333
const REPORT_RESOURCE_SCRIPT_PATH = path.resolve(
3434
__dirname,

test/tools/fixtures/heap_resource_script.in.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
const driverPath = DRIVER_SOURCE_PATH;
66
const func = FUNCTION_STRING;
7-
const name = NAME_STRING;
7+
const name = SCRIPT_NAME_STRING;
88
const uri = URI_STRING;
99
const iterations = ITERATIONS_STRING;
1010

0 commit comments

Comments
 (0)