Skip to content

Commit 157c75d

Browse files
fix: address Daria's comments
1 parent 8518dcd commit 157c75d

File tree

4 files changed

+8
-16
lines changed

4 files changed

+8
-16
lines changed

test/integration/enumerate_collections.test.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,12 @@ const testSuite = new UnifiedTestSuiteBuilder('listCollections with comment opti
55
.initialData({
66
collectionName: 'coll0',
77
databaseName: '',
8-
documents: [
9-
{ _id: 1, x: 11 },
10-
{ _id: 2, toBeDeleted: true } // This should only be used by the delete test
11-
]
8+
documents: [{ _id: 1, x: 11 }]
129
})
1310
.databaseName('listCollections-with-falsy-values')
1411
.test(
1512
new TestBuilder('listCollections should not send comment for server versions < 4.4')
16-
.runOnRequirement({ maxServerVersion: '4.4.0' })
13+
.runOnRequirement({ maxServerVersion: '4.3.99' })
1714
.operation({
1815
name: 'listCollections',
1916
arguments: {

test/integration/enumerate_databases.test.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -147,15 +147,12 @@ const testSuite = new UnifiedTestSuiteBuilder('listDatabases with comment option
147147
.initialData({
148148
collectionName: 'coll0',
149149
databaseName: '',
150-
documents: [
151-
{ _id: 1, x: 11 },
152-
{ _id: 2, toBeDeleted: true } // This should only be used by the delete test
153-
]
150+
documents: [{ _id: 1, x: 11 }]
154151
})
155152
.databaseName('listDatabases-with-falsy-values')
156153
.test(
157154
new TestBuilder('listDatabases should not send comment for server versions < 4.4')
158-
.runOnRequirement({ maxServerVersion: '4.4.0' })
155+
.runOnRequirement({ maxServerVersion: '4.3.99' })
159156
.operation({
160157
name: 'listDatabases',
161158
arguments: {

test/integration/enumerate_indexes.test.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,12 @@ const testSuite = new UnifiedTestSuiteBuilder('listIndexes with comment option')
55
.initialData({
66
collectionName: 'coll0',
77
databaseName: '',
8-
documents: [
9-
{ _id: 1, x: 11 },
10-
{ _id: 2, toBeDeleted: true } // This should only be used by the delete test
11-
]
8+
documents: [{ _id: 1, x: 11 }]
129
})
1310
.databaseName('listIndexes-with-falsy-values')
1411
.test(
1512
new TestBuilder('listIndexes should not send comment for server versions < 4.4')
16-
.runOnRequirement({ maxServerVersion: '4.4.0' })
13+
.runOnRequirement({ maxServerVersion: '4.3.99' })
1714
.operation({
1815
name: 'listIndexes',
1916
arguments: {

test/unit/operations/list_collections.test.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,9 @@ describe('ListCollectionsOperation', function () {
7777
expect(command).not.to.haveOwnProperty('comment');
7878
});
7979
});
80+
8081
context('when the wireVersion >= 9', function () {
81-
it('does not set a comment on the command', function () {
82+
it('sets a comment on the command', function () {
8283
const operation = new ListCollectionsOperation(
8384
db,
8485
{},

0 commit comments

Comments
 (0)