Skip to content

Commit 032c3fc

Browse files
committed
test: skip explicitly
1 parent 21a5069 commit 032c3fc

File tree

2 files changed

+18
-2
lines changed

2 files changed

+18
-2
lines changed

test/integration/transactions-convenient-api/transactions-convenient-api.spec.test.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,9 @@ import { runUnifiedSuite } from '../../tools/unified-spec-runner/runner';
66
const SKIPPED_TESTS = [
77
'callback succeeds after multiple connection errors',
88
'callback is not retried after non-transient error',
9-
'callback is not retried after non-transient error (DuplicateKeyError)'
9+
'callback is not retried after non-transient error (DuplicateKeyError)',
10+
'withTransaction succeeds if callback aborts',
11+
'unpin after transient error within a transaction'
1012
];
1113

1214
describe('Transactions Convenient API Spec Unified Tests', function () {
@@ -22,7 +24,7 @@ describe('Transactions Convenient API Spec Unified Tests', function () {
2224

2325
runUnifiedSuite(loadSpecTests(path.join('transactions-convenient-api', 'unified')), test => {
2426
return SKIPPED_TESTS.includes(test.description)
25-
? 'TODO(DRIVERS-5855): Skipping failing transaction tests'
27+
? 'TODO(NODE-5855/DRIVERS-2816): Skipping failing transaction tests'
2628
: false;
2729
});
2830
});

test/integration/unified-test-format/unified_test_format.spec.test.ts

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,20 @@ const filter: TestFilter = ({ description }) => {
2323
return 'TODO(NODE-3308): failures due unnecessary getMore and killCursors calls in 5.0';
2424
}
2525

26+
if (
27+
[
28+
'withTransaction and no transaction options set',
29+
'withTransaction inherits transaction options from client',
30+
'withTransaction inherits transaction options from defaultTransactionOptions',
31+
'withTransaction explicit transaction options',
32+
'remain pinned after non-transient Interrupted error on insertOne',
33+
'unpin after transient error within a transaction',
34+
'remain pinned after non-transient Interrupted error on insertOne'
35+
].includes(description)
36+
) {
37+
return 'TODO(DRIVERS-2816): fix migration conflict in transaction tests';
38+
}
39+
2640
if (
2741
process.env.AUTH === 'auth' &&
2842
[

0 commit comments

Comments
 (0)