SERVER-42754 Make RSMChangeListeners for shard configs exception-safe

Author: bcaimano

src/mongo/db/s/sharding_initialization_mongod.cpp

@@ -105,27 +105,33 @@ class ShardingReplicaSetChangeListener final : public ReplicaSetChangeNotifier::
                     LOG(2) << "Unable to schedule confirmed set update due to " << status;
                     return;
                 }
-                uassertStatusOK(status);
+                invariant(status);
 
-                LOG(0) << "Updating config server with confirmed set " << connStr;
-                Grid::get(serviceContext)->shardRegistry()->updateReplSetHosts(connStr);
+                try {
+                    LOG(0) << "Updating config server with confirmed set " << connStr;
+                    Grid::get(serviceContext)->shardRegistry()->updateReplSetHosts(connStr);
 
-                if (MONGO_FAIL_POINT(failUpdateShardIdentityConfigString)) {
-                    return;
-                }
+                    if (MONGO_FAIL_POINT(failUpdateShardIdentityConfigString)) {
+                        return;
+                    }
 
-                auto configsvrConnStr =
-                    Grid::get(serviceContext)->shardRegistry()->getConfigServerConnectionString();
+                    auto configsvrConnStr = Grid::get(serviceContext)
+                                                ->shardRegistry()
+                                                ->getConfigServerConnectionString();
 
-                // Only proceed if the notification is for the configsvr
-                if (configsvrConnStr.getSetName() != connStr.getSetName()) {
-                    return;
-                }
+                    // Only proceed if the notification is for the configsvr
+                    if (configsvrConnStr.getSetName() != connStr.getSetName()) {
+                        return;
+                    }
 
-                ThreadClient tc("updateShardIdentityConfigString", serviceContext);
-                auto opCtx = tc->makeOperationContext();
+                    ThreadClient tc("updateShardIdentityConfigString", serviceContext);
+                    auto opCtx = tc->makeOperationContext();
 
-                ShardingInitializationMongoD::updateShardIdentityConfigString(opCtx.get(), connStr);
+                    ShardingInitializationMongoD::updateShardIdentityConfigString(opCtx.get(),
+                                                                                  connStr);
+                } catch (const ExceptionForCat<ErrorCategory::ShutdownError>& e) {
+                    LOG(0) << "Unable to update config server due to " << e;
+                }
             });
     }
     void onPossibleSet(const State& state) final {

src/mongo/s/server.cpp

@@ -432,16 +432,20 @@ class ShardingReplicaSetChangeListener final : public ReplicaSetChangeNotifier::
             if (ErrorCodes::isCancelationError(args.status.code())) {
                 return;
             }
-            uassertStatusOK(args.status);
+            invariant(args.status);
 
-            LOG(0) << "Updating sharding state with confirmed set " << connStr;
+            try {
+                LOG(0) << "Updating sharding state with confirmed set " << connStr;
 
-            Grid::get(serviceContext)->shardRegistry()->updateReplSetHosts(connStr);
+                Grid::get(serviceContext)->shardRegistry()->updateReplSetHosts(connStr);
 
-            if (MONGO_FAIL_POINT(failReplicaSetChangeConfigServerUpdateHook)) {
-                return;
+                if (MONGO_FAIL_POINT(failReplicaSetChangeConfigServerUpdateHook)) {
+                    return;
+                }
+                ShardRegistry::updateReplicaSetOnConfigServer(serviceContext, connStr);
+            } catch (const ExceptionForCat<ErrorCategory::ShutdownError>& e) {
+                LOG(0) << "Unable to update sharding state due to " << e;
             }
-            ShardRegistry::updateReplicaSetOnConfigServer(serviceContext, connStr);
         };
 
         auto executor = Grid::get(_serviceContext)->getExecutorPool()->getFixedExecutor();