minor: update clippy to 1.75 (#1010)

Author: abr-egn

.evergreen/check-clippy.sh

@@ -6,7 +6,7 @@ source ./.evergreen/env.sh
 source ./.evergreen/feature-combinations.sh
 
 # Pin clippy to the latest version. This should be updated when new versions of Rust are released.
-CLIPPY_VERSION=1.71.0
+CLIPPY_VERSION=1.75.0
 
 rustup install $CLIPPY_VERSION
 

src/sdam/monitor.rs

@@ -626,19 +626,11 @@ impl MonitorRequestReceiver {
             };
             tokio::pin!(wait_for_check_request);
 
-            loop {
-                tokio::select! {
-                    _ = self.individual_check_request_receiver.changed() => {
-                        break;
-                    }
-                    _ = &mut wait_for_check_request => {
-                        break;
-                    }
-                    _ = self.handle_listener.wait_for_all_handle_drops() => {
-                        // Don't continue waiting after server has been removed from the topology.
-                        break;
-                    }
-                }
+            tokio::select! {
+                _ = self.individual_check_request_receiver.changed() => (),
+                _ = &mut wait_for_check_request => (),
+                // Don't continue waiting after server has been removed from the topology.
+                _ = self.handle_listener.wait_for_all_handle_drops() => (),
             }
         })
         .await;

src/test/client.rs

@@ -308,7 +308,7 @@ async fn list_authorized_databases() {
             .unwrap();
 
         assert_eq!(result.len(), 1);
-        assert_eq!(result.get(0).unwrap(), name);
+        assert_eq!(result.first().unwrap(), name);
     }
 
     for name in dbs {

src/test/spec/initial_dns_seedlist_discovery.rs

@@ -98,11 +98,11 @@ async fn run_test(mut test_file: TestFile) {
     };
 
     if let Some(true) = test_file.error {
-        assert!(matches!(result, Err(_)), "{}", test_file.comment.unwrap());
+        assert!(result.is_err(), "{}", test_file.comment.unwrap());
         return;
     }
 
-    assert!(matches!(result, Ok(_)), "non-Ok result: {:?}", result);
+    assert!(result.is_ok(), "non-Ok result: {:?}", result);
 
     let options = result.unwrap();
 

src/test/spec/write_error.rs

@@ -43,7 +43,7 @@ async fn details() {
             .reply
             .get_array("writeErrors")
             .unwrap()
-            .get(0)
+            .first()
             .unwrap()
             .as_document()
             .unwrap()

src/test/util.rs

@@ -528,7 +528,7 @@ pub(crate) fn log_uncaptured<S: AsRef<str>>(text: S) {
     let mut sinks = vec![&mut stderr as &mut dyn Write];
     let mut other;
     let other_path = std::env::var("LOG_UNCAPTURED").unwrap_or("/dev/tty".to_string());
-    if let Ok(f) = std::fs::OpenOptions::new().append(true).open(&other_path) {
+    if let Ok(f) = std::fs::OpenOptions::new().append(true).open(other_path) {
         other = f;
         sinks.push(&mut other);
     }

src/test/util/trace.rs

@@ -194,13 +194,13 @@ pub(crate) fn max_verbosity_levels_for_test_case(
             o.test_file_entities()
                 .unwrap()
                 .iter()
-                .for_each(|e| update_merged_levels(e))
+                .for_each(&mut update_merged_levels)
         });
 
     // test-file level entities. these might not all actually be used by this particular
     // test case but we include them for simplicity.
     if let Some(ref entities) = entities {
-        entities.iter().for_each(|e| update_merged_levels(e));
+        entities.iter().for_each(update_merged_levels);
     };
 
     merged_levels