Skip to content

Commit 7c8dcb0

Browse files
committed
address review
1 parent 50bc269 commit 7c8dcb0

File tree

2 files changed

+32
-16
lines changed

2 files changed

+32
-16
lines changed

.evergreen/generated_configs/tasks.yml

Lines changed: 30 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -8126,67 +8126,83 @@ tasks:
81268126
TOPOLOGY: sharded_cluster
81278127
PYTHON_VERSION: pypy3.10
81288128
tags: [server-version]
8129-
- name: test-python3.9-auth-ssl-standalone-cov
8129+
- name: test-python3.9-auth-nossl-standalone-cov
81308130
commands:
81318131
- func: run server
81328132
vars:
81338133
AUTH: auth
8134-
SSL: ssl
8134+
SSL: nossl
81358135
TOPOLOGY: standalone
81368136
COVERAGE: "1"
81378137
- func: run tests
81388138
vars:
81398139
AUTH: auth
8140-
SSL: ssl
8140+
SSL: nossl
81418141
TOPOLOGY: standalone
81428142
COVERAGE: "1"
81438143
PYTHON_VERSION: "3.9"
81448144
tags: [server-version]
8145-
- name: test-python3.10-noauth-nossl-replica-set-cov
8145+
- name: test-python3.10-noauth-nossl-standalone-cov
81468146
commands:
81478147
- func: run server
81488148
vars:
81498149
AUTH: noauth
81508150
SSL: nossl
8151-
TOPOLOGY: replica_set
8151+
TOPOLOGY: standalone
81528152
COVERAGE: "1"
81538153
- func: run tests
81548154
vars:
81558155
AUTH: noauth
81568156
SSL: nossl
8157-
TOPOLOGY: replica_set
8157+
TOPOLOGY: standalone
81588158
COVERAGE: "1"
81598159
PYTHON_VERSION: "3.10"
81608160
tags: [server-version]
8161-
- name: test-python3.12-noauth-nossl-standalone-cov
8161+
- name: test-python3.11-auth-nossl-replica-set-cov
8162+
commands:
8163+
- func: run server
8164+
vars:
8165+
AUTH: auth
8166+
SSL: nossl
8167+
TOPOLOGY: replica_set
8168+
COVERAGE: "1"
8169+
- func: run tests
8170+
vars:
8171+
AUTH: auth
8172+
SSL: nossl
8173+
TOPOLOGY: replica_set
8174+
COVERAGE: "1"
8175+
PYTHON_VERSION: "3.11"
8176+
tags: [server-version]
8177+
- name: test-python3.12-noauth-nossl-replica-set-cov
81628178
commands:
81638179
- func: run server
81648180
vars:
81658181
AUTH: noauth
81668182
SSL: nossl
8167-
TOPOLOGY: standalone
8183+
TOPOLOGY: replica_set
81688184
COVERAGE: "1"
81698185
- func: run tests
81708186
vars:
81718187
AUTH: noauth
81728188
SSL: nossl
8173-
TOPOLOGY: standalone
8189+
TOPOLOGY: replica_set
81748190
COVERAGE: "1"
81758191
PYTHON_VERSION: "3.12"
81768192
tags: [server-version]
8177-
- name: test-python3.13-auth-ssl-replica-set-cov
8193+
- name: test-python3.13-auth-nossl-sharded-cluster-cov
81788194
commands:
81798195
- func: run server
81808196
vars:
81818197
AUTH: auth
8182-
SSL: ssl
8183-
TOPOLOGY: replica_set
8198+
SSL: nossl
8199+
TOPOLOGY: sharded_cluster
81848200
COVERAGE: "1"
81858201
- func: run tests
81868202
vars:
81878203
AUTH: auth
8188-
SSL: ssl
8189-
TOPOLOGY: replica_set
8204+
SSL: nossl
8205+
TOPOLOGY: sharded_cluster
81908206
COVERAGE: "1"
81918207
PYTHON_VERSION: "3.13"
81928208
tags: [server-version]

.evergreen/scripts/generate_config.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -583,8 +583,8 @@ def create_server_version_tasks():
583583
# Test all pythons with sharded_cluster, auth, and ssl.
584584
task_types = [(p, "sharded_cluster", "auth", "ssl") for p in ALL_PYTHONS]
585585
# Test all combinations of topology, auth, and ssl, with rotating pythons.
586-
for python, topology, auth, ssl in zip_cycle(
587-
ALL_PYTHONS, TOPOLOGIES, ["auth", "noauth"], ["ssl", "nossl"]
586+
for python, (topology, auth, ssl) in zip_cycle(
587+
ALL_PYTHONS, product(TOPOLOGIES, ["auth", "noauth"], ["ssl", "nossl"])
588588
):
589589
# Skip the ones we already have.
590590
if topology == "sharded_cluster" and auth == "auth" and ssl == "ssl":

0 commit comments

Comments
 (0)