PHPLIB-159: rename uses UpdateOne() per the spec

Will Banfield · Will Banfield · commit cb2a7eebf9e4 · 2016-01-12T10:41:50.000-05:00
diff --git a/src/GridFS/Bucket.php b/src/GridFS/Bucket.php
@@ -279,14 +279,10 @@ public function openUploadStream($filename, array $options = [])
     public function rename(ObjectId $id, $newFilename)
     {
         $filesCollection = $this->collectionsWrapper->getFilesCollection();
-        $file = $filesCollection->findOne(['_id' => $id]);
-
-        if ($file === null) {
+        $result = $filesCollection->updateOne(['_id' => $id], ['$set' => ['filename' => $newFilename]]);
+        if($result->getModifiedCount() == 0) {
             throw new GridFSFileNotFoundException($id, $this->collectionsWrapper->getFilesCollection()->getNameSpace());
         }
-
-        $file->filename = $newFilename;
-        $filesCollection->replaceOne(['_id' => $id], $file);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -279,14 +279,10 @@ public function openUploadStream($filename, array $options = [])`
`279`	`279`	`public function rename(ObjectId $id, $newFilename)`
`280`	`280`	`{`
`281`	`281`	`$filesCollection = $this->collectionsWrapper->getFilesCollection();`
`282`		`- $file = $filesCollection->findOne(['_id' => $id]);`
`283`		`-`
`284`		`- if ($file === null) {`
	`282`	`+ $result = $filesCollection->updateOne(['_id' => $id], ['$set' => ['filename' => $newFilename]]);`
	`283`	`+ if($result->getModifiedCount() == 0) {`
`285`	`284`	`throw new GridFSFileNotFoundException($id, $this->collectionsWrapper->getFilesCollection()->getNameSpace());`
`286`	`285`	`}`
`287`		`-`
`288`		`- $file->filename = $newFilename;`
`289`		`- $filesCollection->replaceOne(['_id' => $id], $file);`
`290`	`286`	`}`
`291`	`287`
`292`	`288`	`/**`