Skip to content

Commit a453911

Browse files
committed
Merge branch 'test-deprecations' into PHPLIB-1369
2 parents abe745a + e962256 commit a453911

File tree

2 files changed

+8
-15
lines changed

2 files changed

+8
-15
lines changed

tests/GridFS/BucketFunctionalTest.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -953,8 +953,6 @@ public function testResolveStreamContextForRead(): void
953953
fclose($stream);
954954

955955
$method = new ReflectionMethod($this->bucket, 'resolveStreamContext');
956-
$method->setAccessible(true);
957-
958956
$context = $method->invokeArgs($this->bucket, ['gridfs://bucket/filename', 'rb', []]);
959957

960958
$this->assertIsArray($context);
@@ -969,8 +967,6 @@ public function testResolveStreamContextForRead(): void
969967
public function testResolveStreamContextForWrite(): void
970968
{
971969
$method = new ReflectionMethod($this->bucket, 'resolveStreamContext');
972-
$method->setAccessible(true);
973-
974970
$context = $method->invokeArgs($this->bucket, ['gridfs://bucket/filename', 'wb', []]);
975971

976972
$this->assertIsArray($context);

tests/Operation/WatchFunctionalTest.php

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
use MongoDB\Tests\CommandObserver;
2828
use PHPUnit\Framework\Attributes\DataProvider;
2929
use PHPUnit\Framework\Attributes\Group;
30+
use PHPUnit\Framework\Constraint\ObjectHasProperty;
3031
use PHPUnit\Framework\ExpectationFailedException;
3132
use ReflectionClass;
3233
use stdClass;
@@ -722,10 +723,7 @@ public function testInitialCursorIsNotClosed(): void
722723
$this->assertNotEquals('0', (string) $changeStream->getCursorId(true));
723724

724725
$rc = new ReflectionClass(ChangeStream::class);
725-
$rp = $rc->getProperty('iterator');
726-
$rp->setAccessible(true);
727-
728-
$iterator = $rp->getValue($changeStream);
726+
$iterator = $rc->getProperty('iterator')->getValue($changeStream);
729727

730728
$this->assertInstanceOf('IteratorIterator', $iterator);
731729

@@ -1223,7 +1221,6 @@ public function testSessionFreed(): void
12231221

12241222
$rc = new ReflectionClass($changeStream);
12251223
$rp = $rc->getProperty('resumeCallable');
1226-
$rp->setAccessible(true);
12271224

12281225
$this->assertIsCallable($rp->getValue($changeStream));
12291226

@@ -1280,19 +1277,19 @@ function (array $event) use (&$aggregateCommands): void {
12801277
$aggregateCommands[0]['pipeline'][0]->{'$changeStream'},
12811278
$this->logicalNot(
12821279
$this->logicalOr(
1283-
$this->objectHasAttribute('resumeAfter'),
1284-
$this->objectHasAttribute('startAfter'),
1285-
$this->objectHasAttribute('startAtOperationTime'),
1280+
new ObjectHasProperty('resumeAfter'),
1281+
new ObjectHasProperty('startAfter'),
1282+
new ObjectHasProperty('startAtOperationTime'),
12861283
),
12871284
),
12881285
);
12891286

12901287
$this->assertThat(
12911288
$aggregateCommands[1]['pipeline'][0]->{'$changeStream'},
12921289
$this->logicalOr(
1293-
$this->objectHasAttribute('resumeAfter'),
1294-
$this->objectHasAttribute('startAfter'),
1295-
$this->objectHasAttribute('startAtOperationTime'),
1290+
new ObjectHasProperty('resumeAfter'),
1291+
new ObjectHasProperty('startAfter'),
1292+
new ObjectHasProperty('startAtOperationTime'),
12961293
),
12971294
);
12981295

0 commit comments

Comments
 (0)