Keep forbidding empty replacement in ReplaceOne

GromNaN · GromNaN · commit 96f3bfeef4d0 · 2023-06-01T21:06:40.000+02:00
diff --git a/src/Operation/ReplaceOne.php b/src/Operation/ReplaceOne.php
@@ -89,7 +89,7 @@ public function __construct(string $databaseName, string $collectionName, $filte
             throw new InvalidArgumentException('First key in $replacement argument is an update operator');
         }
 
-        if ($replacement !== [] && is_pipeline($replacement)) {
+        if ($replacement === [] || is_pipeline($replacement)) {
             throw new InvalidArgumentException('$replacement argument is a pipeline');
         }
 
diff --git a/tests/Operation/ReplaceOneTest.php b/tests/Operation/ReplaceOneTest.php
@@ -37,7 +37,6 @@ public function testConstructorReplacementArgument($replacement): void
     public function provideReplacementDocuments()
     {
         return $this->wrapValuesForDataProvider([
-            [],
             ['y' => 1],
             (object) ['y' => 1],
             new BSONDocument(['y' => 1]),

Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,7 @@ public function __construct(string $databaseName, string $collectionName, $filte`
`89`	`89`	`throw new InvalidArgumentException('First key in $replacement argument is an update operator');`
`90`	`90`	`}`
`91`	`91`
`92`		`- if ($replacement !== [] && is_pipeline($replacement)) {`
	`92`	`+ if ($replacement === [] \|\| is_pipeline($replacement)) {`
`93`	`93`	`throw new InvalidArgumentException('$replacement argument is a pipeline');`
`94`	`94`	`}`
`95`	`95`
Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,6 @@ public function testConstructorReplacementArgument($replacement): void`
`37`	`37`	`public function provideReplacementDocuments()`
`38`	`38`	`{`
`39`	`39`	`return $this->wrapValuesForDataProvider([`
`40`		`- [],`
`41`	`40`	`['y' => 1],`
`42`	`41`	`(object) ['y' => 1],`
`43`	`42`	`new BSONDocument(['y' => 1]),`