Implement e2e search index management tests

mongodb/node-mongodb-native#3736

Author: GromNaN

src/Collection.php

@@ -21,6 +21,7 @@
 use Iterator;
 use MongoDB\BSON\JavascriptInterface;
 use MongoDB\Driver\Cursor;
+use MongoDB\Driver\Exception\CommandException;
 use MongoDB\Driver\Exception\RuntimeException as DriverRuntimeException;
 use MongoDB\Driver\Manager;
 use MongoDB\Driver\ReadConcern;
@@ -633,7 +634,14 @@ public function dropSearchIndex(string $name, array $options = []): void
         $operation = new DropSearchIndex($this->databaseName, $this->collectionName, $name);
         $server = select_server($this->manager, $options);
 
-        $operation->execute($server);
+        try {
+            $operation->execute($server);
+        } catch (CommandException $e) {
+            // Suppress namespace not found errors for idempotency
+            if ($e->getCode() !== 26) {
+                throw $e;
+            }
+        }
     }
 
     /**
@@ -1015,7 +1023,7 @@ public function listIndexes(array $options = [])
      * Only available when used against a 7.0+ Atlas cluster.
      *
      * @param array{name?: string} $options Command options
-     * @return Iterator&Countable
+     * @return Countable&Iterator<array{id: string, name: string, status: string, queryable: bool, latestDefinition: array}>
      * @throws InvalidArgumentException for parameter/option parsing errors
      * @throws DriverRuntimeException for other driver errors (e.g. connection errors)
      * @see ListSearchIndexes::__construct() for supported options

src/Model/SearchIndexInput.php

@@ -36,7 +36,7 @@
 class SearchIndexInput implements Serializable
 {
     /** @var array */
-    private $index;
+    private array $index;
 
     /**
      * @param array{name?: string, definition: array|object} $index Search index specification

src/Operation/CreateSearchIndexes.php

@@ -24,8 +24,8 @@
 use MongoDB\Exception\UnsupportedException;
 use MongoDB\Model\SearchIndexInput;
 
+use function array_column;
 use function array_is_list;
-use function array_map;
 use function current;
 use function MongoDB\is_document;
 use function sprintf;
@@ -39,17 +39,10 @@
  */
 class CreateSearchIndexes implements Executable
 {
-    /** @var string */
-    private $databaseName;
-
-    /** @var string */
-    private $collectionName;
-
-    /** @var array */
-    private $indexes = [];
-
-    /** @var array */
-    private $options;
+    private string $databaseName;
+    private string $collectionName;
+    private array $indexes = [];
+    private array $options;
 
     /**
      * Constructs a createSearchIndexes command.
@@ -105,8 +98,6 @@ public function execute(Server $server): array
         /** @var object{indexesCreated: list<object{name: string}>} $result */
         $result = current($cursor->toArray());
 
-        return array_map(function ($index) {
-            return $index->name;
-        }, $result->indexesCreated);
+        return array_column($result->indexesCreated, 'name');
     }
 }

src/Operation/DropSearchIndex.php

@@ -31,17 +31,10 @@
  */
 class DropSearchIndex implements Executable
 {
-    /** @var string */
-    private $databaseName;
-
-    /** @var string */
-    private $collectionName;
-
-    /** @var string */
-    private $name;
-
-    /** @var array */
-    private $options;
+    private string $databaseName;
+    private string $collectionName;
+    private string $name;
+    private array $options;
 
     /**
      * Constructs a dropSearchIndex command.

src/Operation/ListSearchIndexes.php

@@ -37,20 +37,11 @@
  */
 class ListSearchIndexes implements Executable
 {
-    /** @var string */
-    private $databaseName;
-
-    /** @var string */
-    private $collectionName;
-
-    /** @var array */
-    private $listSearchIndexesOptions;
-
-    /** @var array */
-    private $aggregateOptions;
-
-    /** @var Aggregate */
-    private $aggregate;
+    private string $databaseName;
+    private string $collectionName;
+    private array $listSearchIndexesOptions;
+    private array $aggregateOptions;
+    private Aggregate $aggregate;
 
     /**
      * Constructs an aggregate command for listing Atlas Search indexes

src/Operation/UpdateSearchIndex.php

@@ -23,6 +23,7 @@
 use MongoDB\Exception\InvalidArgumentException;
 use MongoDB\Exception\UnsupportedException;
 
+use function MongoDB\document_to_array;
 use function MongoDB\is_document;
 
 /**
@@ -33,20 +34,11 @@
  */
 class UpdateSearchIndex implements Executable
 {
-    /** @var string */
-    private $databaseName;
-
-    /** @var string */
-    private $collectionName;
-
-    /** @var string */
-    private $name;
-
-    /** @var array|object */
-    private $definition;
-
-    /** @var array */
-    private $options = [];
+    private string $databaseName;
+    private string $collectionName;
+    private string $name;
+    private array $definition;
+    private array $options = [];
 
     /**
      * Constructs a createSearchIndexes command.
@@ -71,7 +63,7 @@ public function __construct(string $databaseName, string $collectionName, string
         $this->databaseName = $databaseName;
         $this->collectionName = $collectionName;
         $this->name = $name;
-        $this->definition = $definition;
+        $this->definition = document_to_array($definition);
         $this->options = $options;
     }