Disable fail points after tests

Author: jmikola

tests/UnifiedSpecTests/Context.php

@@ -10,6 +10,7 @@
 use stdClass;
 use function array_key_exists;
 use function assertArrayHasKey;
+use function assertContains;
 use function assertCount;
 use function assertInternalType;
 use function assertNotEmpty;
@@ -413,6 +414,6 @@ private static function requireMultipleMongoses(string $uri)
             return;
         }
 
-        assertStringContains(',', parse_url($uri, PHP_URL_HOST));
+        assertContains(',', parse_url($uri, PHP_URL_HOST));
     }
 }

tests/UnifiedSpecTests/FailPointObserver.php

@@ -0,0 +1,69 @@
+<?php
+
+namespace MongoDB\Tests\UnifiedSpecTests;
+
+use MongoDB\Driver\Monitoring\CommandFailedEvent;
+use MongoDB\Driver\Monitoring\CommandStartedEvent;
+use MongoDB\Driver\Monitoring\CommandSubscriber;
+use MongoDB\Driver\Monitoring\CommandSucceededEvent;
+use MongoDB\Operation\DatabaseCommand;
+use function MongoDB\Driver\Monitoring\addSubscriber;
+use function MongoDB\Driver\Monitoring\removeSubscriber;
+
+class FailPointObserver implements CommandSubscriber
+{
+    /** @var array */
+    private $failPointsAndServers = [];
+
+    /**
+     * @see https://www.php.net/manual/en/mongodb-driver-monitoring-commandsubscriber.commandfailed.php
+     */
+    public function commandFailed(CommandFailedEvent $event)
+    {
+    }
+
+    /**
+     * @see https://www.php.net/manual/en/mongodb-driver-monitoring-commandsubscriber.commandstarted.php
+     */
+    public function commandStarted(CommandStartedEvent $event)
+    {
+        $command = $event->getCommand();
+
+        if (! isset($command->configureFailPoint)) {
+            return;
+        }
+
+        if (isset($command->mode) && $command->mode === 'off') {
+            return;
+        }
+
+        $this->failPointsAndServers[] = [$command->configureFailPoint, $event->getServer()];
+    }
+
+    /**
+     * @see https://www.php.net/manual/en/mongodb-driver-monitoring-commandsubscriber.commandsucceeded.php
+     */
+    public function commandSucceeded(CommandSucceededEvent $event)
+    {
+    }
+
+    public function disableFailPoints()
+    {
+        foreach ($this->failPointsAndServers as list($failPoint, $server)) {
+            $operation = new DatabaseCommand('admin', ['configureFailPoint' => $failPoint, 'mode' => 'off']);
+            $operation->execute($server);
+        }
+
+        $this->failPointsAndServers = [];
+    }
+
+    public function start()
+    {
+        addSubscriber($this);
+    }
+
+    public function stop()
+    {
+        removeSubscriber($this);
+    }
+}

tests/UnifiedSpecTests/UnifiedSpecTest.php

@@ -38,17 +38,25 @@ class UnifiedSpecTest extends FunctionalTestCase
     /** @var MongoDB\Client */
     private static $internalClient;
 
+    /** @var FailPointObserver */
+    private $failPointObserver;
+
     private static function doSetUpBeforeClass()
     {
         parent::setUpBeforeClass();
 
+        /* TODO: FunctionalTestCase::getUri() restricts to a single mongos by
+         * default. Determine if there's a need to override that. */
         self::$internalClient = new Client(static::getUri());
         self::killAllSessions();
     }
 
     private function doSetUp()
     {
         parent::setUp();
+
+        $this->failPointObserver = new FailPointObserver();
+        $this->failPointObserver->start();
     }
 
     private function doTearDown()
@@ -57,6 +65,9 @@ private function doTearDown()
             self::killAllSessions();
         }
 
+        $this->failPointObserver->stop();
+        $this->failPointObserver->disableFailPoints();
+
         parent::tearDown();
     }
 
@@ -87,7 +98,8 @@ public function testPassingTests(stdClass $test, string $schemaVersion, array $r
             $this->prepareInitialData($initialData);
         }
 
-        $context = new Context(self::$internalClient, static::getUri());
+        // Give Context unmodified URI so it can enforce useMultipleMongoses
+        $context = new Context(self::$internalClient, static::getUri(true));
 
         if (isset($createEntities)) {
             $context->createEntities($createEntities);