Move pedantic method declaration test to its own file

Related to: 495e46d

Author: jmikola

tests/CollectionTest.php

@@ -44,28 +44,5 @@ function testInsertAndRetrieve() {
         }
         $this->assertEquals(0, $n);
     }
-
-    public function testMethodOrder()
-    {
-        $class = new ReflectionClass('MongoDB\Collection');
-
-        $filters = array(
-            'public' => ReflectionMethod::IS_PUBLIC,
-            'protected' => ReflectionMethod::IS_PROTECTED,
-            'private' => ReflectionMethod::IS_PRIVATE,
-        );
-
-        foreach ($filters as $visibility => $filter) {
-            $methods = array_map(
-                function(ReflectionMethod $method) { return $method->getName(); },
-                $class->getMethods($filter)
-            );
-
-            $sortedMethods = $methods;
-            sort($sortedMethods);
-
-            $this->assertEquals($methods, $sortedMethods, sprintf('%s methods are declared alphabetically', ucfirst($visibility)));
-        }
-    }
 }
 

tests/PedantryTest.php

@@ -0,0 +1,60 @@
+<?php
+
+namespace MongoDB\Tests;
+
+use RecursiveDirectoryIterator;
+use RecursiveIteratorIterator;
+use ReflectionClass;
+use ReflectionMethod;
+use RegexIterator;
+
+/**
+ * Pedantic tests that have nothing to do with functional correctness.
+ */
+class PedantryTest extends \PHPUnit_Framework_TestCase
+{
+    /**
+     * @dataProvider provideProjectClassNames
+     */
+    public function testMethodsAreOrderedAlphabeticallyByVisibility($className)
+    {
+        $class = new ReflectionClass($className);
+        $methods = $class->getMethods();
+
+        $getSortValue = function(ReflectionMethod $method) {
+            if ($method->getModifiers() & ReflectionMethod::IS_PRIVATE) {
+                return '2' . $method->getName();
+            }
+            if ($method->getModifiers() & ReflectionMethod::IS_PROTECTED) {
+                return '1' . $method->getName();
+            }
+            if ($method->getModifiers() & ReflectionMethod::IS_PUBLIC) {
+                return '0' . $method->getName();
+            }
+        };
+
+        $sortedMethods = $methods;
+        usort(
+            $sortedMethods,
+            function(ReflectionMethod $a, ReflectionMethod $b) use ($getSortValue) {
+                return strcasecmp($getSortValue($a), $getSortValue($b));
+            }
+        );
+
+        $this->assertEquals($sortedMethods, $methods);
+    }
+
+    public function provideProjectClassNames()
+    {
+        $classNames = array();
+        $srcDir = realpath(__DIR__ . '/../src/');
+
+        $files = new RegexIterator(new RecursiveIteratorIterator(new RecursiveDirectoryIterator($srcDir)), '/\.php$/i');
+
+        foreach ($files as $file) {
+            $classNames[][] = 'MongoDB\\' . str_replace(DIRECTORY_SEPARATOR, '\\', substr($file->getRealPath(), strlen($srcDir) + 1, -4));
+        }
+
+        return $classNames;
+    }
+}