Remove early returns for failed tests from tearDown methods (#1071)

Author: GromNaN

tests/Collection/FunctionalTestCase.php

@@ -24,12 +24,10 @@ public function setUp(): void
 
     public function tearDown(): void
     {
-        if ($this->hasFailed()) {
-            return;
+        if (! $this->hasFailed()) {
+            $this->dropCollection();
         }
 
-        $this->dropCollection();
-
         parent::tearDown();
     }
 }

tests/DocumentationExamplesTest.php

@@ -40,12 +40,10 @@ public function setUp(): void
 
     public function tearDown(): void
     {
-        if ($this->hasFailed()) {
-            return;
+        if (! $this->hasFailed()) {
+            $this->dropCollection();
         }
 
-        $this->dropCollection();
-
         parent::tearDown();
     }
 

tests/Model/IndexInfoFunctionalTest.php

@@ -20,12 +20,10 @@ public function setUp(): void
 
     public function tearDown(): void
     {
-        if ($this->hasFailed()) {
-            return;
+        if (! $this->hasFailed()) {
+            $this->collection->drop();
         }
 
-        $this->collection->drop();
-
         parent::tearDown();
     }
 

tests/Operation/FunctionalTestCase.php

@@ -20,12 +20,10 @@ public function setUp(): void
 
     public function tearDown(): void
     {
-        if ($this->hasFailed()) {
-            return;
+        if (! $this->hasFailed()) {
+            $this->dropCollection();
         }
 
-        $this->dropCollection();
-
         parent::tearDown();
     }
 

tests/Operation/RenameCollectionFunctionalTest.php

@@ -31,13 +31,11 @@ public function setUp(): void
 
     public function tearDown(): void
     {
-        if ($this->hasFailed()) {
-            return;
+        if (! $this->hasFailed()) {
+            $operation = new DropCollection($this->getDatabaseName(), $this->toCollectionName);
+            $operation->execute($this->getPrimaryServer());
         }
 
-        $operation = new DropCollection($this->getDatabaseName(), $this->toCollectionName);
-        $operation->execute($this->getPrimaryServer());
-
         parent::tearDown();
     }