Clarify removal requirement for return type checks

alcaeus · alcaeus · commit fe6bba101e0e · 2024-09-05T13:26:20.000+02:00
diff --git a/src/phongo_bson_encode.c b/src/phongo_bson_encode.c
@@ -93,7 +93,7 @@ static int php_phongo_is_array_or_document(zval* val)
 /* Checks the return type of a bsonSerialize() method. Returns true on
  * success; otherwise, throws an exception and returns false.
  *
- * TODO: obsolete once PHP 8.0+ is required and tentative return type is enforced.
+ * TODO: obsolete once the tentative return type in Serializable::bsonSerialize is enforced.
  */
 static inline bool phongo_check_bson_serialize_return_type(zval* retval, zend_class_entry* ce)
 {

Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@ static int php_phongo_is_array_or_document(zval* val)`
`93`	`93`	`/* Checks the return type of a bsonSerialize() method. Returns true on`
`94`	`94`	`* success; otherwise, throws an exception and returns false.`
`95`	`95`	`*`
`96`		`- * TODO: obsolete once PHP 8.0+ is required and tentative return type is enforced.`
	`96`	`+ * TODO: obsolete once the tentative return type in Serializable::bsonSerialize is enforced.`
`97`	`97`	`*/`
`98`	`98`	`static inline bool phongo_check_bson_serialize_return_type(zval* retval, zend_class_entry* ce)`
`99`	`99`	`{`