Added todo to remove obsolete type check

alcaeus · alcaeus · commit 8622a865e6a6 · 2023-08-01T09:47:22.000+02:00
diff --git a/src/phongo_bson_encode.c b/src/phongo_bson_encode.c
@@ -131,6 +131,7 @@ static void php_phongo_bson_append_object(bson_t* bson, php_phongo_field_path* f
 				return;
 			}
 
+			// TODO PHP_VERSION_ID < 80000: obsolete once the tentative return type of bsonSerialize() is enforced
 			if (
 				Z_TYPE(obj_data) != IS_ARRAY && !(Z_TYPE(obj_data) == IS_OBJECT && (instanceof_function(Z_OBJCE(obj_data), zend_standard_class_def) || instanceof_function(Z_OBJCE(obj_data), php_phongo_document_ce) || instanceof_function(Z_OBJCE(obj_data), php_phongo_packedarray_ce)))) {
 				phongo_throw_exception(PHONGO_ERROR_UNEXPECTED_VALUE,

Original file line number	Diff line number	Diff line change
`@@ -131,6 +131,7 @@ static void php_phongo_bson_append_object(bson_t* bson, php_phongo_field_path* f`
`131`	`131`	`return;`
`132`	`132`	`}`
`133`	`133`
	`134`	`+ // TODO PHP_VERSION_ID < 80000: obsolete once the tentative return type of bsonSerialize() is enforced`
`134`	`135`	`if (`
`135`	`136`	`Z_TYPE(obj_data) != IS_ARRAY && !(Z_TYPE(obj_data) == IS_OBJECT && (instanceof_function(Z_OBJCE(obj_data), zend_standard_class_def) \|\| instanceof_function(Z_OBJCE(obj_data), php_phongo_document_ce) \|\| instanceof_function(Z_OBJCE(obj_data), php_phongo_packedarray_ce)))) {`
`136`	`137`	`phongo_throw_exception(PHONGO_ERROR_UNEXPECTED_VALUE,`