Skip to content

Commit 04fc88c

Browse files
committed
Simplify switch and fix cast in php_array_api
1 parent 18432ad commit 04fc88c

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

src/contrib/php_array_api.h

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -172,15 +172,14 @@ static inline
172172
zval *php_array_fetchz(zval *zarr, zval *key) {
173173
switch (Z_TYPE_P(key)) {
174174
case IS_NULL:
175-
return php_array_fetchn(zarr, 0);
176175
case IS_FALSE:
177176
return php_array_fetchn(zarr, 0);
178177
case IS_TRUE:
179178
return php_array_fetchn(zarr, 1);
180179
case IS_LONG:
181180
return php_array_fetchn(zarr, Z_LVAL_P(key));
182181
case IS_DOUBLE:
183-
return php_array_fetchn(zarr, (long)Z_DVAL_P(key));
182+
return php_array_fetchn(zarr, (zend_ulong) Z_DVAL_P(key));
184183
case IS_STRING:
185184
return php_array_fetchl(zarr, Z_STRVAL_P(key), Z_STRLEN_P(key));
186185
default:
@@ -465,8 +464,6 @@ void php_array_unsetl_safe(zval *zarr, const char *key, int key_len) {
465464
static inline void php_array_unsetz(zval *zarr, zval *key) {
466465
switch (Z_TYPE_P(key)) {
467466
case IS_NULL:
468-
zend_hash_index_del(Z_ARRVAL_P(zarr), 0);
469-
return;
470467
case IS_FALSE:
471468
zend_hash_index_del(Z_ARRVAL_P(zarr), 0);
472469
return;
@@ -477,7 +474,7 @@ static inline void php_array_unsetz(zval *zarr, zval *key) {
477474
zend_hash_index_del(Z_ARRVAL_P(zarr), Z_LVAL_P(key));
478475
return;
479476
case IS_DOUBLE:
480-
zend_hash_index_del(Z_ARRVAL_P(zarr), (long)Z_DVAL_P(key));
477+
zend_hash_index_del(Z_ARRVAL_P(zarr), (zend_ulong) Z_DVAL_P(key));
481478
break;
482479
case IS_STRING:
483480
php_array_unsetl(zarr, Z_STRVAL_P(key), Z_STRLEN_P(key));

0 commit comments

Comments
 (0)