Remove deprecated connection string option

JAVA-4144

Author: jyemin

driver-core/src/main/com/mongodb/ConnectionString.java

@@ -1018,17 +1018,6 @@ private Map<String, List<String>> parseOptions(final String optionsPart) {
                 LOGGER.warn("Uri option 'wtimeout' has been deprecated, use 'wtimeoutms' instead.");
             }
         }
-        String legacySecondaryOkOption = "slaveok";
-        // handle legacy secondary ok settings
-        String legacySecondaryOk = getLastValue(optionsMap, legacySecondaryOkOption);
-        if (legacySecondaryOk != null && !optionsMap.containsKey("readpreference")) {
-            String readPreference = Boolean.TRUE.equals(parseBoolean(legacySecondaryOk, legacySecondaryOkOption))
-                                    ? "secondaryPreferred" : "primary";
-            optionsMap.put("readpreference", singletonList(readPreference));
-            if (LOGGER.isWarnEnabled()) {
-                LOGGER.warn(format("Uri option '%s' has been deprecated, use 'readpreference' instead.", legacySecondaryOkOption));
-            }
-        }
         // handle legacy j settings
         if (optionsMap.containsKey("j") && !optionsMap.containsKey("journal")) {
             optionsMap.put("journal", optionsMap.remove("j"));

driver-core/src/test/unit/com/mongodb/ConnectionStringSpecification.groovy

@@ -604,8 +604,6 @@ class ConnectionStringSpecification extends Specification {
         thrown(IllegalArgumentException)
     }
 
-    private static final LEGACY_SECONDARY_OK = 'slaveOk'
-
     @Unroll
     def 'should correct parse read preference for #readPreference'() {
         expect:
@@ -620,9 +618,6 @@ class ConnectionStringSpecification extends Specification {
                 '?readPreference=secondary')                             | secondary()
         new ConnectionString('mongodb://localhost/' +
                                    '?readPreference=secondaryPreferred') | secondaryPreferred()
-        new ConnectionString("mongodb://localhost/?${LEGACY_SECONDARY_OK}=true")  | secondaryPreferred()
-        new ConnectionString("mongodb://localhost/?${LEGACY_SECONDARY_OK}=false") | primary()
-        new ConnectionString("mongodb://localhost/?${LEGACY_SECONDARY_OK}=foo")   | primary()
         new ConnectionString('mongodb://localhost/' +
                                    '?readPreference=secondaryPreferred' +
                                    '&readPreferenceTags=dc:ny,rack:1' +

driver-legacy/src/test/unit/com/mongodb/MongoClientURISpecification.groovy

@@ -422,7 +422,7 @@ class MongoClientURISpecification extends Specification {
                                                         + 'minPoolSize=7;maxIdleTimeMS=1000;maxLifeTimeMS=2000;maxConnecting=1;'
                                                         + 'replicaSet=test;'
                                                         + 'connectTimeoutMS=2500;socketTimeoutMS=5500;autoConnectRetry=true;'
-                                                        + 'slaveOk=true;safe=false;w=1;wtimeout=2600')
+                                                        + 'readPreference=secondaryPreferred;safe=false;w=1;wtimeout=2600')
 
         MongoClientOptions.Builder builder = MongoClientOptions.builder()
                                                                .connectionsPerHost(10)