Skip to content

Commit 20602e0

Browse files
committed
All MongoExecutionTimeoutException as a timeout error until JAVA-5248 is done
1 parent de20b3c commit 20602e0

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

driver-core/src/main/com/mongodb/internal/connection/ProtocolHelper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@ public static MongoException createSpecialException(@Nullable final BsonDocument
246246
int errorCode = getErrorCode(response);
247247
String errorMessage = getErrorMessage(response, errorMessageFieldName);
248248
if (ErrorCategory.fromErrorCode(errorCode) == ErrorCategory.EXECUTION_TIMEOUT) {
249-
//TODO JAVA-5248 when timeoutMS is set, MongoOperationTimeoutException should be thrown.
249+
// TODO (CSOT) JAVA-5248 when timeoutMS is set, MongoOperationTimeoutException should be thrown.
250250
return new MongoExecutionTimeoutException(errorCode, errorMessage, response);
251251
} else if (isNodeIsRecoveringError(errorCode, errorMessage)) {
252252
return new MongoNodeIsRecoveringException(response, serverAddress);

driver-sync/src/test/functional/com/mongodb/client/unified/ErrorMatcher.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import com.mongodb.MongoClientException;
2121
import com.mongodb.MongoCommandException;
2222
import com.mongodb.MongoException;
23+
import com.mongodb.MongoExecutionTimeoutException;
2324
import com.mongodb.MongoOperationTimeoutException;
2425
import com.mongodb.MongoServerException;
2526
import com.mongodb.MongoSocketException;
@@ -66,9 +67,10 @@ void assertErrorsMatch(final BsonDocument expectedError, final Exception e) {
6667
}
6768

6869
if (expectedError.containsKey("isTimeoutError")) {
70+
// TODO (CSOT) JAVA-5248 Should only be MongoOperationTimeoutException.
6971
assertEquals(context.getMessage("Exception must be of type MongoOperationTimeoutException when checking for results"),
7072
expectedError.getBoolean("isTimeoutError").getValue(),
71-
e instanceof MongoOperationTimeoutException);
73+
e instanceof MongoOperationTimeoutException || e instanceof MongoExecutionTimeoutException);
7274
}
7375

7476
if (expectedError.containsKey("errorContains")) {

0 commit comments

Comments
 (0)