CSHARP-1252: write exceptions now have more complete messages.

Author: craiggwilson

src/MongoDB.Driver.Core/Core/Operations/MongoBulkWriteOperationException.cs

@@ -18,6 +18,7 @@
 using System.Collections.ObjectModel;
 using System.Linq;
 using System.Runtime.Serialization;
+using System.Text;
 using MongoDB.Driver.Core.Connections;
 
 namespace MongoDB.Driver.Core.Operations
@@ -49,7 +50,7 @@ public MongoBulkWriteOperationException(
             IReadOnlyList<BulkWriteOperationError> writeErrors,
             BulkWriteConcernError writeConcernError,
             IReadOnlyList<WriteRequest> unprocessedRequests)
-            : base(connectionId, "A bulk write operation resulted in one or more errors.")
+            : base(connectionId, FormatMessage(writeErrors, writeConcernError))
         {
             _result = result;
             _writeErrors = writeErrors;
@@ -124,5 +125,23 @@ public override void GetObjectData(SerializationInfo info, StreamingContext cont
             info.AddValue("_writeConcernError", _writeConcernError);
             info.AddValue("_writeErrors", _writeErrors);
         }
+
+        private static string FormatMessage(IReadOnlyList<BulkWriteOperationError> writeErrors, BulkWriteConcernError writeConcernError)
+        {
+            var sb = new StringBuilder("A bulk write operation resulted in one or more errors.");
+            if (writeErrors != null)
+            {
+                foreach (var writeError in writeErrors)
+                {
+                    sb.AppendLine().Append("  " + writeError.Message);
+                }
+            }
+            if (writeConcernError != null)
+            {
+                sb.AppendLine().Append("  " + writeConcernError.Message);
+            }
+
+            return sb.ToString();
+        }
     }
 }

src/MongoDB.Driver.Tests/MongoWriteExceptionTests.cs

@@ -52,7 +52,7 @@ public void constructor_should_initialize_subject()
 
             subject.ConnectionId.Should().Be(_connectionId);
             subject.InnerException.Should().Be(_innerException);
-            subject.Message.Should().Be("A write operation resulted in an error.");
+            subject.Message.Should().Be("A write operation resulted in an error." + Environment.NewLine + "  writeError" + Environment.NewLine + "  writeConcernError");
             subject.WriteConcernError.Should().Be(_writeConcernError);
             subject.WriteError.Should().Be(_writeError);
         }
@@ -72,7 +72,7 @@ public void FromBulkWriteException_should_return_expected_result()
 
             result.ConnectionId.Should().Be(_connectionId);
             result.InnerException.Should().BeSameAs(bulkWriteException);
-            result.Message.Should().Be("A write operation resulted in an error.");
+            result.Message.Should().Be("A write operation resulted in an error." + Environment.NewLine + "  message" + Environment.NewLine + "  message");
             result.WriteConcernError.Should().Be(writeConcernError);
             result.WriteError.Should().Be(writeErrors[0]);
         }

src/MongoDB.Driver/MongoBulkWriteException.cs

@@ -17,6 +17,7 @@
 using System.Collections.Generic;
 using System.Linq;
 using System.Runtime.Serialization;
+using System.Text;
 using MongoDB.Driver.Core.Connections;
 using MongoDB.Driver.Core.Operations;
 using MongoDB.Driver.Support;
@@ -43,7 +44,7 @@ public MongoBulkWriteException(
             ConnectionId connectionId,
             IEnumerable<BulkWriteError> writeErrors,
             WriteConcernError writeConcernError)
-            : base(connectionId, message: "A bulk write operation resulted in one or more errors.")
+            : base(connectionId, message: FormatMessage(writeErrors, writeConcernError))
         {
             _writeErrors = writeErrors.ToList();
             _writeConcernError = writeConcernError;
@@ -90,6 +91,25 @@ public override void GetObjectData(SerializationInfo info, StreamingContext cont
             info.AddValue("_writeConcernError", _writeConcernError);
             info.AddValue("_writeErrors", _writeErrors);
         }
+
+        // private static methods
+        private static string FormatMessage(IEnumerable<BulkWriteError> writeErrors, WriteConcernError writeConcernError)
+        {
+            var sb = new StringBuilder("A bulk write operation resulted in one or more errors.");
+            if (writeErrors != null)
+            {
+                foreach (var writeError in writeErrors)
+                {
+                    sb.AppendLine().Append("  " + writeError.Message);
+                }
+            }
+            if (writeConcernError != null)
+            {
+                sb.AppendLine().Append("  " + writeConcernError.Message);
+            }
+
+            return sb.ToString();
+        }
     }
 
     /// <summary>
@@ -114,7 +134,7 @@ public sealed class MongoBulkWriteException<TDocument> : MongoBulkWriteException
         /// <param name="unprocessedRequests">The unprocessed requests.</param>
         public MongoBulkWriteException(
             ConnectionId connectionId,
-            BulkWriteResult<TDocument> result, 
+            BulkWriteResult<TDocument> result,
             IEnumerable<BulkWriteError> writeErrors,
             WriteConcernError writeConcernError,
             IEnumerable<WriteModel<TDocument>> unprocessedRequests)

src/MongoDB.Driver/MongoWriteException.cs

@@ -15,6 +15,7 @@
 
 using System;
 using System.Runtime.Serialization;
+using System.Text;
 using MongoDB.Driver.Core.Connections;
 
 namespace MongoDB.Driver
@@ -52,7 +53,7 @@ public MongoWriteException(
             WriteError writeError,
             WriteConcernError writeConcernError,
             Exception innerException)
-            : base(connectionId, "A write operation resulted in an error.", innerException)
+            : base(connectionId, FormatMessage(writeError, writeConcernError), innerException)
         {
             _writeError = writeError;
             _writeConcernError = writeConcernError;
@@ -99,5 +100,21 @@ public override void GetObjectData(SerializationInfo info, StreamingContext cont
             info.AddValue("_writeConcernError", _writeConcernError);
             info.AddValue("_writeError", _writeError);
         }
+
+        // private static methods
+        private static string FormatMessage(WriteError writeError, WriteConcernError writeConcernError)
+        {
+            var sb = new StringBuilder("A write operation resulted in an error.");
+            if (writeError != null)
+            {
+                sb.AppendLine().Append("  " + writeError.Message);
+            }
+            if (writeConcernError != null)
+            {
+                sb.AppendLine().Append("  " + writeConcernError.Message);
+            }
+
+            return sb.ToString();
+        }
     }
 }