From 348f0c1bace83e6eb6f54b39127889211406bef5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9r=C3=B4me=20Tamarelle?= Date: Mon, 21 Aug 2023 11:53:15 +0200 Subject: [PATCH] Remove Eloquent\Builder::chunkById() already having the correct id field in laravel --- src/Eloquent/Builder.php | 8 -------- tests/ModelTest.php | 8 ++++---- 2 files changed, 4 insertions(+), 12 deletions(-) diff --git a/src/Eloquent/Builder.php b/src/Eloquent/Builder.php index 84e93b83f..61a9de4b1 100644 --- a/src/Eloquent/Builder.php +++ b/src/Eloquent/Builder.php @@ -153,14 +153,6 @@ public function decrement($column, $amount = 1, array $extra = []) return parent::decrement($column, $amount, $extra); } - /** - * @inheritdoc - */ - public function chunkById($count, callable $callback, $column = '_id', $alias = null) - { - return parent::chunkById($count, $callback, $column, $alias); - } - /** * @inheritdoc */ diff --git a/tests/ModelTest.php b/tests/ModelTest.php index 1042a07bc..1fe71f266 100644 --- a/tests/ModelTest.php +++ b/tests/ModelTest.php @@ -834,12 +834,12 @@ public function testChunkById(): void User::create(['name' => 'spork', 'tags' => ['sharp', 'pointy', 'round', 'bowl']]); User::create(['name' => 'spoon', 'tags' => ['round', 'bowl']]); - $count = 0; - User::chunkById(2, function (EloquentCollection $items) use (&$count) { - $count += count($items); + $names = []; + User::chunkById(2, function (EloquentCollection $items) use (&$names) { + $names = array_merge($names, $items->pluck('name')->all()); }); - $this->assertEquals(3, $count); + $this->assertEquals(['fork', 'spork', 'spoon'], $names); } public function testTruncateModel()