File tree 3 files changed +10
-5
lines changed
3 files changed +10
-5
lines changed Original file line number Diff line number Diff line change @@ -17,7 +17,7 @@ export const LogId = {
17
17
telemetryEmitFailure : mongoLogId ( 1_002_002 ) ,
18
18
telemetryEmitStart : mongoLogId ( 1_002_003 ) ,
19
19
telemetryEmitSuccess : mongoLogId ( 1_002_004 ) ,
20
- telemetryMachineIdFailure : mongoLogId ( 1_002_005 ) ,
20
+ telemetryDeviceIdFailure : mongoLogId ( 1_002_005 ) ,
21
21
22
22
toolExecute : mongoLogId ( 1_003_001 ) ,
23
23
toolExecuteFailure : mongoLogId ( 1_003_002 ) ,
Original file line number Diff line number Diff line change @@ -40,7 +40,12 @@ export class Telemetry {
40
40
41
41
private async start ( ) : Promise < void > {
42
42
this . deviceIdPromise = DeferredPromise . fromPromise ( this . getDeviceId ( ) ) ;
43
- this . commonProperties . device_id = await this . deviceIdPromise ;
43
+ try {
44
+ this . commonProperties . device_id = await this . deviceIdPromise ;
45
+ } catch ( error ) {
46
+ logger . debug ( LogId . telemetryDeviceIdFailure , "telemetry" , String ( error ) ) ;
47
+ this . commonProperties . device_id = "unknown" ;
48
+ }
44
49
45
50
this . isBufferingEvents = false ;
46
51
}
@@ -72,7 +77,7 @@ export class Telemetry {
72
77
hmac . update ( DEVICE_ID_HASH_MESSAGE ) ;
73
78
return hmac . digest ( "hex" ) ;
74
79
} catch ( error ) {
75
- logger . debug ( LogId . telemetryMachineIdFailure , "telemetry" , String ( error ) ) ;
80
+ logger . debug ( LogId . telemetryDeviceIdFailure , "telemetry" , String ( error ) ) ;
76
81
return "unknown" ;
77
82
}
78
83
}
Original file line number Diff line number Diff line change @@ -284,7 +284,7 @@ describe("Telemetry", () => {
284
284
expect ( telemetry . getCommonProperties ( ) . device_id ) . toBe ( "unknown" ) ;
285
285
286
286
expect ( loggerSpy ) . toHaveBeenCalledWith (
287
- LogId . telemetryMachineIdFailure ,
287
+ LogId . telemetryDeviceIdFailure ,
288
288
"telemetry" ,
289
289
"Error: Failed to get device ID"
290
290
) ;
@@ -315,7 +315,7 @@ describe("Telemetry", () => {
315
315
expect ( telemetry . getCommonProperties ( ) . device_id ) . toBe ( "unknown" ) ;
316
316
expect ( telemetry [ "isBufferingEvents" ] ) . toBe ( false ) ;
317
317
expect ( loggerSpy ) . toHaveBeenCalledWith (
318
- LogId . telemetryMachineIdFailure ,
318
+ LogId . telemetryDeviceIdFailure ,
319
319
"telemetry" ,
320
320
"Error: Promise timed out"
321
321
) ;
You can’t perform that action at this time.
0 commit comments