Skip to content

Commit 59c5705

Browse files
committed
chore: run on correct linux version
1 parent 2b1e462 commit 59c5705

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

.github/docker/Dockerfile.glibc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
FROM ubuntu:bionic AS build
1+
ARG UBUNTU_VERSION=bionic
2+
FROM ubuntu:${UBUNTU_VERSION} AS build
23

34
# Possible values: s390x, arm64, x64
45
ARG NODE_VERSION=16.20.1

.github/workflows/test.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ jobs:
4949
shell: bash
5050
run: |
5151
echo "version=$(node --print 'process.version.slice(1)')" >> "$GITHUB_OUTPUT"
52+
echo "ubuntu_version=$(node --print '(+process.version.slice(1).split(`.`).at(0)) > 16 ? `noble` : `bionic`')" >> "$GITHUB_OUTPUT"
5253
5354
- name: Set up QEMU
5455
uses: docker/setup-qemu-action@v3
@@ -61,8 +62,9 @@ jobs:
6162
docker buildx create --name builder --bootstrap --use
6263
docker buildx build \
6364
--platform linux/${{ matrix.linux_arch }} \
64-
--build-arg NODE_ARCH=${{ matrix.linux_arch == 'amd64' && 'x64' || matrix.linux_arch }} \
65-
--build-arg NODE_VERSION=${{ steps.get_nodejs_version.outputs.version }} \
65+
--build-arg="NODE_ARCH=${{ matrix.linux_arch == 'amd64' && 'x64' || matrix.linux_arch }}" \
66+
--build-arg="NODE_VERSION=${{ steps.get_nodejs_version.outputs.version }}" \
67+
--build-arg="UBUNTU_VERSION=${{ steps.get_nodejs_version.outputs.ubuntu_version }}" \
6668
--output type=local,dest=./prebuilds,platform-split=false \
6769
-f ./.github/docker/Dockerfile.glibc \
6870
.

0 commit comments

Comments
 (0)