Merge pull request #4 from module-federation/remove-basic-bootstrap

remove import bootstrap from apps that can support it

Author: ScriptedAlchemy

basic-host-remote/app1/src/bootstrap.js

@@ -1 +1,5 @@
-import("./bootstrap");
+import App from "./App";
+import React from "react";
+import ReactDOM from "react-dom";
+
+ReactDOM.render(<App />, document.getElementById("root"));

basic-host-remote/app1/src/index.js

@@ -1,3 +1,10 @@
+// have to have a promise (import()) somewhere for exposed code
+// you can either use import bootstrap, like i do here
+// or if you dont like import(bootstrap) you can get rid of that but need to import like
+
+// this like here: const LocalButton = React.lazy(()=>import('./Button'));
+// then you can remove the need for import(bootstrap)
+//https://github.com/webpack/webpack/issues/10352#issuecomment-622016042
 import LocalButton from "./Button";
 import React from "react";
 

basic-host-remote/app2/src/App.js

@@ -1 +1,2 @@
+// https://github.com/webpack/webpack/issues/10352#issuecomment-622016042
 import("./bootstrap");