Skip to content

Commit 5dba947

Browse files
committed
small fixes after suggested changes
1 parent c053c2e commit 5dba947

File tree

3 files changed

+3
-10
lines changed

3 files changed

+3
-10
lines changed

src/client/streamableHttp.test.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -169,11 +169,7 @@ describe("StreamableHTTPClientTransport", () => {
169169
headers: new Headers()
170170
});
171171

172-
// This should not throw an error
173-
await transport.terminateSession();
174-
175-
// The session ID should still be preserved since termination wasn't accepted
176-
expect(transport.sessionId).toBe("test-session-id");
172+
await expect(transport.terminateSession()).resolves.not.toThrow();
177173
});
178174

179175
it("should handle 404 response when session expires", async () => {

src/client/streamableHttp.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -505,10 +505,7 @@ export class StreamableHTTPClientTransport implements Transport {
505505
);
506506
}
507507

508-
// If session termination was successful, clear our session ID
509-
if (response.ok) {
510-
this._sessionId = undefined;
511-
}
508+
this._sessionId = undefined;
512509
} catch (error) {
513510
this.onerror?.(error as Error);
514511
throw error;

src/server/streamableHttp.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ export interface StreamableHTTPServerTransportOptions {
4242
/**
4343
* A callback for session initialization events
4444
* This is called when the server initializes a new session.
45-
* Usefult in cases when you need to register multiple mcp sessions
45+
* Useful in cases when you need to register multiple mcp sessions
4646
* and need to keep track of them.
4747
* @param sessionId The generated session ID
4848
*/

0 commit comments

Comments
 (0)