Refactor McpSession class for improved readability and maintainability

Tyler-R-Kendrick · Tyler-R-Kendrick · commit 4a70156f2de5 · 2025-04-08T14:07:44.000Z
diff --git a/src/ModelContextProtocol/Shared/McpSession.cs b/src/ModelContextProtocol/Shared/McpSession.cs
@@ -397,7 +397,11 @@ public async Task<JsonRpcResponse> SendRequestAsync(JsonRpcRequest request, Canc
         finally
         {
             _pendingRequests.TryRemove(request.Id, out _);
+#if NETSTANDARD2_0
+            registration.Dispose();
+#else
             await registration.DisposeAsync().ConfigureAwait(false);
+#endif
             FinalizeDiagnostics(activity, startingTimestamp, durationMetric, ref tags);
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -397,7 +397,11 @@ public async Task<JsonRpcResponse> SendRequestAsync(JsonRpcRequest request, Canc`
`397`	`397`	`finally`
`398`	`398`	`{`
`399`	`399`	`_pendingRequests.TryRemove(request.Id, out _);`
	`400`	`+#if NETSTANDARD2_0`
	`401`	`+ registration.Dispose();`
	`402`	`+#else`
`400`	`403`	`await registration.DisposeAsync().ConfigureAwait(false);`
	`404`	`+#endif`
`401`	`405`	`FinalizeDiagnostics(activity, startingTimestamp, durationMetric, ref tags);`
`402`	`406`	`}`
`403`	`407`	`}`