Add test to make sure bindings are working properly for multiple whereIn clauses

Author: mikebronner

src/CacheKey.php

@@ -6,7 +6,6 @@
 use Illuminate\Support\Arr;
 use Illuminate\Support\Collection;
 use Illuminate\Database\Query\Expression;
-use Illuminate\Database\Eloquent\Relations\HasMany;
 use Illuminate\Support\Str;
 
 class CacheKey

src/CacheTags.php

@@ -1,6 +1,5 @@
 <?php namespace GeneaLabs\LaravelModelCaching;
 
-use GeneaLabs\LaravelModelCaching\CachedBuilder;
 use GeneaLabs\LaravelModelCaching\Traits\CachePrefixing;
 use Illuminate\Database\Eloquent\Model;
 use Illuminate\Database\Eloquent\Relations\Relation;

tests/Integration/CachedBuilder/WhereInTest.php

@@ -1,5 +1,6 @@
 <?php namespace GeneaLabs\LaravelModelCaching\Tests\Integration\CachedBuilder;
 
+use GeneaLabs\LaravelModelCaching\Tests\Fixtures\Author;
 use GeneaLabs\LaravelModelCaching\Tests\Fixtures\Book;
 use GeneaLabs\LaravelModelCaching\Tests\Fixtures\UncachedAuthor;
 use GeneaLabs\LaravelModelCaching\Tests\Fixtures\UncachedBook;
@@ -32,29 +33,49 @@ public function testWhereInUsingCollectionQuery()
         $this->assertEquals($liveResults->pluck("id"), $cachedResults->pluck("id"));
     }
 
-    /** @group test */
     public function testWhereInWhenSetIsEmpty()
     {
-        $key = sha1('genealabs:laravel-model-caching:testing::memory::books:genealabslaravelmodelcachingtestsfixturesbook-author_id_in_1_2_3_4');
+        $key = sha1('genealabs:laravel-model-caching:testing::memory::authors:genealabslaravelmodelcachingtestsfixturesauthor-id_in_');
         $tags = [
-            'genealabs:laravel-model-caching:testing::memory::genealabslaravelmodelcachingtestsfixturesbook',
+            'genealabs:laravel-model-caching:testing::memory::genealabslaravelmodelcachingtestsfixturesauthor',
         ];
-        $authors = (new UncachedAuthor)
-            ->where("id", "<", 0)
-            ->get(["id"]);
+        $authors = (new Author)
+            ->whereIn("id", [])
+            ->get();
+        $cachedResults = $this
+            ->cache()
+            ->tags($tags)
+            ->get($key)['value'];
+        $liveResults = (new UncachedAuthor)
+            ->whereIn("id", [])
+            ->get();
 
-        $books = (new Book)
-            ->whereIn("author_id", $authors)
+        $this->assertEquals($liveResults->pluck("id"), $authors->pluck("id"));
+        $this->assertEquals($liveResults->pluck("id"), $cachedResults->pluck("id"));
+    }
+
+    public function testBindingsAreCorrectWithMultipleWhereInClauses()
+    {
+        $key = sha1('genealabs:laravel-model-caching:testing::memory::authors:genealabslaravelmodelcachingtestsfixturesauthor-name_in_John-id_in_-name_in_Mike');
+        $tags = [
+            'genealabs:laravel-model-caching:testing::memory::genealabslaravelmodelcachingtestsfixturesauthor',
+        ];
+        $authors = (new Author)
+            ->whereIn("name", ["John"])
+            ->whereIn("id", [])
+            ->whereIn("name", ["Mike"])
             ->get();
         $cachedResults = $this
             ->cache()
             ->tags($tags)
             ->get($key)['value'];
-        $liveResults = (new UncachedBook)
-            ->whereIn("author_id", $authors)
+        $liveResults = (new UncachedAuthor)
+            ->whereIn("name", ["Mike"])
+            ->whereIn("id", [])
+            ->whereIn("name", ["John"])
             ->get();
 
-        $this->assertEquals($liveResults->pluck("id"), $books->pluck("id"));
-        $this->assertNull($cachedResults);
+        $this->assertEquals($liveResults->pluck("id"), $authors->pluck("id"));
+        $this->assertEquals($liveResults->pluck("id"), $cachedResults->pluck("id"));
     }
 }