Add initial unit tests

Author: mikebronner

CONTRIBUTING.md

@@ -11,7 +11,7 @@ However, not every pull request will automatically be accepted. I will review ea
 ## Testing
 - [ ] After making your changes, make sure the tests still pass.
 - [ ] When adding new functionality, also add new tests.
-- [ ] Make sure there are no build errors on our CI server (https://ci.genealabs.com/build-status/view/7)
+- [ ] Make sure there are no build errors on our CI server (https://ci.genealabs.com/build-status/view/8)
 - [ ] All code must past PHPCS and PHPMD PSR2 validation.
 
 ## Submitting changes

composer.json

@@ -14,6 +14,7 @@
         "illuminate/database": "5.5.*"
     },
     "require-dev": {
+        "fzaninotto/faker": "~1.4",
         "laravel/laravel": "5.5.*",
         "mockery/mockery": "0.9.*",
         "phpmd/phpmd": "^2.6",
@@ -22,6 +23,9 @@
         "sebastian/phpcpd": "*"
     },
     "autoload": {
+        "classmap": [
+            "tests/database/factories"
+        ],
         "psr-4": {
             "GeneaLabs\\LaravelModelCaching\\": "src/",
             "GeneaLabs\\LaravelModelCaching\\Tests\\": "tests/"

src/Builder.php

@@ -11,10 +11,17 @@ protected function eagerLoadRelation(array $models, $name, Closure $constraints)
         $relation->addEagerConstraints($models);
         $constraints($relation);
 
+        $parentIds = implode('_', collect($models)->pluck('id')->toArray());
         $parentName = str_slug(get_class($relation->getParent()));
-        $childName = str_slug(get_class($relation->getModel()));
-        $results = cache()->tags([$parentName, $childName])
-            ->rememberForever("{$parentName}-{$childName}-relation", function () use ($relation) {
+        $childName = str_slug(get_class($relation->getRelated()));
+        $cache = cache();
+
+        if (is_subclass_of(cache()->getStore(), TaggableStore::class)) {
+            $cache->tags([$parentName, $childName]);
+        }
+
+        $results = $cache
+            ->rememberForever("{$parentName}_{$parentIds}-{$childName}s", function () use ($relation) {
                 return $relation->getEager();
             });
 

tests/CreatesApplication.php

@@ -1,13 +1,18 @@
 <?php namespace GeneaLabs\LaravelModelCaching\Tests;
 
 use Illuminate\Contracts\Console\Kernel;
+use Illuminate\Database\Eloquent\Factory;
 
 trait CreatesApplication
 {
     public function createApplication()
     {
         $app = require __DIR__ . '/../vendor/laravel/laravel/bootstrap/app.php';
         $app->make(Kernel::class)->bootstrap();
+        $app->make(Factory::class)->load(__DIR__ . '/database/factories');
+        $app->afterResolving('migrator', function ($migrator) {
+            $migrator->path(__DIR__ . '/database/migrations');
+        });
 
         return $app;
     }

tests/Fixtures/Author.php

@@ -0,0 +1,17 @@
+<?php namespace GeneaLabs\LaravelModelCaching\Tests\Fixtures;
+
+use GeneaLabs\LaravelModelCaching\CachedModel;
+use Illuminate\Database\Eloquent\Relations\HasMany;
+
+class Author extends CachedModel
+{
+    protected $fillable = [
+        'name',
+        'email',
+    ];
+
+    public function books() : HasMany
+    {
+        return $this->hasMany(Book::class);
+    }
+}

tests/Fixtures/Book.php

@@ -0,0 +1,21 @@
+<?php namespace GeneaLabs\LaravelModelCaching\Tests\Fixtures;
+
+use GeneaLabs\LaravelModelCaching\CachedModel;
+use Illuminate\Database\Eloquent\Relations\BelongsTo;
+
+class Book extends CachedModel
+{
+    protected $dates = [
+        'published_at',
+    ];
+    protected $fillable = [
+        'description',
+        'published_at',
+        'title',
+    ];
+
+    public function author() : BelongsTo
+    {
+        return $this->belongsTo(Author::class);
+    }
+}

tests/Unit/CacheTest.php

@@ -1,12 +1,37 @@
 <?php namespace GeneaLabs\LaravelModelCaching\Tests\Unit;
 
+use GeneaLabs\LaravelModelCaching\Tests\Fixtures\Author;
+use GeneaLabs\LaravelModelCaching\Tests\Fixtures\Book;
 use GeneaLabs\LaravelModelCaching\Tests\TestCase;
+use Illuminate\Foundation\Testing\RefreshDatabase;
 
 class CacheTest extends TestCase
 {
-    public function testExample()
+    use RefreshDatabase;
+
+    public function setUp()
+    {
+        parent::setUp();
+
+        factory(Author::class, 10)->create()
+            ->each(function($author) {
+                factory(Book::class, random_int(2, 10))->make()
+                    ->each(function ($book) use ($author) {
+                        $book->author()->associate($author);
+                        $book->save();
+                    });
+            });
+    }
+
+    public function testCacheIsEmptyBeforeLoadingModels()
     {
-        //TODO: add initial test
-        $this->assertTrue(true);
+        $this->assertNull(cache()->get('genealabslaravelmodelcachingtestsfixturesauthor_1_2_3_4_5_6_7_8_9_10-genealabslaravelmodelcachingtestsfixturesbooks'));
+    }
+
+    public function testCacheIsNotEmptyAfterLoadingModels()
+    {
+        (new Author)->with('books')->get();
+
+        $this->assertNotNull(cache()->get('genealabslaravelmodelcachingtestsfixturesauthor_1_2_3_4_5_6_7_8_9_10-genealabslaravelmodelcachingtestsfixturesbooks'));
     }
 }

tests/database/factories/AuthorFactory.php

@@ -0,0 +1,11 @@
+<?php
+
+use Faker\Generator as Faker;
+use GeneaLabs\LaravelModelCaching\Tests\Fixtures\Author;
+
+$factory->define(Author::class, function (Faker $faker) {
+    return [
+        'name' => $faker->name,
+        'email' => $faker->unique()->safeEmail,
+    ];
+});

tests/database/factories/BookFactory.php

@@ -0,0 +1,12 @@
+<?php
+
+use Faker\Generator as Faker;
+use GeneaLabs\LaravelModelCaching\Tests\Fixtures\Book;
+
+$factory->define(Book::class, function (Faker $faker) {
+    return [
+        'title' => $faker->title,
+        'description' => $faker->paragraphs(3, true),
+        'published_at' => $faker->dateTime,
+    ];
+});

tests/database/migrations/2017_09_21_010055_create_authors.php

@@ -0,0 +1,23 @@
+<?php
+
+use Illuminate\Database\Schema\Blueprint;
+use Illuminate\Database\Migrations\Migration;
+
+class CreateAuthors extends Migration
+{
+    public function up()
+    {
+        Schema::create('authors', function (Blueprint $table) {
+            $table->increments('id');
+            $table->timestamps();
+
+            $table->string('email');
+            $table->string('name');
+        });
+    }
+
+    public function down()
+    {
+        //
+    }
+}

tests/database/migrations/2017_09_21_010109_create_books.php

@@ -0,0 +1,25 @@
+<?php
+
+use Illuminate\Database\Schema\Blueprint;
+use Illuminate\Database\Migrations\Migration;
+
+class CreateBooks extends Migration
+{
+    public function up()
+    {
+        Schema::create('books', function (Blueprint $table) {
+            $table->increments('id');
+            $table->unsignedInteger('author_id');
+            $table->timestamps();
+
+            $table->text('description');
+            $table->dateTime('published_at');
+            $table->string('title');
+        });
+    }
+
+    public function down()
+    {
+        //
+    }
+}