Merge pull request #2882 from microsoftgraph/update-main-01-08-2024

Merge to main

Author: timayabi2020

.azure-pipelines/ci-build.yml

@@ -42,7 +42,7 @@ jobs:
           git submodule update --init --recursive
       - template: ./common-templates/install-tools.yml
       - template: ./common-templates/security-pre-checks.yml
-
+      
       - template: ./generation-templates/authentication-module.yml
         parameters:
           Test: ${{ parameters.Test }}

.azure-pipelines/common-templates/download-openapi-docs.yml

@@ -92,6 +92,24 @@ steps:
       script: |
         . "$(System.DefaultWorkingDirectory)\tools\Versions\BumpModuleVersion.ps1" -BumpV1Module -BumpBetaModule -BumpAuthModule -Debug
 
+  - task: PowerShell@2
+    name: BuildOpenApiMetadataDetectionTool
+    displayName: Build tool for detecting metadata changes
+    inputs:
+      pwsh: true
+      targetType: inline
+      script: dotnet build --configuration Release
+      workingDirectory: "$(System.DefaultWorkingDirectory)/tools/OpenApiInfoGenerator/OpenApiInfoGenerator"
+
+  - task: PowerShell@2
+    name: GenerateOpenApiErrorAndInfoFiles
+    displayName: Generate OpenApi error and info file for detecting unnecessary changes that would lead to a breaking change
+    inputs:
+      pwsh: true
+      targetType: inline
+      script: dotnet run
+      workingDirectory: "$(System.DefaultWorkingDirectory)/tools/OpenApiInfoGenerator/OpenApiInfoGenerator"
+
   - task: Bash@3
     displayName: Commit downloaded files
     condition: and(succeeded(), ne(variables['OpenAPIDocDiff.ModulesWithChanges'], ''))

.azure-pipelines/common-templates/install-tools.yml

@@ -12,6 +12,12 @@ steps:
     inputs:
       debugMode: false
       version: 7.x
+  
+  - task: UseDotNet@2
+    displayName: Use .NET SDK
+    inputs:
+      debugMode: false
+      version: 8.x
 
   - task: NuGetToolInstaller@1
     displayName: Install Nuget

.azure-pipelines/config/credscan/credscan-suppressions.json

@@ -38,16 +38,23 @@
       "file": [
         "src\\Users.Actions\\beta\\examples\\Test-MgBetaUserPassword.md",
         "src\\Users.Actions\\beta\\examples\\Update-MgBetaUserPassword.md",
+        "src\\Users.Actions\\beta\\examples\\Reset-MgBetaUserAuthenticationMethodPassword.md",
         "src\\Users.Actions\\v1.0\\examples\\Update-MgUserPassword.md"
       ],
       "_justification": "[Users.Actions] Examples contain random values recognized as secret"
     },
     {
       "file": [
-        "src\\DeviceManagement.Actions\\beta\\examples\\Update-MgBetaDeviceManagementVirtualEndpointOnPremisConnectionAdDomainPassword.md"
+        "src\\DeviceManagement.Actions\\beta\\examples\\Update-MgBetaDeviceManagementVirtualEndpointOnPremiseConnectionAdDomainPassword.md"
       ],
       "_justification": "[DeviceManagement.Actions] Examples contain random values recognized as secret"
     },
+    {
+      "file": [
+        "src\\Users.Actions\\v1.0\\examples\\Reset-MgUserAuthenticationMethodPassword.md"
+      ],
+      "_justification": "[Users.Actions] Examples contain random values recognized as secret"
+    },
     {
       "file": [
         "tools\\Tests\\loadEnv.md"

.azure-pipelines/generation-templates/check-openapi-errors.yml

@@ -0,0 +1,10 @@
+# Copyright (c) Microsoft Corporation. All rights reserved.
+# Licensed under the MIT License.
+steps:
+  - task: PowerShell@2
+    displayName: Check for OpenAPI Errors
+    inputs:
+      targetType: inline
+      pwsh: true
+      script: |
+        . $(System.DefaultWorkingDirectory)/tools/OpenApiInfoGenerator/OpenApiInfoGenerator/OpenApiChanges.ps1

.github/ISSUE_TEMPLATE/03-blank-issue.md

@@ -1,4 +1,4 @@
-blank_issues_enabled: true
+blank_issues_enabled: false
 contact_links:
   - name: For issues related to authentication and service errors
     url: https://learn.microsoft.com/powershell/microsoftgraph/troubleshooting

.github/ISSUE_TEMPLATE/config.yml

@@ -9,4 +9,11 @@ updates:
     directory: "/"
     schedule:
       interval: "daily"
+    open-pull-requests-limit: 1
+  - package-ecosystem: "nuget"
+    directory: "/src/Authentication/Authentication.Test"
+    schedule:
+      interval: "daily"
+    allow:
+      - dependency-name: "Moq"
     open-pull-requests-limit: 1

.github/dependabot.yml

@@ -1,22 +1,22 @@
-id: 
+id:
 name: GitOps.PullRequestIssueManagement
 description: GitOps.PullRequestIssueManagement primitive
-owner: 
+owner:
 resource: repository
 disabled: false
-where: 
+where:
 configuration:
   resourceManagementConfiguration:
     scheduledSearches:
-    - description: 
+    - description:
       frequencies:
       - hourly:
           hour: 1
       filters:
       - isIssue
       - isOpen
       - hasLabel:
-          label: 'Needs: Author Feedback'
+          label: 'status:waiting-for-author-feedback'
       - hasLabel:
           label: no-recent-activity
       - noActivitySince:
@@ -25,15 +25,15 @@ configuration:
           label: service bug
       actions:
       - closeIssue
-    - description: 
+    - description:
       frequencies:
       - hourly:
           hour: 1
       filters:
       - isIssue
       - isOpen
       - hasLabel:
-          label: 'Needs: Author Feedback'
+          label: 'status:waiting-for-author-feedback'
       - noActivitySince:
           days: 4
       - isNotLabeledWith:
@@ -43,7 +43,7 @@ configuration:
           label: no-recent-activity
       - addReply:
           reply: This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for **4 days**. It will be closed if no further activity occurs **within 3 days of this comment**.
-    - description: 
+    - description:
       frequencies:
       - hourly:
           hour: 1
@@ -59,20 +59,30 @@ configuration:
           reply: This issue has been marked as duplicate and has not had any activity for **1 day**. It will be closed for housekeeping purposes.
       - closeIssue
     eventResponderTasks:
+    - if:
+      - payloadType: Issues
+      - isAction:
+          action: Closed
+      - hasLabel:
+          label: 'status:waiting-for-author-feedback'
+      then:
+      - removeLabel:
+          label: 'status:waiting-for-author-feedback'
+      description:
     - if:
       - payloadType: Issue_Comment
       - isAction:
           action: Created
       - isActivitySender:
           issueAuthor: True
       - hasLabel:
-          label: 'Needs: Author Feedback'
+          label: 'status:waiting-for-author-feedback'
       then:
       - addLabel:
           label: 'Needs: Attention :wave:'
       - removeLabel:
-          label: 'Needs: Author Feedback'
-      description: 
+          label: 'status:waiting-for-author-feedback'
+      description:
     - if:
       - payloadType: Issues
       - not:
@@ -83,13 +93,13 @@ configuration:
       then:
       - removeLabel:
           label: no-recent-activity
-      description: 
+      description:
     - if:
       - payloadType: Issues
       - labelAdded:
           label: service bug
       then: []
-      description: 
+      description:
     - if:
       - payloadType: Issue_Comment
       - activitySenderHasAssociation:
@@ -102,7 +112,7 @@ configuration:
           isRegex: False
       then:
       - addLabel:
-          label: 'Needs: Author Feedback'
-      description: 
-onFailure: 
-onSuccess: 
+          label: 'status:waiting-for-author-feedback'
+      description:
+onFailure:
+onSuccess:

.github/policies/resourceManagement.yml

@@ -0,0 +1,42 @@
+name: Publish Docker image
+on:
+  workflow_dispatch:
+  push:
+    tags: ["*"]
+env:
+  REGISTRY: msgraphprod.azurecr.io
+  IMAGE_NAME: public/microsoftgraph/powershell
+jobs:
+  push_to_registry:
+    environment:
+      name: acr
+    name: Push Docker image
+    runs-on: ubuntu-latest
+    steps:
+      - name: Check out the repo
+        uses: actions/checkout@v4
+      - name: Login to GitHub package feed
+        uses: docker/login-action@v3.3.0
+        with:
+          username: ${{ secrets.ACR_USERNAME }}
+          password: ${{ secrets.ACR_PASSWORD }}
+          registry: ${{ env.REGISTRY }}
+
+      - name: Get truncated run number
+        id: getversion
+        run: |
+          $version = $Env:GITHUB_REF.replace("refs/tags/", "")
+          Write-Output "version=$version" >> $Env:GITHUB_OUTPUT
+        shell: pwsh
+      - name: Set up QEMU
+        uses: docker/setup-qemu-action@v3
+      - name: Set up Docker Buildx
+        uses: docker/setup-buildx-action@v3
+      - name: Push to GitHub Packages - Release
+        uses: docker/build-push-action@v6.5.0
+        with:
+          push: true
+          platforms: linux/amd64,linux/arm64/v8,linux/arm/v7
+          tags: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:latest,${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${{ steps.getversion.outputs.version }}
+          build-args: |
+            VERSION=${{ steps.getversion.outputs.version }}

.github/workflows/docker.yml

@@ -0,0 +1,68 @@
+# Copyright (c) Microsoft Corporation. All rights reserved.
+# Licensed under the MIT License.
+# This is a basic workflow to help you get started with Actions
+
+name: "Metadata Changes"
+on:
+  workflow_dispatch:
+  pull_request:
+    branches:
+      - dev
+    paths:
+      - openApiDocs/**
+      - src/Authentication/Authentication/custom/common/MgCommandMetadata.json
+      - docs/OpenApiInfo/**
+
+# A workflow run is made up of one or more jobs that can run sequentially or in parallel
+jobs:
+  CheckForMetadataChanges:
+    # The type of runner that the job will run on
+    runs-on: ubuntu-latest
+    permissions:
+      pull-requests: write
+    if: github.event_name == 'workflow_dispatch' || (github.event_name == 'pull_request' && github.event.action != 'closed')
+    # Steps represent a sequence of tasks that will be executed as part of the job
+    steps:
+    # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
+    - name: Checkout
+      uses: actions/checkout@v4
+      with:
+        ref: ${{ github.event.pull_request.head.sha }}
+
+                
+    # Check if error report exists
+    - name: Check file existence
+      id: check_files
+      uses: andstor/file-existence-action@v3
+      with:
+        files: "docs/OpenApiInfo/v1.0/openAPIErrors.csv"
+    
+    # If it exists then add a warning to comment section of the PR
+    - name: File exists
+      if: steps.check_files.outputs.files_exists == 'true'
+      uses: actions/github-script@v7
+      with:
+        script: |
+          const name = 'OpenApiChecks';
+          const body = '**Changes in metadata detected :bangbang:** :warning:\n Please have a look at the metadata changes report in `docs/OpenApiInfo/v1.0/openAPIErrors.csv`\nThis action is important before merging :pleading_face:';
+  
+          await github.rest.issues.createComment({
+            issue_number: context.issue.number,
+            owner: context.repo.owner,
+            repo: context.repo.repo,
+            body: body
+          })
+
+          await github.rest.pulls.createReview({
+            owner: context.repo.owner,
+            repo: context.repo.repo,
+            body: body,
+            pull_number: context.issue.number,
+            event: 'REQUEST_CHANGES'
+          })
+
+          core.setFailed(body)
+
+# [0] https://help.github.com/en/actions/configuring-and-managing-workflows/using-environment-variables
+# [1] https://hub.github.com/hub-pull-request.1.html
+# https://help.github.com/en/actions/configuring-and-managing-workflows/authenticating-with-the-github_token