Skip to content

Commit 6696333

Browse files
authored
Merge pull request #2721 from microsoftgraph/backward-compatilibility-fix
Backward Compatibility to address issues in 2.17.0 and 2.18.0
2 parents 1e82dee + 307cb88 commit 6696333

File tree

14 files changed

+220510
-194986
lines changed

14 files changed

+220510
-194986
lines changed

src/Applications/Applications.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,4 +30,6 @@ directive:
3030
subject: ^(OnPremisePublishingProfile)(\1)+
3131
set:
3232
subject: $1
33+
#Prevent paths from being generated to allow for aliasing as a result of breaking changes in 2.18.0 and 2.17.0
34+
- remove-path-by-operation: ^application_DeleteOwnerGraphBPreRef$|^application_DeleteAppManagementPolicyGraphBPreRef$|^application_DeleteTokenIssuancePolicyGraphBPreRef$|^application_DeleteTokenLifetimePolicyGraphBPreRef$|^servicePrincipal_DeleteClaimsMappingPolicyGraphBPreRef$|^servicePrincipal_DeleteHomeRealmDiscoveryPolicyGraphBPreRef$|^servicePrincipal_DeleteOwnerGraphBPreRef$|^onPremisesPublishingProfile.agentGroup.agent_DeleteAgentGroupGraphBPreRef$|^onPremisesPublishingProfile.connectorGroup_DeleteMemberGraphBPreRef$|^onPremisesPublishingProfile.connector_ListMemberGraphOPreGraphBPreRef$|^onPremisesPublishingProfile.publishedResource_DeleteAgentGroupGraphBPreRef$|^onPremisesPublishingProfile.agentGroup.publishedResource_DeleteAgentGroupGraphBPreRef$
3335
```

src/Authentication/Authentication/Cmdlets/InvokeMgGraphRequest.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -402,7 +402,8 @@ private Uri PrepareUri(HttpClient httpClient, Uri uri)
402402
// set body to null to prevent later FillRequestStream
403403
Body = null;
404404
}
405-
return uriBuilder.Uri.EscapeDataStrings();
405+
//Review fix made in https://github.com/microsoftgraph/msgraph-sdk-powershell/pull/2690
406+
return uriBuilder.Uri;
406407
}
407408

408409
private void ThrowIfError(ErrorRecord error)

src/Authentication/Authentication/Models/GraphCommand.cs

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,14 @@ public interface IGraphCommand
3838
/// </summary>
3939
string[] Variants { get; set; }
4040
/// <summary>
41+
/// Command Alias.
42+
/// </summary>
43+
string CommandAlias { get; set ; }
44+
/// <summary>
45+
/// The response type of the command.
46+
/// </summary>
47+
string ApiReferenceLink { get; set; }
48+
/// <summary>
4149
/// The permissions needed to use the command.
4250
/// </summary>
4351
GraphPermission[] Permissions { get; set; }
@@ -84,6 +92,10 @@ public class GraphCommand : IGraphCommand
8492
/// The permissions needed to use the command.
8593
/// </summary>
8694
public GraphPermission[] Permissions { get; set; }
95+
/// <summary>
96+
/// Command Alias.
97+
/// </summary>
98+
public string CommandAlias { get; set ; }
8799
}
88100

89101
/// <summary>

0 commit comments

Comments
 (0)