From 725774fe3de3db5eecec333bd601ee0439d4bb33 Mon Sep 17 00:00:00 2001 From: Paula Camargo Date: Mon, 8 Apr 2024 12:35:15 -0700 Subject: [PATCH 1/5] fix anotations --- src/test/runTest.ts | 2 +- src/test/unittest/adapter/adapter.test.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/test/runTest.ts b/src/test/runTest.ts index 44cc5fdf..4122198f 100644 --- a/src/test/runTest.ts +++ b/src/test/runTest.ts @@ -18,7 +18,7 @@ async function main() { const [cliPath, ...args] = resolveCliArgsFromVSCodeExecutablePath(vscodeExecutablePath); // Use cp.spawn / cp.exec for custom setup - if (getOSType() == OSType.Windows) { + if (getOSType() === OSType.Windows) { const exec = path.basename(cliPath); cp.spawnSync(exec, [...args, '--install-extension', PVSC_EXTENSION_ID_FOR_TESTS], { cwd: path.dirname(cliPath), diff --git a/src/test/unittest/adapter/adapter.test.ts b/src/test/unittest/adapter/adapter.test.ts index 5a1c263f..09cf9081 100644 --- a/src/test/unittest/adapter/adapter.test.ts +++ b/src/test/unittest/adapter/adapter.test.ts @@ -57,7 +57,7 @@ suite('Debugger Integration', () => { 'launch': ['launch a file', [...defaultScriptArgs, outFile]], // prettier-ignore 'attach': ['attach to a local port', defaultScriptArgs], - 'attach to PID': ['attach to a local PID', defaultScriptArgs], + 'attach to PID': ['attach to a local PID', defaultScriptArgs], // eslint-disable-line no-use-before-define // For now we do not worry about "test" debugging. }; From c53773e2197e63b8826fde1fb9d5f6c5094ea41f Mon Sep 17 00:00:00 2001 From: Paula Camargo Date: Mon, 8 Apr 2024 12:42:29 -0700 Subject: [PATCH 2/5] disable naming --- src/extension/debugger/hooks/debugpySocketsHandler.ts | 4 ++-- src/test/unittest/adapter/factory.unit.test.ts | 1 + src/test/unittest/configuration/resolvers/base.unit.test.ts | 3 ++- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/extension/debugger/hooks/debugpySocketsHandler.ts b/src/extension/debugger/hooks/debugpySocketsHandler.ts index b777a271..3491314d 100644 --- a/src/extension/debugger/hooks/debugpySocketsHandler.ts +++ b/src/extension/debugger/hooks/debugpySocketsHandler.ts @@ -29,9 +29,9 @@ export class DebugpySocketsHandler implements IDebugSessionEventHandlers { return; } - if (event.event == DebuggerEvents.DebugpySockets) { + if (event.event === DebuggerEvents.DebugpySockets) { let portSocket = event.body.sockets.find((socket: { [x: string]: any }) => { - return socket['internal'] == false; + return socket['internal'] === false; }); if (portSocket != undefined) { this.debugPortAttributesProvider.setPortAttribute(portSocket.port); diff --git a/src/test/unittest/adapter/factory.unit.test.ts b/src/test/unittest/adapter/factory.unit.test.ts index d4f10204..97707a30 100644 --- a/src/test/unittest/adapter/factory.unit.test.ts +++ b/src/test/unittest/adapter/factory.unit.test.ts @@ -1,3 +1,4 @@ +/* eslint-disable @typescript-eslint/naming-convention */ // Copyright (c) Microsoft Corporation. All rights reserved. // Licensed under the MIT License. diff --git a/src/test/unittest/configuration/resolvers/base.unit.test.ts b/src/test/unittest/configuration/resolvers/base.unit.test.ts index 794828bd..ae63c4b9 100644 --- a/src/test/unittest/configuration/resolvers/base.unit.test.ts +++ b/src/test/unittest/configuration/resolvers/base.unit.test.ts @@ -1,4 +1,5 @@ -/* eslint-disable class-methods-use-this */ +/* eslint-disable class-methods-use-this*/ +/* eslint-disable @typescript-eslint/naming-convention */ // Copyright (c) Microsoft Corporation. All rights reserved. // Licensed under the MIT License. From 30d4550ea448bda22544ec60250b9775193a6714 Mon Sep 17 00:00:00 2001 From: Paula Camargo Date: Mon, 8 Apr 2024 12:45:34 -0700 Subject: [PATCH 3/5] fix annotation --- src/extension/debugger/hooks/debugpySocketsHandler.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/extension/debugger/hooks/debugpySocketsHandler.ts b/src/extension/debugger/hooks/debugpySocketsHandler.ts index 3491314d..56492e9f 100644 --- a/src/extension/debugger/hooks/debugpySocketsHandler.ts +++ b/src/extension/debugger/hooks/debugpySocketsHandler.ts @@ -33,7 +33,7 @@ export class DebugpySocketsHandler implements IDebugSessionEventHandlers { let portSocket = event.body.sockets.find((socket: { [x: string]: any }) => { return socket['internal'] === false; }); - if (portSocket != undefined) { + if (portSocket !== undefined) { this.debugPortAttributesProvider.setPortAttribute(portSocket.port); } } else { From 8970591c41348ec767ff122f7b05fb4bcbc86c31 Mon Sep 17 00:00:00 2001 From: Paula Camargo Date: Mon, 8 Apr 2024 12:50:10 -0700 Subject: [PATCH 4/5] fixc code --- src/extension/extensionInit.ts | 4 +++- tsconfig.json | 1 - 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/extension/extensionInit.ts b/src/extension/extensionInit.ts index 7112941b..904621c0 100644 --- a/src/extension/extensionInit.ts +++ b/src/extension/extensionInit.ts @@ -95,7 +95,9 @@ export async function registerDebugger(context: IExtensionContext): Promise Date: Mon, 8 Apr 2024 13:01:41 -0700 Subject: [PATCH 5/5] disable naming-convention --- src/test/unittest/adapter/adapter.test.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/test/unittest/adapter/adapter.test.ts b/src/test/unittest/adapter/adapter.test.ts index 09cf9081..e9038505 100644 --- a/src/test/unittest/adapter/adapter.test.ts +++ b/src/test/unittest/adapter/adapter.test.ts @@ -1,5 +1,6 @@ // Copyright (c) Microsoft Corporation. All rights reserved. // Licensed under the MIT License. +/* eslint-disable @typescript-eslint/naming-convention */ 'use strict'; @@ -57,7 +58,7 @@ suite('Debugger Integration', () => { 'launch': ['launch a file', [...defaultScriptArgs, outFile]], // prettier-ignore 'attach': ['attach to a local port', defaultScriptArgs], - 'attach to PID': ['attach to a local PID', defaultScriptArgs], // eslint-disable-line no-use-before-define + 'attach to PID': ['attach to a local PID', defaultScriptArgs], // For now we do not worry about "test" debugging. };