From 02b100db664c19293e627c19b17d6f675fc84fd8 Mon Sep 17 00:00:00 2001 From: Adi Azulay Date: Fri, 5 Feb 2021 14:53:05 -0800 Subject: [PATCH 01/13] update usb native --- package-lock.json | 126 ++++++++++++++++++++++++++++------------------ package.json | 6 +-- 2 files changed, 80 insertions(+), 52 deletions(-) diff --git a/package-lock.json b/package-lock.json index d72659ed..8229e3f9 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "vscode-arduino", - "version": "0.3.3", + "version": "0.3.5", "lockfileVersion": 1, "requires": true, "dependencies": { @@ -84,9 +84,9 @@ }, "dependencies": { "debug": { - "version": "4.2.0", - "resolved": "https://registry.npmjs.org/debug/-/debug-4.2.0.tgz", - "integrity": "sha512-IX2ncY78vDTjZMFUdmsvIRFY2Cf4FnD0wRs+nQwJU8Lu99/tPFdb0VybiiMTPe3I6rQmwsqQqRBvxU+bZ/I8sg==", + "version": "4.3.1", + "resolved": "https://registry.npmjs.org/debug/-/debug-4.3.1.tgz", + "integrity": "sha512-doEwdvm4PCeK4K3RQN2ZC2BYUBaxwLARCqZmMjtF8a51J2Rb0xpVloFRnCODwqjpwnAoao4pelN8l3RJdv3gRQ==", "requires": { "ms": "2.1.2" } @@ -108,9 +108,9 @@ }, "dependencies": { "debug": { - "version": "4.2.0", - "resolved": "https://registry.npmjs.org/debug/-/debug-4.2.0.tgz", - "integrity": "sha512-IX2ncY78vDTjZMFUdmsvIRFY2Cf4FnD0wRs+nQwJU8Lu99/tPFdb0VybiiMTPe3I6rQmwsqQqRBvxU+bZ/I8sg==", + "version": "4.3.1", + "resolved": "https://registry.npmjs.org/debug/-/debug-4.3.1.tgz", + "integrity": "sha512-doEwdvm4PCeK4K3RQN2ZC2BYUBaxwLARCqZmMjtF8a51J2Rb0xpVloFRnCODwqjpwnAoao4pelN8l3RJdv3gRQ==", "requires": { "ms": "2.1.2" } @@ -123,22 +123,22 @@ } }, "@serialport/bindings": { - "version": "9.0.2", - "resolved": "https://registry.npmjs.org/@serialport/bindings/-/bindings-9.0.2.tgz", - "integrity": "sha512-kQ3co4aGwwbUqkRdJ7UfdlbLB5dUQwNfSglexC8iv65D5HXfjSBR1bE0XUH8PH/v/6Dh6CSnwf6OP0I3H5vMWQ==", + "version": "9.0.4", + "resolved": "https://registry.npmjs.org/@serialport/bindings/-/bindings-9.0.4.tgz", + "integrity": "sha512-6dlE1vm5c1xk667f1Zm7D+msbHJ9jdnUr9l8DResKpj2iCBzbCNsW+yCYq26WxzXWc1L2HUaS3/aL+k0wm5amg==", "requires": { "@serialport/binding-abstract": "^9.0.2", "@serialport/parser-readline": "^9.0.1", "bindings": "^1.5.0", - "debug": "^4.1.1", - "nan": "^2.14.1", - "prebuild-install": "^5.3.5" + "debug": "^4.3.1", + "nan": "^2.14.2", + "prebuild-install": "^6.0.0" }, "dependencies": { "debug": { - "version": "4.2.0", - "resolved": "https://registry.npmjs.org/debug/-/debug-4.2.0.tgz", - "integrity": "sha512-IX2ncY78vDTjZMFUdmsvIRFY2Cf4FnD0wRs+nQwJU8Lu99/tPFdb0VybiiMTPe3I6rQmwsqQqRBvxU+bZ/I8sg==", + "version": "4.3.1", + "resolved": "https://registry.npmjs.org/debug/-/debug-4.3.1.tgz", + "integrity": "sha512-doEwdvm4PCeK4K3RQN2ZC2BYUBaxwLARCqZmMjtF8a51J2Rb0xpVloFRnCODwqjpwnAoao4pelN8l3RJdv3gRQ==", "requires": { "ms": "2.1.2" } @@ -170,6 +170,11 @@ "resolved": "https://registry.npmjs.org/@serialport/parser-delimiter/-/parser-delimiter-9.0.1.tgz", "integrity": "sha512-+oaSl5zEu47OlrRiF5p5tn2qgGqYuhVcE+NI+Pv4E1xsNB/A0fFxxMv/8XUw466CRLEJ5IESIB9qbFvKE6ltaQ==" }, + "@serialport/parser-inter-byte-timeout": { + "version": "9.0.1", + "resolved": "https://registry.npmjs.org/@serialport/parser-inter-byte-timeout/-/parser-inter-byte-timeout-9.0.1.tgz", + "integrity": "sha512-lFflcUflcP5SF4vLIixAKs1xUI/wfOzCv1Xq78VbPOBlIjZ6ny9lQ6g7cMPR/sB/M1BHwGcdX7CEr90pe3kkog==" + }, "@serialport/parser-readline": { "version": "9.0.1", "resolved": "https://registry.npmjs.org/@serialport/parser-readline/-/parser-readline-9.0.1.tgz", @@ -197,9 +202,9 @@ }, "dependencies": { "debug": { - "version": "4.2.0", - "resolved": "https://registry.npmjs.org/debug/-/debug-4.2.0.tgz", - "integrity": "sha512-IX2ncY78vDTjZMFUdmsvIRFY2Cf4FnD0wRs+nQwJU8Lu99/tPFdb0VybiiMTPe3I6rQmwsqQqRBvxU+bZ/I8sg==", + "version": "4.3.1", + "resolved": "https://registry.npmjs.org/debug/-/debug-4.3.1.tgz", + "integrity": "sha512-doEwdvm4PCeK4K3RQN2ZC2BYUBaxwLARCqZmMjtF8a51J2Rb0xpVloFRnCODwqjpwnAoao4pelN8l3RJdv3gRQ==", "requires": { "ms": "2.1.2" } @@ -1043,9 +1048,9 @@ } }, "bl": { - "version": "4.0.3", - "resolved": "https://registry.npmjs.org/bl/-/bl-4.0.3.tgz", - "integrity": "sha512-fs4G6/Hu4/EE+F75J8DuN/0IpQqNjAdC7aEQv7Qt8MHGUH7Ckv2MwTEEeN9QehD0pfIDkMI1bkHYkKy7xHyKIg==", + "version": "4.0.4", + "resolved": "https://registry.npmjs.org/bl/-/bl-4.0.4.tgz", + "integrity": "sha512-7tdr4EpSd7jJ6tuQ21vu2ke8w7pNEstzj1O8wwq6sNNzO3UDi5MA8Gny/gquCj7r2C6fHudg8tKRGyjRgmvNxQ==", "requires": { "buffer": "^5.5.0", "inherits": "^2.0.4", @@ -1255,9 +1260,9 @@ } }, "buffer": { - "version": "5.7.0", - "resolved": "https://registry.npmjs.org/buffer/-/buffer-5.7.0.tgz", - "integrity": "sha512-cd+5r1VLBwUqTrmnzW+D7ABkJUM6mr7uv1dv+6jRw4Rcl7tFIFHDqHPL98LhpGFn3dbAt3gtLxtrWp4m1kFrqg==", + "version": "5.7.1", + "resolved": "https://registry.npmjs.org/buffer/-/buffer-5.7.1.tgz", + "integrity": "sha512-EHcyIPBQ4BSGlvjB16k5KgAJ27CIsHY/2JBmCRReo48y9rQ3MaUzWX3KVlBa4U7MyX02HdVj0K7C3WaB3ju7FQ==", "requires": { "base64-js": "^1.3.1", "ieee754": "^1.1.13" @@ -6297,9 +6302,9 @@ "dev": true }, "node-abi": { - "version": "2.19.1", - "resolved": "https://registry.npmjs.org/node-abi/-/node-abi-2.19.1.tgz", - "integrity": "sha512-HbtmIuByq44yhAzK7b9j/FelKlHYISKQn0mtvcBrU5QBkhoCMp5bu8Hv5AI34DcKfOAcJBcOEMwLlwO62FFu9A==", + "version": "2.19.3", + "resolved": "https://registry.npmjs.org/node-abi/-/node-abi-2.19.3.tgz", + "integrity": "sha512-9xZrlyfvKhWme2EXFKQhZRp1yNWT/uI1luYPr3sFl+H4keYY4xR+1jO7mvTTijIsHf1M+QDe9uWuKeEpLInIlg==", "requires": { "semver": "^5.4.1" } @@ -6384,12 +6389,12 @@ } }, "node-usb-native": { - "version": "0.0.18", - "resolved": "https://registry.npmjs.org/node-usb-native/-/node-usb-native-0.0.18.tgz", - "integrity": "sha512-z2yGYM1MURtCdKsLZkN7X3b8ERNRQeMBLZ+7HEy/2PIJz76tVkrOqU+lvQtK2LkuLBtsIgsArjOzzrFdoYxijw==", + "version": "0.0.19", + "resolved": "https://registry.npmjs.org/node-usb-native/-/node-usb-native-0.0.19.tgz", + "integrity": "sha512-nW5UvIN4aSkWxaX+7b+3hwQkjZ++MtnWLLskp4r+X73KGW2vLm10scyGb1Na7A5Nij0Ey/qsYMZo5j4PLM65WA==", "requires": { "glob": "^7.1.6", - "serialport": "^9.0.1", + "serialport": "^9.0.4", "usb-detection": "^4.10.0" } }, @@ -6942,9 +6947,9 @@ "dev": true }, "prebuild-install": { - "version": "5.3.6", - "resolved": "https://registry.npmjs.org/prebuild-install/-/prebuild-install-5.3.6.tgz", - "integrity": "sha512-s8Aai8++QQGi4sSbs/M1Qku62PFK49Jm1CbgXklGz4nmHveDq0wzJkg7Na5QbnO1uNH8K7iqx2EQ/mV0MZEmOg==", + "version": "6.0.0", + "resolved": "https://registry.npmjs.org/prebuild-install/-/prebuild-install-6.0.0.tgz", + "integrity": "sha512-h2ZJ1PXHKWZpp1caLw0oX9sagVpL2YTk+ZwInQbQ3QqNd4J03O6MpFNmMTJlkfgPENWqe5kP0WjQLqz5OjLfsw==", "requires": { "detect-libc": "^1.0.3", "expand-template": "^2.0.3", @@ -7531,15 +7536,16 @@ } }, "serialport": { - "version": "9.0.2", - "resolved": "https://registry.npmjs.org/serialport/-/serialport-9.0.2.tgz", - "integrity": "sha512-N++EVrc2F3kUJ6aCE6BLxHwTrelFAZM3LFw4lo8TV0fDtfrwTc3+aoDpSsvfQg3DxrRf3shCtA6WYEH4g8kapw==", + "version": "9.0.6", + "resolved": "https://registry.npmjs.org/serialport/-/serialport-9.0.6.tgz", + "integrity": "sha512-T9eY4HFzQij0Hd/RsPcZySdeuAqzV5iGICHz8FXUSKVn2SvGT5zjfz/H+pRwI86k+3iFVOyddEyy8gbVNVbW7A==", "requires": { "@serialport/binding-mock": "^9.0.2", - "@serialport/bindings": "^9.0.2", + "@serialport/bindings": "^9.0.4", "@serialport/parser-byte-length": "^9.0.1", "@serialport/parser-cctalk": "^9.0.1", "@serialport/parser-delimiter": "^9.0.1", + "@serialport/parser-inter-byte-timeout": "^9.0.1", "@serialport/parser-readline": "^9.0.1", "@serialport/parser-ready": "^9.0.1", "@serialport/parser-regex": "^9.0.1", @@ -7548,9 +7554,9 @@ }, "dependencies": { "debug": { - "version": "4.2.0", - "resolved": "https://registry.npmjs.org/debug/-/debug-4.2.0.tgz", - "integrity": "sha512-IX2ncY78vDTjZMFUdmsvIRFY2Cf4FnD0wRs+nQwJU8Lu99/tPFdb0VybiiMTPe3I6rQmwsqQqRBvxU+bZ/I8sg==", + "version": "4.3.1", + "resolved": "https://registry.npmjs.org/debug/-/debug-4.3.1.tgz", + "integrity": "sha512-doEwdvm4PCeK4K3RQN2ZC2BYUBaxwLARCqZmMjtF8a51J2Rb0xpVloFRnCODwqjpwnAoao4pelN8l3RJdv3gRQ==", "requires": { "ms": "2.1.2" } @@ -8200,20 +8206,20 @@ } }, "tar-fs": { - "version": "2.1.0", - "resolved": "https://registry.npmjs.org/tar-fs/-/tar-fs-2.1.0.tgz", - "integrity": "sha512-9uW5iDvrIMCVpvasdFHW0wJPez0K4JnMZtsuIeDI7HyMGJNxmDZDOCQROr7lXyS+iL/QMpj07qcjGYTSdRFXUg==", + "version": "2.1.1", + "resolved": "https://registry.npmjs.org/tar-fs/-/tar-fs-2.1.1.tgz", + "integrity": "sha512-V0r2Y9scmbDRLCNex/+hYzvp/zyYjvFbHPNgVTKfQvVrb6guiE/fxP+XblDNR011utopbkex2nM4dHNV6GDsng==", "requires": { "chownr": "^1.1.1", "mkdirp-classic": "^0.5.2", "pump": "^3.0.0", - "tar-stream": "^2.0.0" + "tar-stream": "^2.1.4" } }, "tar-stream": { - "version": "2.1.4", - "resolved": "https://registry.npmjs.org/tar-stream/-/tar-stream-2.1.4.tgz", - "integrity": "sha512-o3pS2zlG4gxr67GmFYBLlq+dM8gyRGUOvsrHclSkvtVtQbjV0s/+ZE8OpICbaj8clrX3tjeHngYGP7rweaBnuw==", + "version": "2.2.0", + "resolved": "https://registry.npmjs.org/tar-stream/-/tar-stream-2.2.0.tgz", + "integrity": "sha512-ujeqbceABgwMZxEJnk2HDY2DlnUZ+9oEcb1KzTVfYHio0UE6dG71n60d8D2I4qNvleWrrXpmjpt7vZeF1LnMZQ==", "requires": { "bl": "^4.0.3", "end-of-stream": "^1.4.1", @@ -8726,6 +8732,28 @@ "version": "5.0.1", "resolved": "https://registry.npmjs.org/eventemitter2/-/eventemitter2-5.0.1.tgz", "integrity": "sha1-YZegldX7a1folC9v1+qtY6CclFI=" + }, + "prebuild-install": { + "version": "5.3.6", + "resolved": "https://registry.npmjs.org/prebuild-install/-/prebuild-install-5.3.6.tgz", + "integrity": "sha512-s8Aai8++QQGi4sSbs/M1Qku62PFK49Jm1CbgXklGz4nmHveDq0wzJkg7Na5QbnO1uNH8K7iqx2EQ/mV0MZEmOg==", + "requires": { + "detect-libc": "^1.0.3", + "expand-template": "^2.0.3", + "github-from-package": "0.0.0", + "minimist": "^1.2.3", + "mkdirp-classic": "^0.5.3", + "napi-build-utils": "^1.0.1", + "node-abi": "^2.7.0", + "noop-logger": "^0.1.1", + "npmlog": "^4.0.1", + "pump": "^3.0.0", + "rc": "^1.2.7", + "simple-get": "^3.0.3", + "tar-fs": "^2.0.0", + "tunnel-agent": "^0.6.0", + "which-pm-runs": "^1.0.0" + } } } }, diff --git a/package.json b/package.json index 0d526c16..6629987b 100644 --- a/package.json +++ b/package.json @@ -2,12 +2,12 @@ "name": "vscode-arduino", "displayName": "Arduino", "description": "Arduino for Visual Studio Code", - "version": "0.3.4", + "version": "0.3.5", "publisher": "vsciot-vscode", "aiKey": "83dd2c27-6594-41d3-85a9-bdb22070eb42", "preview": true, "engines": { - "vscode": "^1.50.0" + "vscode": "^1.53.0" }, "icon": "images/arduino.png", "license": "SEE LICENSE IN LICENSE.txt", @@ -582,7 +582,7 @@ "glob": "^7.1.1", "iconv-lite": "^0.4.18", "impor": "^0.1.1", - "node-usb-native": "^0.0.18", + "node-usb-native": "^0.0.19", "properties": "^1.2.1", "uuid": "^3.0.1", "vscode-extension-telemetry": "0.1.6", From 3ba066ccb74c7f6691efb3526430a266e3079741 Mon Sep 17 00:00:00 2001 From: Adi Azulay Date: Fri, 5 Feb 2021 15:02:23 -0800 Subject: [PATCH 02/13] update changelog --- CHANGELOG.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 858ce039..9c9f877d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,13 @@ # Change Log All notable changes to this project will be documented in this file. +## Version 0.3.5 + +- Release date: November 22, 2020 + +### Fixes +- Update to node-usb-native 0.0.19 + ## Version 0.3.4 - Release date: November 22, 2020 From 6fb49f218ea3f1c876deeccbd8e5c18f2c0dda55 Mon Sep 17 00:00:00 2001 From: Adi Azulay Date: Tue, 9 Feb 2021 16:36:45 -0800 Subject: [PATCH 03/13] fix ref tag for publishing --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index c2598d3d..2c9582bc 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -104,5 +104,5 @@ jobs: overwrite: true file_glob: true - name: publish - if: github.ref == 'refs/tags/[0-9].[0-9].[0-9]' + if: github.ref == 'refs/tags/v[0-9].[0-9].[0-9]' run: vsce publish -p ${{ secrets.VSCE_TOKEN }} From 27f45f2d5489fe3d0b9a8b5611bd1c07a10eb476 Mon Sep 17 00:00:00 2001 From: Adi Azulay Date: Tue, 9 Feb 2021 17:09:28 -0800 Subject: [PATCH 04/13] fix ref tag for publishing --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 2c9582bc..5b2a7951 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -104,5 +104,5 @@ jobs: overwrite: true file_glob: true - name: publish - if: github.ref == 'refs/tags/v[0-9].[0-9].[0-9]' + if: github.ref == 'refs/tags/v[0-9].[0-9]+.[0-9]+' run: vsce publish -p ${{ secrets.VSCE_TOKEN }} From f21560ff03fd4ff37fcf9f4d4dfbd40bb27a3f4a Mon Sep 17 00:00:00 2001 From: Adi Azulay Date: Tue, 9 Feb 2021 17:44:03 -0800 Subject: [PATCH 05/13] change build to check version env var --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 5b2a7951..19fa530e 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -104,5 +104,5 @@ jobs: overwrite: true file_glob: true - name: publish - if: github.ref == 'refs/tags/v[0-9].[0-9]+.[0-9]+' + if: env.Version == 'v[0-9]+.[0-9]+.[0-9]+' run: vsce publish -p ${{ secrets.VSCE_TOKEN }} From ec036cc9d13e4c1da27d3ecb79463cbb6d553487 Mon Sep 17 00:00:00 2001 From: Adi Azulay Date: Tue, 9 Feb 2021 17:55:30 -0800 Subject: [PATCH 06/13] fix version spelling --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 19fa530e..4adf759e 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -104,5 +104,5 @@ jobs: overwrite: true file_glob: true - name: publish - if: env.Version == 'v[0-9]+.[0-9]+.[0-9]+' + if: env.VERSION== 'v[0-9]+.[0-9]+.[0-9]+' run: vsce publish -p ${{ secrets.VSCE_TOKEN }} From dafafae687ffb5fd6a2e544e651746e7f0ea6e1b Mon Sep 17 00:00:00 2001 From: Adi Azulay Date: Tue, 9 Feb 2021 18:17:01 -0800 Subject: [PATCH 07/13] add {} to if in publish --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 4adf759e..7c86dff5 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -104,5 +104,5 @@ jobs: overwrite: true file_glob: true - name: publish - if: env.VERSION== 'v[0-9]+.[0-9]+.[0-9]+' + if: ${{ env.VERSION == 'v[0-9]+.[0-9]+.[0-9]+' }} run: vsce publish -p ${{ secrets.VSCE_TOKEN }} From 8682f42d0820ca2caee8e1dfefc5188a33a78db1 Mon Sep 17 00:00:00 2001 From: Adi Azulay Date: Wed, 10 Feb 2021 08:18:01 -0800 Subject: [PATCH 08/13] change version check to regex --- .github/workflows/build.yml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 7c86dff5..cc12e5c2 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -103,6 +103,11 @@ jobs: tag: ${{ github.ref }} overwrite: true file_glob: true + - name: check for production tag + id: check-version + run: if [[ ${{ env.VERSION }} =~ ^v[0-9]+\.[0-9]+\.[0-9]+$ ]]; then + echo ::set-output name=isprod::true + fi - name: publish - if: ${{ env.VERSION == 'v[0-9]+.[0-9]+.[0-9]+' }} + if: steps.check-version.output.isprod == 'true' run: vsce publish -p ${{ secrets.VSCE_TOKEN }} From eb0f4771cb7c868919a5febb3b48af747fb6a40d Mon Sep 17 00:00:00 2001 From: Adi Azulay Date: Wed, 10 Feb 2021 08:34:49 -0800 Subject: [PATCH 09/13] fix formatting --- .github/workflows/build.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index cc12e5c2..eb1be8c6 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -106,8 +106,8 @@ jobs: - name: check for production tag id: check-version run: if [[ ${{ env.VERSION }} =~ ^v[0-9]+\.[0-9]+\.[0-9]+$ ]]; then - echo ::set-output name=isprod::true - fi + echo '::set-output name=ISPRODUCTION::true' + fi - name: publish - if: steps.check-version.output.isprod == 'true' + if: steps.check-version.output.ISPRODUCTION == 'true' run: vsce publish -p ${{ secrets.VSCE_TOKEN }} From 05be6a3bd8ccff49cdf9fef929fb1d923f61c0b1 Mon Sep 17 00:00:00 2001 From: Adi Azulay Date: Wed, 10 Feb 2021 08:54:30 -0800 Subject: [PATCH 10/13] change to multiline run --- .github/workflows/build.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index eb1be8c6..d68e6af1 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -105,9 +105,10 @@ jobs: file_glob: true - name: check for production tag id: check-version - run: if [[ ${{ env.VERSION }} =~ ^v[0-9]+\.[0-9]+\.[0-9]+$ ]]; then - echo '::set-output name=ISPRODUCTION::true' - fi + run: | + if [[ ${{ env.VERSION }} =~ ^v[0-9]+\.[0-9]+\.[0-9]+$ ]]; then + echo "::set-output name=ISPRODUCTION::true" + fi - name: publish if: steps.check-version.output.ISPRODUCTION == 'true' run: vsce publish -p ${{ secrets.VSCE_TOKEN }} From 59458da8f05042623b13064d6bec07dfcf0ca531 Mon Sep 17 00:00:00 2001 From: Adi Azulay Date: Wed, 10 Feb 2021 09:29:43 -0800 Subject: [PATCH 11/13] add echo for ISPRODUCTION --- .github/workflows/build.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index d68e6af1..1fb751c9 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -107,8 +107,9 @@ jobs: id: check-version run: | if [[ ${{ env.VERSION }} =~ ^v[0-9]+\.[0-9]+\.[0-9]+$ ]]; then - echo "::set-output name=ISPRODUCTION::true" + echo ::set-output name=ISPRODUCTION::true fi + echo "steps.check-version.output.ISPRODUCTION" - name: publish if: steps.check-version.output.ISPRODUCTION == 'true' run: vsce publish -p ${{ secrets.VSCE_TOKEN }} From 4ff43e8ee7cccd79a9ff994330000a431c369a58 Mon Sep 17 00:00:00 2001 From: Adi Azulay Date: Wed, 10 Feb 2021 09:47:37 -0800 Subject: [PATCH 12/13] add missing s to outputs --- .github/workflows/build.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 1fb751c9..0d541195 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -109,7 +109,7 @@ jobs: if [[ ${{ env.VERSION }} =~ ^v[0-9]+\.[0-9]+\.[0-9]+$ ]]; then echo ::set-output name=ISPRODUCTION::true fi - echo "steps.check-version.output.ISPRODUCTION" + echo steps.check-version.outputs.ISPRODUCTION - name: publish - if: steps.check-version.output.ISPRODUCTION == 'true' + if: steps.check-version.outputs.ISPRODUCTION == 'true' run: vsce publish -p ${{ secrets.VSCE_TOKEN }} From df5f4ee0da9a4154eab522cf94766eb77ecc942c Mon Sep 17 00:00:00 2001 From: Adi Azulay Date: Thu, 18 Feb 2021 08:26:49 -0800 Subject: [PATCH 13/13] remove debugging echo --- .github/workflows/build.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 0d541195..47a37649 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -109,7 +109,6 @@ jobs: if [[ ${{ env.VERSION }} =~ ^v[0-9]+\.[0-9]+\.[0-9]+$ ]]; then echo ::set-output name=ISPRODUCTION::true fi - echo steps.check-version.outputs.ISPRODUCTION - name: publish if: steps.check-version.outputs.ISPRODUCTION == 'true' run: vsce publish -p ${{ secrets.VSCE_TOKEN }}