From 47ec92c99a4804ab2f1bd273f28997de61d61d00 Mon Sep 17 00:00:00 2001 From: Miroslav Stastny Date: Tue, 5 Feb 2019 21:23:33 +0100 Subject: [PATCH 1/2] Change CircleCI image to contain Chrome --- .circleci/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 179d320faf..47bf3b103b 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -6,7 +6,7 @@ general: jobs: build: docker: - - image: circleci/node:8 + - image: circleci/node:8-browsers environment: TZ: "/usr/share/zoneinfo/America/Los_Angeles" steps: From 9b52b1fd233bf7a7d73f70bb5762510186b5bcca Mon Sep 17 00:00:00 2001 From: Miroslav Stastny Date: Tue, 5 Feb 2019 22:13:54 +0100 Subject: [PATCH 2/2] Run `yarn perf` in CI --- .circleci/config.yml | 3 +++ build/gulp/tasks/perf.ts | 4 +++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 47bf3b103b..695d497d07 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -80,6 +80,9 @@ jobs: - run: name: Bundle Statistics command: yarn build:stats + - run: + name: Performance Tests + command: yarn perf - run: name: Danger JS command: | diff --git a/build/gulp/tasks/perf.ts b/build/gulp/tasks/perf.ts index e369fcfc11..2c1752d092 100644 --- a/build/gulp/tasks/perf.ts +++ b/build/gulp/tasks/perf.ts @@ -86,7 +86,9 @@ task('perf:run', async () => { let browser try { - browser = await puppeteer.launch() + browser = await puppeteer.launch({ + args: ['--single-process'], // Workaround for newPage hang in CircleCI: https://github.com/GoogleChrome/puppeteer/issues/1409#issuecomment-453845568 + }) for (let i = 0; i < times; i++) { const page = await browser.newPage()