Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

Commit 0fd14dc

Browse files
authored
fix(Popup): Do not stop propagation when pressing Esc on trigger element (#750)
* fix(Popup): Do not stop propagation when pressing Esc on trigger element * Update chnagelog
1 parent 5b921a3 commit 0fd14dc

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
2121
- Fix focus outline visible only during keyboard navigation in `ListItem` @layershifter ([#727](https://github.com/stardust-ui/react/pull/727))
2222
- Pass `jest --detectLeaks` tests @miroslavstastny ([#718](https://github.com/stardust-ui/react/pull/718))
2323
- Fix Avatar's size example @mnajdova ([#745](https://github.com/stardust-ui/react/pull/745))
24+
- Fix `Popup` - do not stop event propagation when pressing Esc on trigger element @sophieH29 ([#750](https://github.com/stardust-ui/react/pull/750))
2425

2526
### Features
2627
- Rename `Slot` component to `Box` and export it @Bugaa92 ([#713](https://github.com/stardust-ui/react/pull/713))

src/components/Popup/Popup.tsx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -175,10 +175,7 @@ export default class Popup extends AutoControlledComponent<ReactProps<PopupProps
175175
this.close(e, () => _.invoke(this.triggerDomElement, 'focus'))
176176
e.stopPropagation()
177177
},
178-
close: e => {
179-
this.close(e)
180-
e.stopPropagation()
181-
},
178+
close: e => this.close(e),
182179
}
183180

184181
public componentDidMount() {

0 commit comments

Comments
 (0)