Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

Commit 0d8fe8d

Browse files
committed
adresing changes from review
1 parent d25bbca commit 0d8fe8d

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

packages/accessibility/test/behaviors/caroselBehavior-test.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,17 +6,17 @@ const label = "portrait collection"
66
describe('carouselBehavior.ts', () => {
77

88
describe('root', () => {
9-
test(`set "role=region" when carousel has NO navigation`, () => {
9+
test(`sets "role=region" when carousel has NO navigation`, () => {
1010
const expectedResult = carouselBehavior({ ariaLiveOn: false, navigation: false })
1111
expect(expectedResult.attributes.root.role).toEqual('region')
1212
})
1313

14-
test('set "aria-roledescription" when carousel has NO navigation', () => {
14+
test('sets "aria-roledescription" when carousel has NO navigation', () => {
1515
const expectedResult = carouselBehavior({ ariaLiveOn: false, navigation: false, ariaRoleDescription: roleDescription })
1616
expect(expectedResult.attributes.root['aria-roledescription']).toEqual(roleDescription)
1717
})
1818

19-
test('set "aria-label" when carousel has NO navigation', () => {
19+
test('sets "aria-label" when carousel has NO navigation', () => {
2020
const expectedResult = carouselBehavior({ ariaLiveOn: false, navigation: false, ariaLabel: label })
2121
expect(expectedResult.attributes.root['aria-label']).toEqual(label)
2222
})
@@ -38,12 +38,12 @@ describe('carouselBehavior.ts', () => {
3838
})
3939

4040
describe('itemsContainer', () => {
41-
test('set "aria-roledescription" when carousel has navigation', () => {
41+
test('sets "aria-roledescription" when carousel has navigation', () => {
4242
const expectedResult = carouselBehavior({ ariaLiveOn: false, navigation: true, ariaRoleDescription: roleDescription })
4343
expect(expectedResult.attributes.itemsContainer['aria-roledescription']).toEqual(roleDescription)
4444
})
4545

46-
test('set "aria-label" when carousel has navigation', () => {
46+
test('sets "aria-label" when carousel has navigation', () => {
4747
const expectedResult = carouselBehavior({ ariaLiveOn: false, navigation: true, ariaLabel: label })
4848
expect(expectedResult.attributes.itemsContainer['aria-label']).toEqual(label)
4949
})

packages/accessibility/test/behaviors/caroseltemBehavior-test.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,22 @@
11
import { carouselItemBehavior } from '@fluentui/accessibility'
22

33
describe('carouselItemBehavior.ts', () => {
4-
test('set tabIndex="0" when carousel has navigation and item is visible ', () => {
4+
test('sets tabIndex="0" on root when carousel has navigation and item is visible ', () => {
55
const expectedResult = carouselItemBehavior({ navigation: true, active: true })
66
expect(expectedResult.attributes.root.tabIndex).toEqual(0)
77
})
88

9-
test('set tabIndex="-1" when carousel has navigation and item is NOT visible ', () => {
9+
test('sets tabIndex="-1" on root when carousel has navigation and item is NOT visible ', () => {
1010
const expectedResult = carouselItemBehavior({ navigation: true, active: false })
1111
expect(expectedResult.attributes.root.tabIndex).toEqual(-1)
1212
})
1313

14-
test('set tabIndex="-1" when carousel has NO navigation and item is visible', () => {
14+
test('sets tabIndex="-1" on root when carousel has NO navigation and item is visible', () => {
1515
const expectedResult = carouselItemBehavior({ navigation: false, active: true })
1616
expect(expectedResult.attributes.root.tabIndex).toEqual(-1)
1717
})
1818

19-
test('set tabIndex="-1" when carousel has NO navigation and item is NOT visible', () => {
19+
test('sets tabIndex="-1" on root when carousel has NO navigation and item is NOT visible', () => {
2020
const expectedResult = carouselItemBehavior({ navigation: false, active: false })
2121
expect(expectedResult.attributes.root.tabIndex).toEqual(-1)
2222
})

0 commit comments

Comments
 (0)