Merge branch 'master' into release-3.4

Author: RyanCavanaugh

scripts/authors.ts

@@ -15,8 +15,8 @@ type Command = {
     description?: string;
 };
 
-const mailMapPath = path.resolve("../.mailmap");
-const authorsPath = path.resolve("../AUTHORS.md");
+const mailMapPath = path.resolve(__dirname, "../.mailmap");
+const authorsPath = path.resolve(__dirname, "../AUTHORS.md");
 
 function getKnownAuthors(): Author[] {
     const segmentRegExp = /\s?([^<]+)\s+<([^>]+)>/g;
@@ -113,56 +113,54 @@ namespace Commands {
         const cmd = "git shortlog -se " + specs.join(" ");
         console.log(cmd);
         const outputRegExp = /\d+\s+([^<]+)<([^>]+)>/;
-        const tty = process.platform === 'win32' ? 'CON' : '/dev/tty';
         const authors: { name: string, email: string, knownAuthor?: Author }[] = [];
-        child_process.exec(`${cmd} < ${tty}`, { cwd: path.resolve("../") }, function (error, stdout, stderr) {
-            if (error) {
-                console.log(stderr.toString());
-            }
-            else {
-                const output = stdout.toString();
-                const lines = output.split("\n");
-                lines.forEach(line => {
-                    if (line) {
-                        let match: RegExpExecArray | null;
-                        if (match = outputRegExp.exec(line)) {
-                            authors.push({ name: match[1], email: match[2] });
-                        }
-                        else {
-                            throw new Error("Could not parse output: " + line);
-                        }
+        const {output: [error, stdout, stderr]} = child_process.spawnSync(`git`, ["shortlog", "-se", ...specs], { cwd: path.resolve(__dirname, "../") });
+        if (error) {
+            console.log(stderr.toString());
+        }
+        else {
+            const output = stdout.toString();
+            const lines = output.split("\n");
+            lines.forEach(line => {
+                if (line) {
+                    let match: RegExpExecArray | null;
+                    if (match = outputRegExp.exec(line)) {
+                        authors.push({ name: match[1], email: match[2] });
+                    }
+                    else {
+                        throw new Error("Could not parse output: " + line);
                     }
-                });
-
-                const maps = getKnownAuthorMaps();
-
-                const lookupAuthor = function ({name, email}: { name: string, email: string }) {
-                    return maps.authorsByEmail[email.toLocaleLowerCase()] || maps.authorsByName[name];
-                };
-
-                const knownAuthors = authors
-                    .map(lookupAuthor)
-                    .filter(a => !!a)
-                    .map(getAuthorName);
-                const unknownAuthors = authors
-                    .filter(a => !lookupAuthor(a))
-                    .map(a => `${a.name} <${a.email}>`);
-
-                if (knownAuthors.length) {
-                    console.log("\r\n");
-                    console.log("Found known authors: ");
-                    console.log("=====================");
-                    deduplicate(knownAuthors).sort(sortAuthors).forEach(log);
                 }
+            });
+
+            const maps = getKnownAuthorMaps();
+
+            const lookupAuthor = function ({name, email}: { name: string, email: string }) {
+                return maps.authorsByEmail[email.toLocaleLowerCase()] || maps.authorsByName[name];
+            };
+
+            const knownAuthors = authors
+                .map(lookupAuthor)
+                .filter(a => !!a)
+                .map(getAuthorName);
+            const unknownAuthors = authors
+                .filter(a => !lookupAuthor(a))
+                .map(a => `${a.name} <${a.email}>`);
+
+            if (knownAuthors.length) {
+                console.log("\r\n");
+                console.log("Found known authors: ");
+                console.log("=====================");
+                deduplicate(knownAuthors).sort(sortAuthors).forEach(log);
+            }
 
-                if (unknownAuthors.length) {
-                    console.log("\r\n");
-                    console.log("Found unknown authors: ");
-                    console.log("=====================");
-                    deduplicate(unknownAuthors).sort(sortAuthors).forEach(log);
-                }
+            if (unknownAuthors.length) {
+                console.log("\r\n");
+                console.log("Found unknown authors: ");
+                console.log("=====================");
+                deduplicate(unknownAuthors).sort(sortAuthors).forEach(log);
             }
-        });
+        }
     };
     listAuthors.description = "List known and unknown authors for a given spec, e.g. 'node authors.js listAuthors origin/release-2.6..origin/release-2.7'";
 }

scripts/perf-result-post.js

@@ -0,0 +1,48 @@
+// @ts-check
+/// <reference lib="esnext.asynciterable" />
+// Must reference esnext.asynciterable lib, since octokit uses AsyncIterable internally
+const Octokit = require("@octokit/rest");
+const fs = require("fs");
+
+const requester = process.env.requesting_user;
+const source = process.env.source_issue;
+const postedComment = process.env.status_comment;
+console.log(`Loading fragment from ${process.argv[3]}...`);
+const outputTableText = fs.readFileSync(process.argv[3], { encoding: "utf8" });
+console.log(`Fragment contents:
+${outputTableText}`);
+
+const gh = new Octokit();
+gh.authenticate({
+    type: "token",
+    token: process.argv[2]
+});
+gh.issues.createComment({
+    number: +source,
+    owner: "Microsoft",
+    repo: "TypeScript",
+    body: `@${requester}
+The results of the perf run you requested are in! Here they are:
+
+${outputTableText}`
+}).then(async data => {
+    console.log(`Results posted!`);
+    const newCommentUrl = data.data.html_url;
+    const comment = await gh.issues.getComment({
+        owner: "Microsoft",
+        repo: "TypeScript",
+        comment_id: +postedComment
+    });
+    const newBody = `${comment.data.body}
+
+Update: [The results are in!](${newCommentUrl})`;
+    return await gh.issues.updateComment({
+        owner: "Microsoft",
+        repo: "TypeScript",
+        comment_id: +postedComment,
+        body: newBody
+    });
+}).catch(e => {
+    console.error(e);
+    process.exit(1);
+});

src/compiler/builderState.ts

@@ -230,7 +230,7 @@ namespace ts.BuilderState {
 
         // Create the reference map, and set the file infos
         for (const sourceFile of newProgram.getSourceFiles()) {
-            const version = sourceFile.version;
+            const version = Debug.assertDefined(sourceFile.version, "Program intended to be used with Builder should have source files with versions set");
             const oldInfo = useOldState ? oldState!.fileInfos.get(sourceFile.path) : undefined;
             if (referencedMap) {
                 const newReferences = getReferencedFiles(newProgram, sourceFile, getCanonicalFileName);