From 2005da039d6133fe3fe60bc07adedf535ef78361 Mon Sep 17 00:00:00 2001 From: YuichiNukiyama Date: Tue, 9 Jan 2018 00:02:37 +0900 Subject: [PATCH] change getAttributeNode and getAttributeNodeNS fixes [#20977](https://github.com/Microsoft/TypeScript/issues/20977) --- baselines/dom.generated.d.ts | 4 ++-- inputfiles/overridingTypes.json | 16 ++++++++++++++++ 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/baselines/dom.generated.d.ts b/baselines/dom.generated.d.ts index 708cb51c2..312448c50 100644 --- a/baselines/dom.generated.d.ts +++ b/baselines/dom.generated.d.ts @@ -3596,8 +3596,8 @@ interface Element extends Node, GlobalEventHandlers, ElementTraversal, NodeSelec slot: string; readonly shadowRoot: ShadowRoot | null; getAttribute(name: string): string | null; - getAttributeNode(name: string): Attr; - getAttributeNodeNS(namespaceURI: string, localName: string): Attr; + getAttributeNode(name: string): Attr | null; + getAttributeNodeNS(namespaceURI: string, localName: string): Attr | null; getAttributeNS(namespaceURI: string, localName: string): string; getBoundingClientRect(): ClientRect; getClientRects(): ClientRectList; diff --git a/inputfiles/overridingTypes.json b/inputfiles/overridingTypes.json index 0398a1ed7..b4cfbd81b 100644 --- a/inputfiles/overridingTypes.json +++ b/inputfiles/overridingTypes.json @@ -1755,5 +1755,21 @@ "signatures": [ "setSelectionRange(start: number, end: number, direction?: \"forward\" | \"backward\" | \"none\"): void" ] + }, + { + "kind": "method", + "interface": "Element", + "name": "getAttributeNodeNS", + "signatures": [ + "getAttributeNodeNS(namespaceURI: string, localName: string): Attr | null" + ] + }, + { + "kind": "method", + "interface": "Element", + "name": "getAttributeNode", + "signatures": [ + "getAttributeNode(name: string): Attr | null" + ] } ] \ No newline at end of file