From 894fdc6724adaec7282649a859e3aa65bac35105 Mon Sep 17 00:00:00 2001 From: Basha MEGA Date: Fri, 28 Mar 2025 04:59:18 +0000 Subject: [PATCH 1/8] chore: override OnErrorEventHandlerNonNull --- baselines/dom.generated.d.ts | 2 +- baselines/serviceworker.generated.d.ts | 2 +- baselines/sharedworker.generated.d.ts | 2 +- baselines/ts5.5/dom.generated.d.ts | 2 +- baselines/ts5.5/serviceworker.generated.d.ts | 2 +- baselines/ts5.5/sharedworker.generated.d.ts | 2 +- baselines/ts5.5/webworker.generated.d.ts | 2 +- baselines/webworker.generated.d.ts | 2 +- inputfiles/overridingTypes.jsonc | 4 ++++ 9 files changed, 12 insertions(+), 8 deletions(-) diff --git a/baselines/dom.generated.d.ts b/baselines/dom.generated.d.ts index 749287a6a..72d550073 100644 --- a/baselines/dom.generated.d.ts +++ b/baselines/dom.generated.d.ts @@ -28466,7 +28466,7 @@ interface OnBeforeUnloadEventHandlerNonNull { } interface OnErrorEventHandlerNonNull { - (event: Event | string, source?: string, lineno?: number, colno?: number, error?: Error): any; + (event: Event, source?: string, lineno?: number, colno?: number, error?: Error): any; } interface PerformanceObserverCallback { diff --git a/baselines/serviceworker.generated.d.ts b/baselines/serviceworker.generated.d.ts index 9e9187f9d..de4908bc5 100644 --- a/baselines/serviceworker.generated.d.ts +++ b/baselines/serviceworker.generated.d.ts @@ -8527,7 +8527,7 @@ interface LockGrantedCallback { } interface OnErrorEventHandlerNonNull { - (event: Event | string, source?: string, lineno?: number, colno?: number, error?: Error): any; + (event: Event, source?: string, lineno?: number, colno?: number, error?: Error): any; } interface PerformanceObserverCallback { diff --git a/baselines/sharedworker.generated.d.ts b/baselines/sharedworker.generated.d.ts index 02ce26b81..6d0c4ac80 100644 --- a/baselines/sharedworker.generated.d.ts +++ b/baselines/sharedworker.generated.d.ts @@ -8465,7 +8465,7 @@ interface LockGrantedCallback { } interface OnErrorEventHandlerNonNull { - (event: Event | string, source?: string, lineno?: number, colno?: number, error?: Error): any; + (event: Event, source?: string, lineno?: number, colno?: number, error?: Error): any; } interface PerformanceObserverCallback { diff --git a/baselines/ts5.5/dom.generated.d.ts b/baselines/ts5.5/dom.generated.d.ts index f7cd2658c..4bf30ef1d 100644 --- a/baselines/ts5.5/dom.generated.d.ts +++ b/baselines/ts5.5/dom.generated.d.ts @@ -28444,7 +28444,7 @@ interface OnBeforeUnloadEventHandlerNonNull { } interface OnErrorEventHandlerNonNull { - (event: Event | string, source?: string, lineno?: number, colno?: number, error?: Error): any; + (event: Event, source?: string, lineno?: number, colno?: number, error?: Error): any; } interface PerformanceObserverCallback { diff --git a/baselines/ts5.5/serviceworker.generated.d.ts b/baselines/ts5.5/serviceworker.generated.d.ts index 9e9187f9d..de4908bc5 100644 --- a/baselines/ts5.5/serviceworker.generated.d.ts +++ b/baselines/ts5.5/serviceworker.generated.d.ts @@ -8527,7 +8527,7 @@ interface LockGrantedCallback { } interface OnErrorEventHandlerNonNull { - (event: Event | string, source?: string, lineno?: number, colno?: number, error?: Error): any; + (event: Event, source?: string, lineno?: number, colno?: number, error?: Error): any; } interface PerformanceObserverCallback { diff --git a/baselines/ts5.5/sharedworker.generated.d.ts b/baselines/ts5.5/sharedworker.generated.d.ts index 02ce26b81..6d0c4ac80 100644 --- a/baselines/ts5.5/sharedworker.generated.d.ts +++ b/baselines/ts5.5/sharedworker.generated.d.ts @@ -8465,7 +8465,7 @@ interface LockGrantedCallback { } interface OnErrorEventHandlerNonNull { - (event: Event | string, source?: string, lineno?: number, colno?: number, error?: Error): any; + (event: Event, source?: string, lineno?: number, colno?: number, error?: Error): any; } interface PerformanceObserverCallback { diff --git a/baselines/ts5.5/webworker.generated.d.ts b/baselines/ts5.5/webworker.generated.d.ts index 196af85d1..e29921472 100644 --- a/baselines/ts5.5/webworker.generated.d.ts +++ b/baselines/ts5.5/webworker.generated.d.ts @@ -9632,7 +9632,7 @@ interface LockGrantedCallback { } interface OnErrorEventHandlerNonNull { - (event: Event | string, source?: string, lineno?: number, colno?: number, error?: Error): any; + (event: Event, source?: string, lineno?: number, colno?: number, error?: Error): any; } interface PerformanceObserverCallback { diff --git a/baselines/webworker.generated.d.ts b/baselines/webworker.generated.d.ts index 196af85d1..e29921472 100644 --- a/baselines/webworker.generated.d.ts +++ b/baselines/webworker.generated.d.ts @@ -9632,7 +9632,7 @@ interface LockGrantedCallback { } interface OnErrorEventHandlerNonNull { - (event: Event | string, source?: string, lineno?: number, colno?: number, error?: Error): any; + (event: Event, source?: string, lineno?: number, colno?: number, error?: Error): any; } interface PerformanceObserverCallback { diff --git a/inputfiles/overridingTypes.jsonc b/inputfiles/overridingTypes.jsonc index 54b76e393..3582bcf31 100644 --- a/inputfiles/overridingTypes.jsonc +++ b/inputfiles/overridingTypes.jsonc @@ -326,6 +326,10 @@ { "name": "error", "overrideType": "Error" + }, + { + "name": "event", + "overrideType": "Event" } ] } From b433480499778d66a6fe5c7fdcbcb8693751f193 Mon Sep 17 00:00:00 2001 From: Basha MEGA Date: Fri, 28 Mar 2025 17:19:27 +0000 Subject: [PATCH 2/8] chore: make it only for GlobalEventHandlers --- baselines/dom.generated.d.ts | 6 +++--- baselines/serviceworker.generated.d.ts | 2 +- baselines/sharedworker.generated.d.ts | 2 +- baselines/ts5.5/dom.generated.d.ts | 6 +++--- baselines/ts5.5/serviceworker.generated.d.ts | 2 +- baselines/ts5.5/sharedworker.generated.d.ts | 2 +- baselines/ts5.5/webworker.generated.d.ts | 2 +- baselines/webworker.generated.d.ts | 2 +- inputfiles/overridingTypes.jsonc | 6 +----- 9 files changed, 13 insertions(+), 17 deletions(-) diff --git a/baselines/dom.generated.d.ts b/baselines/dom.generated.d.ts index 72d550073..01ef974e0 100644 --- a/baselines/dom.generated.d.ts +++ b/baselines/dom.generated.d.ts @@ -9892,7 +9892,7 @@ interface GlobalEventHandlers { * * [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/error_event) */ - onerror: OnErrorEventHandler; + onerror: Event; /** * Fires when the object receives focus. * @param ev The event. @@ -28466,7 +28466,7 @@ interface OnBeforeUnloadEventHandlerNonNull { } interface OnErrorEventHandlerNonNull { - (event: Event, source?: string, lineno?: number, colno?: number, error?: Error): any; + (event: Event | string, source?: string, lineno?: number, colno?: number, error?: Error): any; } interface PerformanceObserverCallback { @@ -29241,7 +29241,7 @@ declare var onended: ((this: Window, ev: Event) => any) | null; * * [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/error_event) */ -declare var onerror: OnErrorEventHandler; +declare var onerror: Event; /** * Fires when the object receives focus. * @param ev The event. diff --git a/baselines/serviceworker.generated.d.ts b/baselines/serviceworker.generated.d.ts index de4908bc5..9e9187f9d 100644 --- a/baselines/serviceworker.generated.d.ts +++ b/baselines/serviceworker.generated.d.ts @@ -8527,7 +8527,7 @@ interface LockGrantedCallback { } interface OnErrorEventHandlerNonNull { - (event: Event, source?: string, lineno?: number, colno?: number, error?: Error): any; + (event: Event | string, source?: string, lineno?: number, colno?: number, error?: Error): any; } interface PerformanceObserverCallback { diff --git a/baselines/sharedworker.generated.d.ts b/baselines/sharedworker.generated.d.ts index 6d0c4ac80..02ce26b81 100644 --- a/baselines/sharedworker.generated.d.ts +++ b/baselines/sharedworker.generated.d.ts @@ -8465,7 +8465,7 @@ interface LockGrantedCallback { } interface OnErrorEventHandlerNonNull { - (event: Event, source?: string, lineno?: number, colno?: number, error?: Error): any; + (event: Event | string, source?: string, lineno?: number, colno?: number, error?: Error): any; } interface PerformanceObserverCallback { diff --git a/baselines/ts5.5/dom.generated.d.ts b/baselines/ts5.5/dom.generated.d.ts index 4bf30ef1d..5893937f9 100644 --- a/baselines/ts5.5/dom.generated.d.ts +++ b/baselines/ts5.5/dom.generated.d.ts @@ -9882,7 +9882,7 @@ interface GlobalEventHandlers { * * [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/error_event) */ - onerror: OnErrorEventHandler; + onerror: Event; /** * Fires when the object receives focus. * @param ev The event. @@ -28444,7 +28444,7 @@ interface OnBeforeUnloadEventHandlerNonNull { } interface OnErrorEventHandlerNonNull { - (event: Event, source?: string, lineno?: number, colno?: number, error?: Error): any; + (event: Event | string, source?: string, lineno?: number, colno?: number, error?: Error): any; } interface PerformanceObserverCallback { @@ -29219,7 +29219,7 @@ declare var onended: ((this: Window, ev: Event) => any) | null; * * [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/error_event) */ -declare var onerror: OnErrorEventHandler; +declare var onerror: Event; /** * Fires when the object receives focus. * @param ev The event. diff --git a/baselines/ts5.5/serviceworker.generated.d.ts b/baselines/ts5.5/serviceworker.generated.d.ts index de4908bc5..9e9187f9d 100644 --- a/baselines/ts5.5/serviceworker.generated.d.ts +++ b/baselines/ts5.5/serviceworker.generated.d.ts @@ -8527,7 +8527,7 @@ interface LockGrantedCallback { } interface OnErrorEventHandlerNonNull { - (event: Event, source?: string, lineno?: number, colno?: number, error?: Error): any; + (event: Event | string, source?: string, lineno?: number, colno?: number, error?: Error): any; } interface PerformanceObserverCallback { diff --git a/baselines/ts5.5/sharedworker.generated.d.ts b/baselines/ts5.5/sharedworker.generated.d.ts index 6d0c4ac80..02ce26b81 100644 --- a/baselines/ts5.5/sharedworker.generated.d.ts +++ b/baselines/ts5.5/sharedworker.generated.d.ts @@ -8465,7 +8465,7 @@ interface LockGrantedCallback { } interface OnErrorEventHandlerNonNull { - (event: Event, source?: string, lineno?: number, colno?: number, error?: Error): any; + (event: Event | string, source?: string, lineno?: number, colno?: number, error?: Error): any; } interface PerformanceObserverCallback { diff --git a/baselines/ts5.5/webworker.generated.d.ts b/baselines/ts5.5/webworker.generated.d.ts index e29921472..196af85d1 100644 --- a/baselines/ts5.5/webworker.generated.d.ts +++ b/baselines/ts5.5/webworker.generated.d.ts @@ -9632,7 +9632,7 @@ interface LockGrantedCallback { } interface OnErrorEventHandlerNonNull { - (event: Event, source?: string, lineno?: number, colno?: number, error?: Error): any; + (event: Event | string, source?: string, lineno?: number, colno?: number, error?: Error): any; } interface PerformanceObserverCallback { diff --git a/baselines/webworker.generated.d.ts b/baselines/webworker.generated.d.ts index e29921472..196af85d1 100644 --- a/baselines/webworker.generated.d.ts +++ b/baselines/webworker.generated.d.ts @@ -9632,7 +9632,7 @@ interface LockGrantedCallback { } interface OnErrorEventHandlerNonNull { - (event: Event, source?: string, lineno?: number, colno?: number, error?: Error): any; + (event: Event | string, source?: string, lineno?: number, colno?: number, error?: Error): any; } interface PerformanceObserverCallback { diff --git a/inputfiles/overridingTypes.jsonc b/inputfiles/overridingTypes.jsonc index 3582bcf31..b9f68fd36 100644 --- a/inputfiles/overridingTypes.jsonc +++ b/inputfiles/overridingTypes.jsonc @@ -162,7 +162,7 @@ "properties": { "property": { "onerror": { - "overrideType": "OnErrorEventHandler" + "overrideType": "Event" }, "ontouchcancel": { "optional": true @@ -326,10 +326,6 @@ { "name": "error", "overrideType": "Error" - }, - { - "name": "event", - "overrideType": "Event" } ] } From b6218c60935bffaedcc26b684931cf9967f545a8 Mon Sep 17 00:00:00 2001 From: Basha MEGA Date: Fri, 28 Mar 2025 17:50:52 +0000 Subject: [PATCH 3/8] unit test --- unittests/files/onerror.ts | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 unittests/files/onerror.ts diff --git a/unittests/files/onerror.ts b/unittests/files/onerror.ts new file mode 100644 index 000000000..b113b2f5a --- /dev/null +++ b/unittests/files/onerror.ts @@ -0,0 +1,6 @@ +// this should not show error +window.onerror = (message: string, source: string, lineno: number, colno: number, error: any) => {}; + +// this also should not show error +declare var img: HTMLImageElement; +img.onerror = (event: Event) => {}; \ No newline at end of file From 42fa1147b71bc5ad7a014d04f71eef958e42d93d Mon Sep 17 00:00:00 2001 From: Basha MEGA Date: Fri, 28 Mar 2025 17:51:00 +0000 Subject: [PATCH 4/8] fix --- baselines/dom.generated.d.ts | 4 ++-- baselines/ts5.5/dom.generated.d.ts | 4 ++-- inputfiles/overridingTypes.jsonc | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/baselines/dom.generated.d.ts b/baselines/dom.generated.d.ts index 01ef974e0..ea60296e4 100644 --- a/baselines/dom.generated.d.ts +++ b/baselines/dom.generated.d.ts @@ -9892,7 +9892,7 @@ interface GlobalEventHandlers { * * [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/error_event) */ - onerror: Event; + onerror: (event: Event) => void; /** * Fires when the object receives focus. * @param ev The event. @@ -29241,7 +29241,7 @@ declare var onended: ((this: Window, ev: Event) => any) | null; * * [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/error_event) */ -declare var onerror: Event; +declare var onerror: (event: Event) => void; /** * Fires when the object receives focus. * @param ev The event. diff --git a/baselines/ts5.5/dom.generated.d.ts b/baselines/ts5.5/dom.generated.d.ts index 5893937f9..168c62969 100644 --- a/baselines/ts5.5/dom.generated.d.ts +++ b/baselines/ts5.5/dom.generated.d.ts @@ -9882,7 +9882,7 @@ interface GlobalEventHandlers { * * [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/error_event) */ - onerror: Event; + onerror: (event: Event) => void; /** * Fires when the object receives focus. * @param ev The event. @@ -29219,7 +29219,7 @@ declare var onended: ((this: Window, ev: Event) => any) | null; * * [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/error_event) */ -declare var onerror: Event; +declare var onerror: (event: Event) => void; /** * Fires when the object receives focus. * @param ev The event. diff --git a/inputfiles/overridingTypes.jsonc b/inputfiles/overridingTypes.jsonc index b9f68fd36..f69656c54 100644 --- a/inputfiles/overridingTypes.jsonc +++ b/inputfiles/overridingTypes.jsonc @@ -162,7 +162,7 @@ "properties": { "property": { "onerror": { - "overrideType": "Event" + "overrideType": "(event: Event) => void" }, "ontouchcancel": { "optional": true From 7c51393d15caa37565a8f20f56fcdbaa9ec3220b Mon Sep 17 00:00:00 2001 From: Bashamega Date: Sat, 29 Mar 2025 14:09:57 +0200 Subject: [PATCH 5/8] revert --- baselines/dom.generated.d.ts | 4 ++-- baselines/ts5.5/dom.generated.d.ts | 4 ++-- inputfiles/overridingTypes.jsonc | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/baselines/dom.generated.d.ts b/baselines/dom.generated.d.ts index ea60296e4..749287a6a 100644 --- a/baselines/dom.generated.d.ts +++ b/baselines/dom.generated.d.ts @@ -9892,7 +9892,7 @@ interface GlobalEventHandlers { * * [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/error_event) */ - onerror: (event: Event) => void; + onerror: OnErrorEventHandler; /** * Fires when the object receives focus. * @param ev The event. @@ -29241,7 +29241,7 @@ declare var onended: ((this: Window, ev: Event) => any) | null; * * [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/error_event) */ -declare var onerror: (event: Event) => void; +declare var onerror: OnErrorEventHandler; /** * Fires when the object receives focus. * @param ev The event. diff --git a/baselines/ts5.5/dom.generated.d.ts b/baselines/ts5.5/dom.generated.d.ts index 168c62969..f7cd2658c 100644 --- a/baselines/ts5.5/dom.generated.d.ts +++ b/baselines/ts5.5/dom.generated.d.ts @@ -9882,7 +9882,7 @@ interface GlobalEventHandlers { * * [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/error_event) */ - onerror: (event: Event) => void; + onerror: OnErrorEventHandler; /** * Fires when the object receives focus. * @param ev The event. @@ -29219,7 +29219,7 @@ declare var onended: ((this: Window, ev: Event) => any) | null; * * [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/error_event) */ -declare var onerror: (event: Event) => void; +declare var onerror: OnErrorEventHandler; /** * Fires when the object receives focus. * @param ev The event. diff --git a/inputfiles/overridingTypes.jsonc b/inputfiles/overridingTypes.jsonc index f69656c54..54b76e393 100644 --- a/inputfiles/overridingTypes.jsonc +++ b/inputfiles/overridingTypes.jsonc @@ -162,7 +162,7 @@ "properties": { "property": { "onerror": { - "overrideType": "(event: Event) => void" + "overrideType": "OnErrorEventHandler" }, "ontouchcancel": { "optional": true From 29ca5bcd68fe77b1d055094883dca32e4a547883 Mon Sep 17 00:00:00 2001 From: Bashamega Date: Sat, 29 Mar 2025 14:23:50 +0200 Subject: [PATCH 6/8] chore: update --- baselines/dom.generated.d.ts | 1 + baselines/ts5.5/dom.generated.d.ts | 1 + inputfiles/addedTypes.jsonc | 4 ++++ unittests/files/onerror.ts | 6 ++++-- 4 files changed, 10 insertions(+), 2 deletions(-) diff --git a/baselines/dom.generated.d.ts b/baselines/dom.generated.d.ts index 749287a6a..5a4d1260c 100644 --- a/baselines/dom.generated.d.ts +++ b/baselines/dom.generated.d.ts @@ -11658,6 +11658,7 @@ interface HTMLImageElement extends HTMLElement { * [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLImageElement/naturalWidth) */ readonly naturalWidth: number; + onerror: (event: Event) => void; /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLImageElement/referrerPolicy) */ referrerPolicy: string; /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLImageElement/sizes) */ diff --git a/baselines/ts5.5/dom.generated.d.ts b/baselines/ts5.5/dom.generated.d.ts index f7cd2658c..edb824345 100644 --- a/baselines/ts5.5/dom.generated.d.ts +++ b/baselines/ts5.5/dom.generated.d.ts @@ -11644,6 +11644,7 @@ interface HTMLImageElement extends HTMLElement { * [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLImageElement/naturalWidth) */ readonly naturalWidth: number; + onerror: (event: Event) => void; /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLImageElement/referrerPolicy) */ referrerPolicy: string; /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLImageElement/sizes) */ diff --git a/inputfiles/addedTypes.jsonc b/inputfiles/addedTypes.jsonc index 3c2041999..87f23ce66 100644 --- a/inputfiles/addedTypes.jsonc +++ b/inputfiles/addedTypes.jsonc @@ -545,6 +545,10 @@ }, "loading": { "overrideType": "\"eager\" | \"lazy\"" + }, + "onerror": { + "name": "onerror", + "overrideType": "(event: Event) => void" } } } diff --git a/unittests/files/onerror.ts b/unittests/files/onerror.ts index b113b2f5a..ef3ae16c9 100644 --- a/unittests/files/onerror.ts +++ b/unittests/files/onerror.ts @@ -1,6 +1,8 @@ +/* eslint-disable @typescript-eslint/no-unused-vars */ +/* eslint-disable no-var */ // this should not show error -window.onerror = (message: string, source: string, lineno: number, colno: number, error: any) => {}; +window.onerror = (_message, _source, _lineno, _colno, _error) => {}; // this also should not show error declare var img: HTMLImageElement; -img.onerror = (event: Event) => {}; \ No newline at end of file +img.onerror = (_event: Event) => {}; From 2242eea002ac92bb56ee249a751bef5e3aca93a4 Mon Sep 17 00:00:00 2001 From: Bashamega Date: Sat, 29 Mar 2025 19:03:24 +0200 Subject: [PATCH 7/8] - --- baselines/dom.generated.d.ts | 2 +- baselines/ts5.5/dom.generated.d.ts | 2 +- inputfiles/addedTypes.jsonc | 14 ++++++++++---- 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a/baselines/dom.generated.d.ts b/baselines/dom.generated.d.ts index 5a4d1260c..083a0e4ba 100644 --- a/baselines/dom.generated.d.ts +++ b/baselines/dom.generated.d.ts @@ -10858,6 +10858,7 @@ interface HTMLElement extends Element, ElementCSSInlineStyle, ElementContentEdit readonly offsetTop: number; /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/offsetWidth) */ readonly offsetWidth: number; + onerror: (event: Event) => void; /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/outerText) */ outerText: string; /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/popover) */ @@ -11658,7 +11659,6 @@ interface HTMLImageElement extends HTMLElement { * [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLImageElement/naturalWidth) */ readonly naturalWidth: number; - onerror: (event: Event) => void; /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLImageElement/referrerPolicy) */ referrerPolicy: string; /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLImageElement/sizes) */ diff --git a/baselines/ts5.5/dom.generated.d.ts b/baselines/ts5.5/dom.generated.d.ts index edb824345..06795c935 100644 --- a/baselines/ts5.5/dom.generated.d.ts +++ b/baselines/ts5.5/dom.generated.d.ts @@ -10846,6 +10846,7 @@ interface HTMLElement extends Element, ElementCSSInlineStyle, ElementContentEdit readonly offsetTop: number; /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/offsetWidth) */ readonly offsetWidth: number; + onerror: (event: Event) => void; /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/outerText) */ outerText: string; /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/popover) */ @@ -11644,7 +11645,6 @@ interface HTMLImageElement extends HTMLElement { * [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLImageElement/naturalWidth) */ readonly naturalWidth: number; - onerror: (event: Event) => void; /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLImageElement/referrerPolicy) */ referrerPolicy: string; /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLImageElement/sizes) */ diff --git a/inputfiles/addedTypes.jsonc b/inputfiles/addedTypes.jsonc index 87f23ce66..e873d1244 100644 --- a/inputfiles/addedTypes.jsonc +++ b/inputfiles/addedTypes.jsonc @@ -545,10 +545,6 @@ }, "loading": { "overrideType": "\"eager\" | \"lazy\"" - }, - "onerror": { - "name": "onerror", - "overrideType": "(event: Event) => void" } } } @@ -1291,6 +1287,16 @@ } } } + }, + "HTMLElement": { + "properties": { + "property": { + "onerror": { + "name": "onerror", + "overrideType": "(event: Event) => void" + } + } + } } } }, From 1cd70dc7d40d21fe0dc4c792113d93179f7f131f Mon Sep 17 00:00:00 2001 From: Bashamega Date: Sat, 29 Mar 2025 19:07:23 +0200 Subject: [PATCH 8/8] format --- inputfiles/addedTypes.jsonc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/inputfiles/addedTypes.jsonc b/inputfiles/addedTypes.jsonc index e873d1244..6a8540bb6 100644 --- a/inputfiles/addedTypes.jsonc +++ b/inputfiles/addedTypes.jsonc @@ -1292,9 +1292,9 @@ "properties": { "property": { "onerror": { - "name": "onerror", - "overrideType": "(event: Event) => void" - } + "name": "onerror", + "overrideType": "(event: Event) => void" + } } } }