From aab4303399fefbbbdaf1b8b3170bf44345545a04 Mon Sep 17 00:00:00 2001 From: Kagami Sascha Rosylight Date: Wed, 26 Feb 2025 09:37:47 +0100 Subject: [PATCH 1/2] Restore StartViewTransitionOptions The multiple implementation requirement is achieved in 2024-09. --- inputfiles/overridingTypes.jsonc | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/inputfiles/overridingTypes.jsonc b/inputfiles/overridingTypes.jsonc index b2ddbd18f..c6ac70a70 100644 --- a/inputfiles/overridingTypes.jsonc +++ b/inputfiles/overridingTypes.jsonc @@ -817,19 +817,6 @@ "overrideType": "NodeListOf" } } - }, - "startViewTransition": { - "signature": { - "0": { - "param": [ - // StartViewTransitionOptions is not implemented as of 2024-06 - { - "name": "callbackOptions", - "type": "ViewTransitionUpdateCallback" - } - ], - } - } } } }, From d2cdcada4794c2de0df98c972c9cd678617919ee Mon Sep 17 00:00:00 2001 From: Kagami Sascha Rosylight Date: Wed, 26 Feb 2025 09:42:14 +0100 Subject: [PATCH 2/2] rebuild --- baselines/dom.generated.d.ts | 7 ++++++- baselines/ts5.5/dom.generated.d.ts | 7 ++++++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/baselines/dom.generated.d.ts b/baselines/dom.generated.d.ts index c83f1d893..c7736d517 100644 --- a/baselines/dom.generated.d.ts +++ b/baselines/dom.generated.d.ts @@ -2090,6 +2090,11 @@ interface SpeechSynthesisEventInit extends EventInit { utterance: SpeechSynthesisUtterance; } +interface StartViewTransitionOptions { + types?: string[] | null; + update?: ViewTransitionUpdateCallback | null; +} + interface StaticRangeInit { endContainer: Node; endOffset: number; @@ -8076,7 +8081,7 @@ interface Document extends Node, DocumentOrShadowRoot, FontFaceSource, GlobalEve /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Document/requestStorageAccess) */ requestStorageAccess(): Promise; /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Document/startViewTransition) */ - startViewTransition(callbackOptions?: ViewTransitionUpdateCallback): ViewTransition; + startViewTransition(callbackOptions?: ViewTransitionUpdateCallback | StartViewTransitionOptions): ViewTransition; /** * Writes one or more HTML expressions to a document in the specified window. * @param content Specifies the text and HTML tags to write. diff --git a/baselines/ts5.5/dom.generated.d.ts b/baselines/ts5.5/dom.generated.d.ts index c83a69912..c8996b123 100644 --- a/baselines/ts5.5/dom.generated.d.ts +++ b/baselines/ts5.5/dom.generated.d.ts @@ -2090,6 +2090,11 @@ interface SpeechSynthesisEventInit extends EventInit { utterance: SpeechSynthesisUtterance; } +interface StartViewTransitionOptions { + types?: string[] | null; + update?: ViewTransitionUpdateCallback | null; +} + interface StaticRangeInit { endContainer: Node; endOffset: number; @@ -8069,7 +8074,7 @@ interface Document extends Node, DocumentOrShadowRoot, FontFaceSource, GlobalEve /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Document/requestStorageAccess) */ requestStorageAccess(): Promise; /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Document/startViewTransition) */ - startViewTransition(callbackOptions?: ViewTransitionUpdateCallback): ViewTransition; + startViewTransition(callbackOptions?: ViewTransitionUpdateCallback | StartViewTransitionOptions): ViewTransition; /** * Writes one or more HTML expressions to a document in the specified window. * @param content Specifies the text and HTML tags to write.