From a5ad86e11bc71c25cbc16c87b567e11ca1928c28 Mon Sep 17 00:00:00 2001 From: Orta Date: Fri, 2 Jul 2021 17:10:58 +0100 Subject: [PATCH 01/18] Try tests on DT --- .github/workflows/test_dt.yml | 48 +++++++++++++++++++++++++++++++++++ 1 file changed, 48 insertions(+) create mode 100644 .github/workflows/test_dt.yml diff --git a/.github/workflows/test_dt.yml b/.github/workflows/test_dt.yml new file mode 100644 index 000000000..18d37b313 --- /dev/null +++ b/.github/workflows/test_dt.yml @@ -0,0 +1,48 @@ +name: Test DT subset +on: [push, pull_request] + +jobs: + deploy: + runs-on: ubuntu-latest + + steps: + - uses: actions/checkout@v2 + - uses: actions/setup-node@v1 + with: + node-version: "15.x" + registry-url: "https://registry.npmjs.org" + - run: npm install + - run: npm run build + + - name: Setup + run: | + git config --global core.longpaths true + git clone https://github.com/microsoft/DefinitelyTyped-tools $BUILD_SOURCESDIRECTORY/DefinitelyTyped-tools --depth 1 + pushd $BUILD_SOURCESDIRECTORY/DefinitelyTyped-tools + npm i + pushd $BUILD_SOURCESDIRECTORY/DefinitelyTyped-tools/packages/dtslint-runner + npm i + npm i typescript@next + node ../../node_modules/typescript/lib/tsc.js + + echo "Nightly run: Shard $SYSTEM_JOBPOSITIONINPHASE of $SYSTEM_TOTALJOBSINPHASE" + node ./dist/index.js --clone $DT_SHA --localTypeScriptPath $BUILD_SOURCESDIRECTORY/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/typescript/lib --selection all --expectOnly --shardId $SYSTEM_JOBPOSITIONINPHASE --shardCount $SYSTEM_TOTALJOBSINPHASE 2>nightlyErrors.txt + + echo "Branch run: Shard $SYSTEM_JOBPOSITIONINPHASE of $SYSTEM_TOTALJOBSINPHASE" + node ./dist/index.js --clone $DT_SHA --localTypeScriptPath $BUILD_SOURCESDIRECTORY/built/local --selection all --expectOnly --shardId $SYSTEM_JOBPOSITIONINPHASE --shardCount $SYSTEM_TOTALJOBSINPHASE 2>branchErrors.txt + branchRunResult=$? + + echo + echo "=== Errors only in nightly ===" + diff --changed-group-format='%<' --unchanged-group-format='' nightlyErrors.txt branchErrors.txt | egrep -v '^(===|[12]>)' + + echo + echo "=== Errors only in branch ===" + diff --changed-group-format='%>' --unchanged-group-format='' nightlyErrors.txt branchErrors.txt | egrep -v '^(===|[12]>)' + + exit $branchRunResult + env: + BUILD_SOURCESDIRECTORY: "/tmp/build" + SYSTEM_JOBPOSITIONINPHASE: "0" + SYSTEM_TOTALJOBSINPHASE: "6" + \ No newline at end of file From fc21c6dd56b5f500d923023d9c987926bb75f613 Mon Sep 17 00:00:00 2001 From: Orta Date: Tue, 6 Jul 2021 09:23:36 +0100 Subject: [PATCH 02/18] Logs --- .github/workflows/test_dt.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/test_dt.yml b/.github/workflows/test_dt.yml index 18d37b313..1c1995893 100644 --- a/.github/workflows/test_dt.yml +++ b/.github/workflows/test_dt.yml @@ -19,18 +19,24 @@ jobs: git config --global core.longpaths true git clone https://github.com/microsoft/DefinitelyTyped-tools $BUILD_SOURCESDIRECTORY/DefinitelyTyped-tools --depth 1 pushd $BUILD_SOURCESDIRECTORY/DefinitelyTyped-tools + echo '1' npm i + echo '2' pushd $BUILD_SOURCESDIRECTORY/DefinitelyTyped-tools/packages/dtslint-runner npm i + echo '3' npm i typescript@next node ../../node_modules/typescript/lib/tsc.js + echo '4' echo "Nightly run: Shard $SYSTEM_JOBPOSITIONINPHASE of $SYSTEM_TOTALJOBSINPHASE" node ./dist/index.js --clone $DT_SHA --localTypeScriptPath $BUILD_SOURCESDIRECTORY/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/typescript/lib --selection all --expectOnly --shardId $SYSTEM_JOBPOSITIONINPHASE --shardCount $SYSTEM_TOTALJOBSINPHASE 2>nightlyErrors.txt + echo '5' echo "Branch run: Shard $SYSTEM_JOBPOSITIONINPHASE of $SYSTEM_TOTALJOBSINPHASE" node ./dist/index.js --clone $DT_SHA --localTypeScriptPath $BUILD_SOURCESDIRECTORY/built/local --selection all --expectOnly --shardId $SYSTEM_JOBPOSITIONINPHASE --shardCount $SYSTEM_TOTALJOBSINPHASE 2>branchErrors.txt branchRunResult=$? + echo '6' echo echo "=== Errors only in nightly ===" From 881afb521b57fe292b50b608c8fc3379de0cbac6 Mon Sep 17 00:00:00 2001 From: Orta Date: Thu, 8 Jul 2021 17:28:20 +0100 Subject: [PATCH 03/18] Yarn --- .github/workflows/test_dt.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test_dt.yml b/.github/workflows/test_dt.yml index 1c1995893..3f60f19af 100644 --- a/.github/workflows/test_dt.yml +++ b/.github/workflows/test_dt.yml @@ -20,10 +20,10 @@ jobs: git clone https://github.com/microsoft/DefinitelyTyped-tools $BUILD_SOURCESDIRECTORY/DefinitelyTyped-tools --depth 1 pushd $BUILD_SOURCESDIRECTORY/DefinitelyTyped-tools echo '1' - npm i + yarn install echo '2' pushd $BUILD_SOURCESDIRECTORY/DefinitelyTyped-tools/packages/dtslint-runner - npm i + yarn install echo '3' npm i typescript@next node ../../node_modules/typescript/lib/tsc.js From e53349c21d055d4f0d7469e809725eccd52d5cee Mon Sep 17 00:00:00 2001 From: Orta Date: Thu, 8 Jul 2021 17:43:30 +0100 Subject: [PATCH 04/18] Moves the generated dom into the TS node_module --- .github/workflows/test_dt.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test_dt.yml b/.github/workflows/test_dt.yml index 3f60f19af..e8a4605a8 100644 --- a/.github/workflows/test_dt.yml +++ b/.github/workflows/test_dt.yml @@ -25,7 +25,8 @@ jobs: pushd $BUILD_SOURCESDIRECTORY/DefinitelyTyped-tools/packages/dtslint-runner yarn install echo '3' - npm i typescript@next + + cp $GITHUB_WORKSPACE/generated/dom.generated.d.ts ../../node_modules/typescript/lib/lib.dom.d.ts node ../../node_modules/typescript/lib/tsc.js echo '4' From e0a7a6e64f9e4055277fb90e09144a67bb21ea0d Mon Sep 17 00:00:00 2001 From: Orta Date: Thu, 8 Jul 2021 17:51:50 +0100 Subject: [PATCH 05/18] Log version --- .github/workflows/test_dt.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/test_dt.yml b/.github/workflows/test_dt.yml index e8a4605a8..98c9706c9 100644 --- a/.github/workflows/test_dt.yml +++ b/.github/workflows/test_dt.yml @@ -27,6 +27,12 @@ jobs: echo '3' cp $GITHUB_WORKSPACE/generated/dom.generated.d.ts ../../node_modules/typescript/lib/lib.dom.d.ts + cp $GITHUB_WORKSPACE/generated/dom.iterable.generated.d.ts ../../node_modules/typescript/lib/lib.dom.iterable.d.ts + cp $GITHUB_WORKSPACE/generated/webworker.generated.d.ts ../../node_modules/typescript/lib/lib.webworker.d.ts + cp $GITHUB_WORKSPACE/generated/webworker.iterable.generated.d.ts ../../node_modules/typescript/lib/lib.webworker.iterable.d.ts + + node ../../node_modules/typescript/lib/tsc.js -v + node ../../node_modules/typescript/lib/tsc.js echo '4' From d3ca5871a201495c79232ff3d120edb62a6e666d Mon Sep 17 00:00:00 2001 From: Orta Date: Thu, 8 Jul 2021 17:58:49 +0100 Subject: [PATCH 06/18] Use my 4.3 branch of DT tools --- .github/workflows/test_dt.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test_dt.yml b/.github/workflows/test_dt.yml index 98c9706c9..ba1819fb2 100644 --- a/.github/workflows/test_dt.yml +++ b/.github/workflows/test_dt.yml @@ -17,7 +17,9 @@ jobs: - name: Setup run: | git config --global core.longpaths true - git clone https://github.com/microsoft/DefinitelyTyped-tools $BUILD_SOURCESDIRECTORY/DefinitelyTyped-tools --depth 1 + git clone https://github.com/microsoft/DefinitelyTyped-tools $BUILD_SOURCESDIRECTORY/DefinitelyTyped-tools + git checkout update_ts + pushd $BUILD_SOURCESDIRECTORY/DefinitelyTyped-tools echo '1' yarn install From 0870e8e668f052fa46493bc85e93b096b248dc80 Mon Sep 17 00:00:00 2001 From: Orta Date: Thu, 8 Jul 2021 18:00:27 +0100 Subject: [PATCH 07/18] Checkout origin --- .github/workflows/test_dt.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test_dt.yml b/.github/workflows/test_dt.yml index ba1819fb2..2be664148 100644 --- a/.github/workflows/test_dt.yml +++ b/.github/workflows/test_dt.yml @@ -18,7 +18,7 @@ jobs: run: | git config --global core.longpaths true git clone https://github.com/microsoft/DefinitelyTyped-tools $BUILD_SOURCESDIRECTORY/DefinitelyTyped-tools - git checkout update_ts + git checkout origin/update_ts pushd $BUILD_SOURCESDIRECTORY/DefinitelyTyped-tools echo '1' From 2aaf12eebf9b082b553f2f80117f9255849b1dbc Mon Sep 17 00:00:00 2001 From: Orta Date: Thu, 8 Jul 2021 18:01:49 +0100 Subject: [PATCH 08/18] Checkout the right place --- .github/workflows/test_dt.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/test_dt.yml b/.github/workflows/test_dt.yml index 2be664148..e77230049 100644 --- a/.github/workflows/test_dt.yml +++ b/.github/workflows/test_dt.yml @@ -18,9 +18,8 @@ jobs: run: | git config --global core.longpaths true git clone https://github.com/microsoft/DefinitelyTyped-tools $BUILD_SOURCESDIRECTORY/DefinitelyTyped-tools - git checkout origin/update_ts - pushd $BUILD_SOURCESDIRECTORY/DefinitelyTyped-tools + git checkout update_ts echo '1' yarn install echo '2' From 151fa35e5735fc1bd69c7c13ccf340f3c487819f Mon Sep 17 00:00:00 2001 From: Orta Date: Thu, 8 Jul 2021 18:16:09 +0100 Subject: [PATCH 09/18] Use the npm version of dtslint-runner --- .github/workflows/test_dt.yml | 43 ++++++++++++----------------------- 1 file changed, 14 insertions(+), 29 deletions(-) diff --git a/.github/workflows/test_dt.yml b/.github/workflows/test_dt.yml index e77230049..7c8b0da30 100644 --- a/.github/workflows/test_dt.yml +++ b/.github/workflows/test_dt.yml @@ -16,35 +16,20 @@ jobs: - name: Setup run: | - git config --global core.longpaths true - git clone https://github.com/microsoft/DefinitelyTyped-tools $BUILD_SOURCESDIRECTORY/DefinitelyTyped-tools - pushd $BUILD_SOURCESDIRECTORY/DefinitelyTyped-tools - git checkout update_ts - echo '1' - yarn install - echo '2' - pushd $BUILD_SOURCESDIRECTORY/DefinitelyTyped-tools/packages/dtslint-runner - yarn install - echo '3' - - cp $GITHUB_WORKSPACE/generated/dom.generated.d.ts ../../node_modules/typescript/lib/lib.dom.d.ts - cp $GITHUB_WORKSPACE/generated/dom.iterable.generated.d.ts ../../node_modules/typescript/lib/lib.dom.iterable.d.ts - cp $GITHUB_WORKSPACE/generated/webworker.generated.d.ts ../../node_modules/typescript/lib/lib.webworker.d.ts - cp $GITHUB_WORKSPACE/generated/webworker.iterable.generated.d.ts ../../node_modules/typescript/lib/lib.webworker.iterable.d.ts - - node ../../node_modules/typescript/lib/tsc.js -v - - node ../../node_modules/typescript/lib/tsc.js - echo '4' - - echo "Nightly run: Shard $SYSTEM_JOBPOSITIONINPHASE of $SYSTEM_TOTALJOBSINPHASE" - node ./dist/index.js --clone $DT_SHA --localTypeScriptPath $BUILD_SOURCESDIRECTORY/DefinitelyTyped-tools/packages/dtslint-runner/node_modules/typescript/lib --selection all --expectOnly --shardId $SYSTEM_JOBPOSITIONINPHASE --shardCount $SYSTEM_TOTALJOBSINPHASE 2>nightlyErrors.txt - echo '5' - - echo "Branch run: Shard $SYSTEM_JOBPOSITIONINPHASE of $SYSTEM_TOTALJOBSINPHASE" - node ./dist/index.js --clone $DT_SHA --localTypeScriptPath $BUILD_SOURCESDIRECTORY/built/local --selection all --expectOnly --shardId $SYSTEM_JOBPOSITIONINPHASE --shardCount $SYSTEM_TOTALJOBSINPHASE 2>branchErrors.txt - branchRunResult=$? - echo '6' + mkdir tester + cd tester + yarn init -y + yarn add typescript@next + yarn add @definitelytyped/dtslint-runner + + cp $GITHUB_WORKSPACE/generated/dom.generated.d.ts node_modules/typescript/lib/lib.dom.d.ts + cp $GITHUB_WORKSPACE/generated/dom.iterable.generated.d.ts node_modules/typescript/lib/lib.dom.iterable.d.ts + cp $GITHUB_WORKSPACE/generated/webworker.generated.d.ts node_modules/typescript/lib/lib.webworker.d.ts + cp $GITHUB_WORKSPACE/generated/webworker.iterable.generated.d.ts node_modules/typescript/lib/lib.webworker.iterable.d.ts + + echo "Branch run - Shard $SYSTEM_JOBPOSITIONINPHASE of $SYSTEM_TOTALJOBSINPHASE" + yarn dtslint-runner --clone --localTypeScriptPath node_modules/typescript/lib --selection all --expectOnly --shardId $SYSTEM_JOBPOSITIONINPHASE --shardCount $SYSTEM_TOTALJOBSINPHASE 2>nightlyErrors.txt + branchRunResult=$ echo echo "=== Errors only in nightly ===" From 55e89c320b6cbf770b4e40dcc9f65d8fd2ea2958 Mon Sep 17 00:00:00 2001 From: Orta Date: Thu, 8 Jul 2021 18:18:54 +0100 Subject: [PATCH 10/18] Log the dtslint logs on CI --- .github/workflows/test_dt.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test_dt.yml b/.github/workflows/test_dt.yml index 7c8b0da30..353879e0c 100644 --- a/.github/workflows/test_dt.yml +++ b/.github/workflows/test_dt.yml @@ -28,7 +28,7 @@ jobs: cp $GITHUB_WORKSPACE/generated/webworker.iterable.generated.d.ts node_modules/typescript/lib/lib.webworker.iterable.d.ts echo "Branch run - Shard $SYSTEM_JOBPOSITIONINPHASE of $SYSTEM_TOTALJOBSINPHASE" - yarn dtslint-runner --clone --localTypeScriptPath node_modules/typescript/lib --selection all --expectOnly --shardId $SYSTEM_JOBPOSITIONINPHASE --shardCount $SYSTEM_TOTALJOBSINPHASE 2>nightlyErrors.txt + yarn dtslint-runner --clone --localTypeScriptPath node_modules/typescript/lib --selection all --expectOnly --shardId $SYSTEM_JOBPOSITIONINPHASE --shardCount $SYSTEM_TOTALJOBSINPHASE branchRunResult=$ echo From daea34930af7e225494f66bdaca5d6845cbae41f Mon Sep 17 00:00:00 2001 From: Orta Date: Thu, 8 Jul 2021 18:21:20 +0100 Subject: [PATCH 11/18] use 1 index --- .github/workflows/test_dt.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/test_dt.yml b/.github/workflows/test_dt.yml index 353879e0c..ac74b1c4b 100644 --- a/.github/workflows/test_dt.yml +++ b/.github/workflows/test_dt.yml @@ -41,7 +41,6 @@ jobs: exit $branchRunResult env: - BUILD_SOURCESDIRECTORY: "/tmp/build" - SYSTEM_JOBPOSITIONINPHASE: "0" + SYSTEM_JOBPOSITIONINPHASE: "1" SYSTEM_TOTALJOBSINPHASE: "6" \ No newline at end of file From 65dc808cf8fbe107e118e8ca96e6f65edd7224a8 Mon Sep 17 00:00:00 2001 From: Orta Date: Thu, 8 Jul 2021 18:40:31 +0100 Subject: [PATCH 12/18] matrix --- .github/workflows/test_dt.yml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test_dt.yml b/.github/workflows/test_dt.yml index ac74b1c4b..bc531180e 100644 --- a/.github/workflows/test_dt.yml +++ b/.github/workflows/test_dt.yml @@ -4,6 +4,9 @@ on: [push, pull_request] jobs: deploy: runs-on: ubuntu-latest + strategy: + matrix: + job_position: [1, 2, 3, 4, 5, 6] steps: - uses: actions/checkout@v2 @@ -28,7 +31,7 @@ jobs: cp $GITHUB_WORKSPACE/generated/webworker.iterable.generated.d.ts node_modules/typescript/lib/lib.webworker.iterable.d.ts echo "Branch run - Shard $SYSTEM_JOBPOSITIONINPHASE of $SYSTEM_TOTALJOBSINPHASE" - yarn dtslint-runner --clone --localTypeScriptPath node_modules/typescript/lib --selection all --expectOnly --shardId $SYSTEM_JOBPOSITIONINPHASE --shardCount $SYSTEM_TOTALJOBSINPHASE + yarn dtslint-runner --clone --localTypeScriptPath node_modules/typescript/lib --selection all --expectOnly --shardId $SYSTEM_JOBPOSITIONINPHASE --shardCount $SYSTEM_TOTALJOBSINPHASE 2>nightlyErrors.txt branchRunResult=$ echo @@ -41,6 +44,6 @@ jobs: exit $branchRunResult env: - SYSTEM_JOBPOSITIONINPHASE: "1" + SYSTEM_JOBPOSITIONINPHASE: ${{ matrix.node }} SYSTEM_TOTALJOBSINPHASE: "6" \ No newline at end of file From d382107c63093068822eb1b5c1420dc77b26f05e Mon Sep 17 00:00:00 2001 From: Orta Date: Thu, 8 Jul 2021 18:43:22 +0100 Subject: [PATCH 13/18] Shards --- .github/workflows/test_dt.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test_dt.yml b/.github/workflows/test_dt.yml index bc531180e..ed09d4e6a 100644 --- a/.github/workflows/test_dt.yml +++ b/.github/workflows/test_dt.yml @@ -2,7 +2,7 @@ name: Test DT subset on: [push, pull_request] jobs: - deploy: + test_shard: runs-on: ubuntu-latest strategy: matrix: @@ -44,6 +44,6 @@ jobs: exit $branchRunResult env: - SYSTEM_JOBPOSITIONINPHASE: ${{ matrix.node }} + SYSTEM_JOBPOSITIONINPHASE: ${{ matrix.job_position }} SYSTEM_TOTALJOBSINPHASE: "6" \ No newline at end of file From e5ee9b20593440f046311fe9d22238c64e8c1e98 Mon Sep 17 00:00:00 2001 From: Orta Date: Fri, 9 Jul 2021 15:45:15 +0100 Subject: [PATCH 14/18] Comments --- .github/workflows/test_typescript.yml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/.github/workflows/test_typescript.yml b/.github/workflows/test_typescript.yml index 32a8f1171..08e423d97 100644 --- a/.github/workflows/test_typescript.yml +++ b/.github/workflows/test_typescript.yml @@ -1,6 +1,16 @@ name: Runs with TypeScript Tests on: [push, pull_request] +# When it's ready +# on: +# push: +# paths: +# - "baselines/*" +# pull_request: +# paths: +# - "baselines/*" + + jobs: test: runs-on: ubuntu-latest From 0090d2851174a52ebb0ae79b7f89c1f3d65cbf72 Mon Sep 17 00:00:00 2001 From: Orta Date: Tue, 27 Jul 2021 17:51:25 +0100 Subject: [PATCH 15/18] Split setup vs test in DT tests --- .github/workflows/test_dt.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/test_dt.yml b/.github/workflows/test_dt.yml index ed09d4e6a..cc2cfc337 100644 --- a/.github/workflows/test_dt.yml +++ b/.github/workflows/test_dt.yml @@ -30,6 +30,9 @@ jobs: cp $GITHUB_WORKSPACE/generated/webworker.generated.d.ts node_modules/typescript/lib/lib.webworker.d.ts cp $GITHUB_WORKSPACE/generated/webworker.iterable.generated.d.ts node_modules/typescript/lib/lib.webworker.iterable.d.ts + - name: Tests + run: | + cd tester echo "Branch run - Shard $SYSTEM_JOBPOSITIONINPHASE of $SYSTEM_TOTALJOBSINPHASE" yarn dtslint-runner --clone --localTypeScriptPath node_modules/typescript/lib --selection all --expectOnly --shardId $SYSTEM_JOBPOSITIONINPHASE --shardCount $SYSTEM_TOTALJOBSINPHASE 2>nightlyErrors.txt branchRunResult=$ From a22f5d3978154196edad99f099768de58eaa02cd Mon Sep 17 00:00:00 2001 From: Orta Date: Tue, 27 Jul 2021 17:53:59 +0100 Subject: [PATCH 16/18] Only run on PR --- .github/workflows/test_dt.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test_dt.yml b/.github/workflows/test_dt.yml index cc2cfc337..3095e27e4 100644 --- a/.github/workflows/test_dt.yml +++ b/.github/workflows/test_dt.yml @@ -1,5 +1,5 @@ name: Test DT subset -on: [push, pull_request] +on: [pull_request] jobs: test_shard: From 737bb63dacb8706e14ddef57900cdc1238dcbf56 Mon Sep 17 00:00:00 2001 From: Orta Date: Tue, 27 Jul 2021 18:22:05 +0100 Subject: [PATCH 17/18] Try continue on error --- .github/workflows/test_dt.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/test_dt.yml b/.github/workflows/test_dt.yml index 3095e27e4..56a734a00 100644 --- a/.github/workflows/test_dt.yml +++ b/.github/workflows/test_dt.yml @@ -46,6 +46,7 @@ jobs: diff --changed-group-format='%>' --unchanged-group-format='' nightlyErrors.txt branchErrors.txt | egrep -v '^(===|[12]>)' exit $branchRunResult + continue-on-error: true env: SYSTEM_JOBPOSITIONINPHASE: ${{ matrix.job_position }} SYSTEM_TOTALJOBSINPHASE: "6" From 29d32c4bf41b29714826aa7dee306444b281e045 Mon Sep 17 00:00:00 2001 From: Orta Date: Tue, 27 Jul 2021 18:58:49 +0100 Subject: [PATCH 18/18] Add a nightly run also --- .github/workflows/test_dt.yml | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/.github/workflows/test_dt.yml b/.github/workflows/test_dt.yml index 56a734a00..925bfdb85 100644 --- a/.github/workflows/test_dt.yml +++ b/.github/workflows/test_dt.yml @@ -25,16 +25,19 @@ jobs: yarn add typescript@next yarn add @definitelytyped/dtslint-runner + - name: Tests + run: | + cd tester + echo "Nightly run: Shard $SYSTEM_JOBPOSITIONINPHASE of $SYSTEM_TOTALJOBSINPHASE" + yarn dtslint-runner --clone --localTypeScriptPath node_modules/typescript/lib --selection all --expectOnly --shardId $SYSTEM_JOBPOSITIONINPHASE --shardCount $SYSTEM_TOTALJOBSINPHASE 2>nightlyErrors.txt + cp $GITHUB_WORKSPACE/generated/dom.generated.d.ts node_modules/typescript/lib/lib.dom.d.ts cp $GITHUB_WORKSPACE/generated/dom.iterable.generated.d.ts node_modules/typescript/lib/lib.dom.iterable.d.ts cp $GITHUB_WORKSPACE/generated/webworker.generated.d.ts node_modules/typescript/lib/lib.webworker.d.ts cp $GITHUB_WORKSPACE/generated/webworker.iterable.generated.d.ts node_modules/typescript/lib/lib.webworker.iterable.d.ts - - name: Tests - run: | - cd tester echo "Branch run - Shard $SYSTEM_JOBPOSITIONINPHASE of $SYSTEM_TOTALJOBSINPHASE" - yarn dtslint-runner --clone --localTypeScriptPath node_modules/typescript/lib --selection all --expectOnly --shardId $SYSTEM_JOBPOSITIONINPHASE --shardCount $SYSTEM_TOTALJOBSINPHASE 2>nightlyErrors.txt + yarn dtslint-runner --clone --localTypeScriptPath node_modules/typescript/lib --selection all --expectOnly --shardId $SYSTEM_JOBPOSITIONINPHASE --shardCount $SYSTEM_TOTALJOBSINPHASE 2>branchErrors.txt branchRunResult=$ echo