Skip to content

Commit 5e66360

Browse files
authored
Merge pull request #339 from qm3ster/master
Update README.md (merge this 😉)
2 parents a174e93 + d164509 commit 5e66360

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

README.md

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
AppVeyor Status: [![Build status](https://ci.appveyor.com/api/projects/status/8oj3j7u6nvag1xvu/branch/master?svg=true)](https://ci.appveyor.com/project/zhengbli/tsjs-lib-generator/branch/master)
44
Travis CI Status: [![Build Status](https://travis-ci.org/Microsoft/TSJS-lib-generator.svg?branch=master)](https://travis-ci.org/Microsoft/TSJS-lib-generator)
55

6-
This tool is used to generate `dom.generated.d.ts` and `webworker.generated.d.ts` for TypeScript, and `domWeb.js` and `domWindows.js` for Visual Studio JavaScript language service.
6+
This tool is used to generate `dom.generated.d.ts`, `webworker.generated.d.ts` and `dom.es6.generated.d.ts` for TypeScript.
77
The input file is the XML spec file generated by the Microsoft Edge browser.
88

99
## Build Instructions
@@ -15,12 +15,15 @@ Note: for OS X and Unix users, [Mono 4.2 or higher](http://www.mono-project.com/
1515

1616
## Contribution Guidelines
1717

18-
The `dom.generated.d.ts` and `webworker.generated.d.ts` files in the TypeScript repo are used as baselines.
18+
The `dom.generated.d.ts`, `webworker.generated.d.ts` and `dom.es6.generated.d.ts` files from the TypeScript repo are used as baselines.
1919
For each pull request, we will run the script and compare the generated files with the baseline files.
2020
In order to make the tests pass, please update the baseline as well in any pull requests.
2121

2222
For common changes, it is sufficient to change the json files.
23-
There are three json files that are used to alter the file generation: `addedTypes.json`, `overridingTypes.json`, and `removedTypes.json`.
23+
There are three json files that are typically used to alter the type generation: `addedTypes.json`, `overridingTypes.json`, and `removedTypes.json`.
24+
`comments.json` can used to add comments to the types.
25+
Finally, `knownWorkerEnums` and `knownWorkerInterfaces` determine which types are available in a WebWorker environment.
26+
2427
The format of each file can be inferred from their existing content.
2528

2629
The common steps to send a pull request are:
@@ -50,9 +53,8 @@ A "Living Standard" ([example](https://xhr.spec.whatwg.org/)) should be added he
5053

5154
## Code Structure
5255

53-
- `Shared.fs`: handles the parsing from XML spec file, and stores the common data structures for later use.
54-
- `TS.fs`: handles the emitting of the `lib.d.ts` file.
55-
- `JS.fs`: handles the emitting of the `domWeb.js` and `domWindows.js`.
56+
- `Build.fsx`: Runs `TS.fsx` for all targets, then does a snapshot test by comparing the `generated/` and `baseline/` contents.
57+
- `TS.fsx`: handles the emitting of the `.d.ts` files.
5658

5759
## Input Files
5860

@@ -63,5 +65,4 @@ A "Living Standard" ([example](https://xhr.spec.whatwg.org/)) should be added he
6365
- `overridingTypes.json`: types that are defined in the spec file but has a better or more up-to-date definitions in the json files.
6466
- `removedTypes.json`: types that are defined in the spec file but should be removed.
6567
- `comments.json`: comment strings to be embedded in the generated .js files.
66-
- `jsTemplate.js`: the initial templates for `domWeb.js` and `domWindows.js`, which contains the necessary helper functions.
67-
- `sample.json`: sample json file used to tell F# json type provider that structure of the json files. The content of it is not used anywhere.
68+
- `sample.json`: sample json file used to tell F# json type provider that structure of the json files. The content of it is not used anywhere. **Do not edit this file**.

0 commit comments

Comments
 (0)