Skip to content

Commit ce516b2

Browse files
committed
Use an environment marker to install future only on Python 2
An environment marker is already used for `enum34` so why do it differently for `future`? https://peps.python.org/pep-0508/#environment-markers ref aws#343
1 parent 6e30483 commit ce516b2

File tree

1 file changed

+6
-12
lines changed

1 file changed

+6
-12
lines changed

setup.py

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
import sys
2-
31
from setuptools import setup, find_packages
42
from os import path
53
from aws_xray_sdk.version import VERSION
@@ -14,15 +12,6 @@
1412

1513
long_description = read_md(path.join(CURRENT_DIR, 'README.md'))
1614

17-
INSTALL_REQUIRED_DEPS = [
18-
'enum34;python_version<"3.4"',
19-
'wrapt',
20-
'botocore>=1.11.3',
21-
]
22-
23-
if sys.version_info[0] == 2:
24-
INSTALL_REQUIRED_DEPS.append("future")
25-
2615
setup(
2716
name='aws-xray-sdk',
2817
version=VERSION,
@@ -55,7 +44,12 @@
5544
'Programming Language :: Python :: 3.9',
5645
],
5746

58-
install_requires=INSTALL_REQUIRED_DEPS,
47+
install_requires=[
48+
'enum34;python_version<"3.4"',
49+
'wrapt',
50+
'future;python_version<"3"',
51+
'botocore>=1.11.3',
52+
],
5953

6054
keywords='aws xray sdk',
6155

0 commit comments

Comments
 (0)