Skip to content

Commit 7ad8dda

Browse files
jseterSergi Almacellas Abellana
jseter
authored and
Sergi Almacellas Abellana
committed
Address deepEqual using compare by JSON strings. (#724)
1 parent e536351 commit 7ad8dda

File tree

2 files changed

+11
-8
lines changed

2 files changed

+11
-8
lines changed

papaparse.js

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1364,12 +1364,15 @@ License: MIT
13641364

13651365
function addError(type, code, msg, row)
13661366
{
1367-
_results.errors.push({
1367+
var error = {
13681368
type: type,
13691369
code: code,
1370-
message: msg,
1371-
row: row
1372-
});
1370+
message: msg
1371+
};
1372+
if(row !== undefined) {
1373+
error.row = row;
1374+
}
1375+
_results.errors.push(error);
13731376
}
13741377
}
13751378

tests/test-cases.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -592,7 +592,7 @@ describe('Core Parser Tests', function() {
592592
function generateTest(test) {
593593
(test.disabled ? it.skip : it)(test.description, function() {
594594
var actual = new Papa.Parser(test.config).parse(test.input);
595-
assert.deepEqual(JSON.stringify(actual.errors), JSON.stringify(test.expected.errors));
595+
assert.deepEqual(actual.errors, test.expected.errors);
596596
assert.deepEqual(actual.data, test.expected.data);
597597
});
598598
}
@@ -1475,7 +1475,7 @@ describe('Parse Tests', function() {
14751475
if (test.expected.meta) {
14761476
assert.deepEqual(actual.meta, test.expected.meta);
14771477
}
1478-
assert.deepEqual(JSON.stringify(actual.errors), JSON.stringify(test.expected.errors));
1478+
assert.deepEqual(actual.errors, test.expected.errors);
14791479
assert.deepEqual(actual.data, test.expected.data);
14801480
});
14811481
}
@@ -1556,7 +1556,7 @@ describe('Parse Async Tests', function() {
15561556
var config = test.config;
15571557

15581558
config.complete = function(actual) {
1559-
assert.deepEqual(JSON.stringify(actual.errors), JSON.stringify(test.expected.errors));
1559+
assert.deepEqual(actual.errors, test.expected.errors);
15601560
assert.deepEqual(actual.data, test.expected.data);
15611561
done();
15621562
};
@@ -2384,7 +2384,7 @@ describe('Custom Tests', function() {
23842384
this.timeout(test.timeout);
23852385
}
23862386
test.run(function(actual) {
2387-
assert.deepEqual(JSON.stringify(actual), JSON.stringify(test.expected));
2387+
assert.deepEqual(actual, test.expected);
23882388
done();
23892389
});
23902390
});

0 commit comments

Comments
 (0)