Skip to content

Commit c50e128

Browse files
ggerganovmglambda
authored andcommitted
ggml : do not install metal source when embed library (ggml/1054)
1 parent ad80237 commit c50e128

File tree

2 files changed

+16
-20
lines changed

2 files changed

+16
-20
lines changed

ggml/CMakeLists.txt

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -252,26 +252,6 @@ set_target_properties(ggml PROPERTIES PUBLIC_HEADER "${GGML_PUBLIC_HEADERS}")
252252
install(TARGETS ggml LIBRARY PUBLIC_HEADER)
253253
install(TARGETS ggml-base LIBRARY)
254254

255-
# FIXME: this should be done in the backend cmake files
256-
if (GGML_METAL)
257-
# FIXME: does this need to be installed with GGML_METAL_EMBED_LIBRARY?
258-
install(
259-
FILES src/ggml-metal/ggml-metal.metal
260-
PERMISSIONS
261-
OWNER_READ
262-
OWNER_WRITE
263-
GROUP_READ
264-
WORLD_READ
265-
DESTINATION ${CMAKE_INSTALL_BINDIR})
266-
267-
if (NOT GGML_METAL_EMBED_LIBRARY)
268-
install(
269-
FILES ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/default.metallib
270-
DESTINATION ${CMAKE_INSTALL_BINDIR}
271-
)
272-
endif()
273-
endif()
274-
275255
if (GGML_STANDALONE)
276256
configure_file(${CMAKE_CURRENT_SOURCE_DIR}/ggml.pc.in
277257
${CMAKE_CURRENT_BINARY_DIR}/ggml.pc

ggml/src/ggml-metal/CMakeLists.txt

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,3 +103,19 @@ else()
103103
DEPENDS ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/default.metallib
104104
)
105105
endif() # GGML_METAL_EMBED_LIBRARY
106+
107+
if (NOT GGML_METAL_EMBED_LIBRARY)
108+
install(
109+
FILES src/ggml-metal/ggml-metal.metal
110+
PERMISSIONS
111+
OWNER_READ
112+
OWNER_WRITE
113+
GROUP_READ
114+
WORLD_READ
115+
DESTINATION ${CMAKE_INSTALL_BINDIR})
116+
117+
install(
118+
FILES ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/default.metallib
119+
DESTINATION ${CMAKE_INSTALL_BINDIR}
120+
)
121+
endif()

0 commit comments

Comments
 (0)